I'm probably wrong, but my interpretation is that this ends up being an no-op on windows.
But without moving it down, setsockopt() would fail, and I can't establish connections to NVP controller. Linda -----Original Message----- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Friday, June 13, 2014 1:51 PM To: Linda Sun Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is established for SSL. Is TCP_NODELAY actually the right way to disable Nagle on Windows? The Microsoft documentation at https://urldefense.proofpoint.com/v1/url?u=http://msdn.microsoft.com/en-us/library/windows/desktop/ms740476%28v%3Dvs.85%29.aspx&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=0mp263sOpVS3FERoXOmmtg%3D%3D%0A&m=0oHBrPE3FONW53R0hYpHTAcZm1ApEGdfKL7qAhzJscQ%3D%0A&s=b72ea5447c6713313e2d67a8ffdec744212b5644edb09d1d31fa395f7458c0a4 says that "This socket option is included for backward compatibility with Windows Sockets 1.1" which implies that there's some better way to do it. On Fri, Jun 13, 2014 at 08:45:32PM +0000, Linda Sun wrote: > On windows platform, setsockopt would return invalid argument if > called before tcp is connected. > > Linda > > -----Original Message----- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Friday, June 13, 2014 1:36 PM > To: Linda Sun > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] Only set TCP_NODELAY after connection is > established for SSL. > > On Fri, Jun 13, 2014 at 01:35:18PM -0700, Linda Sun wrote: > > Signed-off-by: Linda Sun <l...@vmware.com> > > Why? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
