On Fri, Jun 13, 2014 at 01:22:46PM -0700, Ben Pfaff wrote:
> On Wed, Jun 11, 2014 at 01:34:41PM +0900, Simon Horman wrote:
> > Add helpers for allowing requests and use them in handle_openflow__().
> >
> > This is a in preparation for supporting multipart requests
> > on a per message type basis.
> >
> > Signed-off-by: Simon Horman <ho...@verge.net.au>
>
> As is, ofpmsg_is_mp_request() could more concisely be implemented as
> return oh->version >= OFP13_VERSION && ofpmsg_is_mp_request(oh);
>
> ofpmsg_is_mp_request() is documented as:
> > +/* Return if it's a multpart request message
> > + * with more parts to follow */
> which implies to me that it should check for the "more" bit (with
> ofpmp_more()), but it doesn't do that.
>
> Maybe this is a bug in the documentation, because the one caller
> checks for ofpmp_more() itself:
> > + if (ofpmsg_is_mp_request(oh) && ofpmp_more(oh)
> > + && !ofpmsg_may_buffer_mp_request(type)) {
> > + /* Report overflow for requests which consist of multiple message
> > + * for which multiple message handling is not available. */
> > return OFPERR_OFPBRC_MULTIPART_BUFFER_OVERFLOW;
> > }
>
> Thanks,
>
> Ben.
Also the compiler complains about the unused 'type' parameter:
../lib/ofp-msgs.c:885:43: error: unused parameter 'type'
[-Werror,-Wunused-parameter]
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
