Re: [ovs-dev] [bug15637 v2 1/2] ovsdb-client: Make "monitor" command able to monitor all tables.

2013-11-27 Thread Alex Wang
LGTM, two comments below, +if (get_detach()) { > +int error; > + > +error = unixctl_server_create(NULL, &unixctl); > +if (error) { > +ovs_fatal(error, "failed to create unixctl server"); > +} > + > +unixctl_command_register("exit", "", 0, 0,

Re: [ovs-dev] [PATCH openvswitch] netlink: Implement & enable memory mapped netlink i/o

2013-11-27 Thread Thomas Graf
On 11/26/2013 12:02 AM, Ben Pfaff wrote: On Thu, Nov 21, 2013 at 07:16:54PM +0100, Thomas Graf wrote: Based on the initial patch by Cong Wang posted a couple of months ago. This is the user space counterpart needed for the kernel patch '[PATCH net-next 3/8] openvswitch: Enable memory mapped Net

Re: [ovs-dev] [PATCH openvswitch] linux: Signal datapath that unaligned Netlink message can be received

2013-11-27 Thread Thomas Graf
On 11/26/2013 12:41 AM, Jesse Gross wrote: On Thu, Nov 21, 2013 at 10:15 AM, Thomas Graf wrote: diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index 1dcf321..5c952bc 100644 --- a/lib/dpif-linux.c +++ b/lib/dpif-linux.c @@ -232,6 +233,7 @@ dpif_linux_open(const struct dpif_class *class OVS_UNU

Re: [ovs-dev] [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath

2013-11-27 Thread Thomas Graf
On 11/25/13 at 03:40pm, Jesse Gross wrote: > On Fri, Nov 22, 2013 at 8:56 AM, Thomas Graf wrote: > > diff --git a/include/uapi/linux/openvswitch.h > > b/include/uapi/linux/openvswitch.h > > index 07ef2c3..a6863e2 100644 > > --- a/include/uapi/linux/openvswitch.h > > +++ b/include/uapi/linux/openv

Re: [ovs-dev] [PATCH net-next 6/8] openvswitch: Allow update of dp with OVS_DP_CMD_NEW if NLM_F_REPLACE is set

2013-11-27 Thread Thomas Graf
On 11/25/13 at 01:23pm, Jesse Gross wrote: > On Fri, Nov 22, 2013 at 8:56 AM, Thomas Graf wrote: > > diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c > > index 95d4424..3f1fb87 100644 > > --- a/net/openvswitch/datapath.c > > +++ b/net/openvswitch/datapath.c > > I'm a little wo

Re: [ovs-dev] [PATCH] ofproto: Add OF1.4 elements to enum ofp_table_config

2013-11-27 Thread Jarno Rajahalme
> On Nov 26, 2013, at 9:23 PM, Simon Horman wrote: > > Ben previously indicated that he would like to stick with > the OFPTC_TABLE_MISS_MASK name. With that in mind perhaps it > would be best to put a comment above OFPTC_TABLE_MISS_MASK noting > that its has a different name but the same value i

[ovs-dev] Invitation: MESSAGE FROM DR. JOSEPH APPIAH, REPLY @ Wed Nov 27, 2013 8:30am - 9:30am (josephappia...@gmail.com)

2013-11-27 Thread josephappia...@gmail.com
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20131127T133000Z DTEND:20131127T143000Z DTSTAMP:20131127T131342Z ORGANIZER;CN=josephappia...@gmail.com:mailto:josephappia...@gmail.com UID:6fna8j31ifl1g05o37k4fdo...@

[ovs-dev] Invitation: MESSAGE FROM DR. JOSEPH APPIAH, REPLY @ Wed Nov 27, 2013 8am - 9am (josephappia...@gmail.com)

2013-11-27 Thread josephappia...@gmail.com
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20131127T13Z DTEND:20131127T14Z DTSTAMP:20131127T125411Z ORGANIZER;CN=josephappia...@gmail.com:mailto:josephappia...@gmail.com UID:fnnj3ddu99flvm27f2ffmi7...@

[ovs-dev] [PATCH] Use libtool for lib creation and allow building shared libs

2013-11-27 Thread Helmut Schaa
Currently openvswitch builds all libraries static only. However, libopenvswitch is linked into nearly all openvswitch executables making it hardly possible to run openvswitch on embedded devices (for example running OpenWrt). Convert openvswitch to use libtool for building its internal libs. This