LGTM, two comments below,
+ if (get_detach()) {
> + int error;
> +
> + error = unixctl_server_create(NULL, &unixctl);
> + if (error) {
> + ovs_fatal(error, "failed to create unixctl server");
> + }
> +
> + unixctl_command_register("exit", "", 0, 0,
> + ovsdb_client_exit, &exiting);
> + unixctl_command_register("ovsdb-client/block", "", 0, 0,
> + ovsdb_client_block, &blocked);
> + unixctl_command_register("ovsdb-client/unblock", "", 0, 0,
> + ovsdb_client_unblock, &blocked);
> + } else {
> + unixctl = NULL;
> }
>
1. Should we also check get_pidfile here? Since otherwise, we won't have a
target.
2. In order to monitor all table, I really need to maximize the terminal
screen and minimize the font,
since there are so many columns in a row. Seems to me that I cannot
specify columns when
'monitor ALL', because there is hardly any column shared by all tables.
Are these the intended
behavior.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
