Re: [ovs-dev] [PATCH v2 1/8] ofp-msgs: Fix limits of OFPMP_TABLE_FEATURES.

2013-11-12 Thread Simon Horman
On Wed, Nov 06, 2013 at 10:45:26PM +0800, Alexander Wu wrote: > > V2: > No change. > > V1: > Fix the limits to right ones. > > Signed-off-by: Alexander Wu Reviewed-by: Simon Horman > --- > lib/ofp-msgs.h |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/l

Re: [ovs-dev] [PATCH 2/4] ofproto: Add enum ofp_table_config

2013-11-12 Thread Simon Horman
On Tue, Nov 12, 2013 at 09:58:09PM -0800, Ben Pfaff wrote: > On Tue, Nov 12, 2013 at 05:52:37PM -0800, Jarno Rajahalme wrote: > > > > > > > On Nov 12, 2013, at 8:47 AM, Ben Pfaff wrote: > > > > > >> On Tue, Nov 12, 2013 at 04:45:51PM +0900, Simon Horman wrote: > > ... > > >> +enum ofp_table_con

[ovs-dev] [PATCH] ofproto-dpif: test set_mpls_{label,tc} actions

2013-11-12 Thread Simon Horman
Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 846439c..bbb9c02 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -402,7 +402,7 @@ cookie=0x7 table=5 in_p

[ovs-dev] [PATCH] ovs-ofctl: Document set_mpls_{label,tc} actions

2013-11-12 Thread Simon Horman
Signed-off-by: Simon Horman --- utilities/ovs-ofctl.8.in | 9 + 1 file changed, 9 insertions(+) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index f8feb6d..7c31386 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -1257,6 +1257,15 @@ invalid ttl

[ovs-dev] [PATCH] OPENFLOW-1.1+: Update MPLS items

2013-11-12 Thread Simon Horman
* MPLS BoS match is supported as much as other MPLS matches. That is, all that is missing is the kernel datapath side which is part my pending patchset. * The rework of tag order does require work but it is covered by my pending patchset. --- OPENFLOW-1.1+ | 7 --- 1 file changed, 4 ins

[ovs-dev] [PATCH] ovs-ofctl: Document mpls_{label,bos,tc} matches

2013-11-12 Thread Simon Horman
Signed-off-by: Simon Horman --- utilities/ovs-ofctl.8.in | 24 1 file changed, 24 insertions(+) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index f8feb6d..01376e4 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -967,6 +967,30

[ovs-dev] [PATCH] ofproto-dpif: test ARP SPA and TPA load actions

2013-11-12 Thread Simon Horman
Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 846439c..caf0b98 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -413,7 +413,7 @@ cookie=0xa d

[ovs-dev] [PATCH] ovs-ofctl: Document masked versions of arp_sha and arp_tha matches

2013-11-12 Thread Simon Horman
Document masked versions of arp_sha and arp_tha matches. Also update documentation of unmasked versions of these matches to include an example address as is the case with the documentation of dl_src and dl_dst. Signed-off-by: Simon Horman --- utilities/ovs-ofctl.8.in | 11 ++- 1 file ch

[ovs-dev] [PATCH] ovs-ofctl: Document masked versions of arp_sha and arp_tha matches

2013-11-12 Thread Simon Horman
Document masked versions of arp_sha and arp_tha matches. Also update documentation of unmasked versions of these matches to include an example address as is the case with the documentation of dl_src and dl_dst. Signed-off-by: Simon Horman --- utilities/ovs-ofctl.8.in | 11 ++- 1 file cha

Re: [ovs-dev] [PATCH] linux: Signal datapath that unaligned Netlink message can be received

2013-11-12 Thread Jesse Gross
On Mon, Nov 11, 2013 at 11:53 PM, Thomas Graf wrote: > On 11/11/2013 04:50 PM, Ben Pfaff wrote: >> >> On Mon, Nov 11, 2013 at 04:36:24PM +0100, Thomas Graf wrote: >>> >>> Following commit (''netlink: Do not enforce alignment of last Netlink >>> attribute''), signal the ability to receive unaligned

Re: [ovs-dev] OpenFlow1.2+ Action Translation

2013-11-12 Thread Ben Pfaff
On Wed, Nov 13, 2013 at 03:06:04PM +0900, Simon Horman wrote: > I have a question regarding the following entry in OPENFLOW-1.1+: > > * Action translation needs some work to transform OpenFlow 1.1 > field modification actions into OpenFlow 1.2+ "set-field" > actions, because OpenFl

[ovs-dev] OpenFlow1.2+ Action Translation

2013-11-12 Thread Simon Horman
Hi, I have a question regarding the following entry in OPENFLOW-1.1+: * Action translation needs some work to transform OpenFlow 1.1 field modification actions into OpenFlow 1.2+ "set-field" actions, because OpenFlow 1.2 dropped support for the OF1.1 actions. Has this been

Re: [ovs-dev] [PATCH 2/4] ofproto: Add enum ofp_table_config

2013-11-12 Thread Ben Pfaff
On Tue, Nov 12, 2013 at 05:52:37PM -0800, Jarno Rajahalme wrote: > > > > On Nov 12, 2013, at 8:47 AM, Ben Pfaff wrote: > > > >> On Tue, Nov 12, 2013 at 04:45:51PM +0900, Simon Horman wrote: > ... > >> +enum ofp_table_config { > >> +OFPTC_TABLE_MISS_CONTROLLER = 0,/* Send to controller.

Re: [ovs-dev] [PATCH] netlink: Do not enforce alignment of last Netlink attribute

2013-11-12 Thread Jesse Gross
On Mon, Nov 11, 2013 at 11:42 PM, Ben Pfaff wrote: > On Mon, Nov 11, 2013 at 12:11:36PM +0100, Thomas Graf wrote: >> There is no reason to enforce padding after the last attribute. >> Dropping this enforcement will ease efforts to implement zerocopy >> upcall. >> >> Signed-off-by: Thomas Graf > >

[ovs-dev] [PATCH v2 1/2] ofproto: Add table config to struct ofproto

2013-11-12 Thread Simon Horman
Add table config to to struct ofproto and set it when a table mod message is received. This is in preparation for changing the behaviour of the switch based on table config. Cc: Andy Zhou Signed-off-by: Simon Horman --- v2 * Add OVS_EXCLUDED annotation to table_set_config(). This was mistak

[ovs-dev] [PATCH v2 2/2] ofproto: Honour Table Mod settings for table-miss handling

2013-11-12 Thread Simon Horman
This reworks lookup of rules for both table 0 and table action translation. The result is that Table Mod settings, which can alter the miss-behaviour of tables, including table 0, on a per-table basis may be honoured. Previous patches proposed by myself which build on earlier merged patches by And

[ovs-dev] [PATCH v2 0/2] ofproto: Honour Table Mod settings for table-miss handling

2013-11-12 Thread Simon Horman
This series of patches adds support for using Table Mod settings for table-miss handling. This series does not alter the default behaviour of Open vSwitch. And in particular the OpenFlow1.1 behaviour is the default regardless of which OpenFlow version is negotiated between the switch and the contr

Re: [ovs-dev] [PATCH 2/4] ofproto: Add enum ofp_table_config

2013-11-12 Thread Jarno Rajahalme
> On Nov 12, 2013, at 8:47 AM, Ben Pfaff wrote: > >> On Tue, Nov 12, 2013 at 04:45:51PM +0900, Simon Horman wrote: ... >> +enum ofp_table_config { >> +OFPTC_TABLE_MISS_CONTROLLER = 0,/* Send to controller. */ >> +OFPTC_TABLE_MISS_CONTINUE = 1 << 0, /* Continue to the next table in t

Re: [ovs-dev] [PATCH] dpif: Document datapath masking.

2013-11-12 Thread Ben Pfaff
On Tue, Nov 12, 2013 at 04:10:02PM -0800, Andy Zhou wrote: > Thanks a lot for adding more comments on mega flow implementation. > > Only a minor comment inline. Otherwise it looks good. > > Acked-by: Andy Zhou Thanks a lot! I fixed the mistake you mentioned and applied this to master. ___

Re: [ovs-dev] [PATCH 2/4] ofproto: Add enum ofp_table_config

2013-11-12 Thread Simon Horman
On Tue, Nov 12, 2013 at 08:47:45AM -0800, Ben Pfaff wrote: > On Tue, Nov 12, 2013 at 04:45:51PM +0900, Simon Horman wrote: > > Cc: Andy Zhou > > Signed-off-by: Simon Horman > > --- > > include/openflow/openflow-common.h | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/incl

Re: [ovs-dev] [PATCH] dpif: Document datapath masking.

2013-11-12 Thread Andy Zhou
Thanks a lot for adding more comments on mega flow implementation. Only a minor comment inline. Otherwise it looks good. Acked-by: Andy Zhou On Tue, Nov 12, 2013 at 3:20 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/dpif.c | 12 > lib/dpif.h | 44 +++

Re: [ovs-dev] [PATCH v2] dpif-netdev: Introduce a classifier in userspace datapath.

2013-11-12 Thread Ben Pfaff
On Mon, Nov 04, 2013 at 06:23:54AM -0800, Gurucharan Shetty wrote: > Instead of an exact match flow table, we introduce a classifier. > This enables mega-flows in userspace datapath. > > Signed-off-by: Gurucharan Shetty dp_netdev_lookup_flow() now makes less sense to me than before. Can the HMA

[ovs-dev] [PATCH] dpif: Document datapath masking.

2013-11-12 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/dpif.c | 12 lib/dpif.h | 44 +++- 2 files changed, 43 insertions(+), 13 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index 783a7cb..63a7ab6 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -883,15 +883,19

Re: [ovs-dev] [PATCH v2] bond: Use active-backup mode on LACP failure.

2013-11-12 Thread Ethan Jackson
Sorry it took me so long to get to this. I've merged the patch to master with some minor style tweaks. Thanks, Ethan On Mon, Nov 4, 2013 at 3:07 PM, Ravi Kondamuru wrote: > Commit bdebeece5 (lacp: Require successful LACP negotiations when > configured.) makes successful LACP negotiation mandat

Re: [ovs-dev] [PATCH 2/4] ofproto: Add enum ofp_table_config

2013-11-12 Thread Ben Pfaff
On Tue, Nov 12, 2013 at 04:45:51PM +0900, Simon Horman wrote: > Cc: Andy Zhou > Signed-off-by: Simon Horman > --- > include/openflow/openflow-common.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/openflow/openflow-common.h > b/include/openflow/openflow-common.h > in

Re: [ovs-dev] [PATCH 1/4] ofproto: Add enum ofp_table

2013-11-12 Thread Ben Pfaff
On Tue, Nov 12, 2013 at 04:45:50PM +0900, Simon Horman wrote: > Add enum ofp_table and use it for Flow Mod. > > Cc: Andy Zhou > Signed-off-by: Simon Horman Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

[ovs-dev] Processed: Re: Bug#729304: openvswitch-switch: logrotate error if directory "/var/run/openvswitch" does not exist

2013-11-12 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > tags 729304 + upstream fixed-upstream Bug #729304 [openvswitch-switch] openvswitch-switch: logrotate error if directory "/var/run/openvswitch" does not exist Added tag(s) upstream and fixed-upstream. > thanks Stopping processing here. Please con

[ovs-dev] Bug#729304: openvswitch-switch: logrotate error if directory "/var/run/openvswitch" does not exist

2013-11-12 Thread Ben Pfaff
tags 729304 + upstream fixed-upstream thanks On Tue, Nov 12, 2013 at 04:23:47PM +0100, Alfredo Finelli wrote: > Ben Pfaff [11.11.2013 19:20 +0100]: > > [...] > > Thanks a lot for the patch! I would like to apply it to the Open > > vSwitch repository. May I have a Signed-off-by: for this? e.g.: >

Re: [ovs-dev] [PATCH v2] FAQ, NEWS: Notes on TCP flags matching.

2013-11-12 Thread Ben Pfaff
On Tue, Nov 12, 2013 at 07:36:23AM -0800, Jarno Rajahalme wrote: > Add a "Performance" FAQ category. So far the only entry addresses the > issue with using a new kernel module with an older (pre-megaflows) > userspace. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff

[ovs-dev] Bug#729304: openvswitch-switch: logrotate error if directory "/var/run/openvswitch" does not exist

2013-11-12 Thread Alfredo Finelli
Ben Pfaff [11.11.2013 19:20 +0100]: > [...] > Thanks a lot for the patch! I would like to apply it to the Open > vSwitch repository. May I have a Signed-off-by: for this? e.g.: > > Signed-off-by: Alfredo Finelli > > By doing this, you are agreeing to the Developer's Certificate of > Origin (see

[ovs-dev] [PATCH v2] FAQ, NEWS: Notes on TCP flags matching.

2013-11-12 Thread Jarno Rajahalme
Add a "Performance" FAQ category. So far the only entry addresses the issue with using a new kernel module with an older (pre-megaflows) userspace. Signed-off-by: Jarno Rajahalme --- FAQ | 21 + NEWS |5 + 2 files changed, 26 insertions(+) diff --git a/FAQ b/FAQ

[ovs-dev] [PATCH 3/4] userspace: add layer 3 flow and switching support

2013-11-12 Thread Lorand Jakab
This commit relaxes the assumption that all packets have an Ethernet header, and adds support for layer 3 flows. For each packet received on the Linux kernel datapath the l2 and l3 members of struct ofpbuf are intialized appropriately, and some functions now expect this (notable flow_extract()), i

[ovs-dev] [PATCH 4/4] datapath: add layer 3 flow/port support

2013-11-12 Thread Lorand Jakab
Implementation of the pop_eth and push_eth actions in the kernel, also layer 3 flow support. Jesse Gross provided feedback on a previous version of this RFC patch, all of those comments are resolved here. Signed-off-by: Lorand Jakab --- datapath/actions.c | 32 +

[ovs-dev] [PATCH 2/4] userspace: add support for pop_eth and push_eth actions

2013-11-12 Thread Lorand Jakab
These actions will allow L2->L3 and L3->L2 switching, and are supposed to be added to flows installed in the datapath transparently by ovs-vswitchd. Signed-off-by: Lorand Jakab --- include/linux/openvswitch.h | 12 + lib/odp-execute.c | 12 + lib/odp-util.c

[ovs-dev] [PATCH 0/4] Support for layer 3 ports

2013-11-12 Thread Lorand Jakab
This series implements support for layer 3 ports, of which we have one example so far, the LISP vport. LISP support is currently implemented with a hack, by adding/removing the Ethernet header within the datapath/vport-lisp.c file. By removing the assumption that all packets/flows have Ethernet h

[ovs-dev] [PATCH 1/4] ofproto-dpif: add support for layer 3 ports

2013-11-12 Thread Lorand Jakab
Add member is_layer3 to struct ofport_dpif to mark layer 3 ports. Set it to "true" for the only layer 3 port we support for now: lisp. Additionally, prevent flooding to layer 3 ports. A later patch will also prevent MAC learning. This patch is useful and could be applied even without the rest o

Re: [ovs-dev] [PATCH 4/4] ofproto: Honour Table Mod settings for table-miss handling

2013-11-12 Thread Simon Horman
2013/11/12 17:36 "YAMAMOTO Takashi" : > > > +enum rule_dpif_lookup_verdict > > +rule_dpif_lookup_from_table(struct ofproto_dpif *ofproto, > > +const struct flow *flow, struct flow_wildcards *wc, > > +uint8_t *table_id, struct rule_dpif **rule)

Re: [ovs-dev] [PATCH v2 8/8] AT: Add tests for OFPMP_TABLE_FEATURES.

2013-11-12 Thread Alexander Wu
On 12/11/2013 11:58, YAMAMOTO Takashi wrote: + OFPTFPT13_MATCH: IN_PORT,IN_PHY_PORT,METADATA,ETH_DST,ETH_SRC,ETH_TYPE,VLAN_VID,VLAN_PCP,IP_DSCP,IP_ECN,IP_PROTO,IPV4_SRC,IPV4_DST,TCP_SRC,TCP_DST,UDP_SRC,UDP_DST,SCTP_SRC,SCTP_DST,ICMPV4_TYPE,ICMPV4_CODE,ARP_OP,ARP_SPA,ARP_TPA,ARP_SHA,ARP_THA,

Re: [ovs-dev] [PATCH 4/4] ofproto: Honour Table Mod settings for table-miss handling

2013-11-12 Thread YAMAMOTO Takashi
> +enum rule_dpif_lookup_verdict > +rule_dpif_lookup_from_table(struct ofproto_dpif *ofproto, > +const struct flow *flow, struct flow_wildcards > *wc, > +uint8_t *table_id, struct rule_dpif **rule) > +{ > +enum ofp_table_config config = O