> On Nov 12, 2013, at 8:47 AM, Ben Pfaff <b...@nicira.com> wrote:
>
>> On Tue, Nov 12, 2013 at 04:45:51PM +0900, Simon Horman wrote:
...
>> +enum ofp_table_config {
>> + OFPTC_TABLE_MISS_CONTROLLER = 0, /* Send to controller. */
>> + OFPTC_TABLE_MISS_CONTINUE = 1 << 0, /* Continue to the next table in the
>> + pipeline (OpenFlow 1.0
>> behavior). */
>> + OFPTC_TABLE_MISS_DROP = 1 << 1, /* Drop the packet. */
>> + OFPTC_TABLE_MISS_MASK = 3
>> +};
>
> I know that at least some version of the standard writes it that way but
> the constants don't make any sense in that form. 0 << 0, 1 << 0, 2 <<
> 0, 3 << 0 are a lot more sensible.
Why shift zero bits?
Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
