On 12/11/2013 11:58, YAMAMOTO Takashi wrote:
+ OFPTFPT13_MATCH:
IN_PORT,IN_PHY_PORT,METADATA,ETH_DST,ETH_SRC,ETH_TYPE,VLAN_VID,VLAN_PCP,IP_DSCP,IP_ECN,IP_PROTO,IPV4_SRC,IPV4_DST,TCP_SRC,TCP_DST,UDP_SRC,UDP_DST,SCTP_SRC,SCTP_DST,ICMPV4_TYPE,ICMPV4_CODE,ARP_OP,ARP_SPA,ARP_TPA,ARP_SHA,ARP_THA,IPV6_SRC,IPV6_DST,IPV6_FLABEL,ICMPV6_TYPE,ICMPV6_CODE,IPV6_ND_TARGET,IPV6_ND_SLL,IPV6_ND_TLL,MPLS_LABEL,MPLS_TC,MPLS_BOS,TUNNEL_ID,IPV6_EXTHDR
at least for OFPTFPT_MATCH, HASMASK bit should be dumped as well
because it has a defined meaning. (OpenFlow 1.3.2 p.83)
YAMAMOTO Takashi
Got it, I'm thinking about it and I've got 3 plans to improve the cli.
A. Print fields in bitmap.
So the oxm, actions, next_tables, etc. would be printed as bitmap.
And here shows class-field-hm-length oxm bitmap.
Advantage: Closed to OpenFlow spec.
Disadvantage: Not readable.
B. Print human-readable texts.
So this oxm fields should be showed like "basic,in_port,0,32" or
"in_port,0".
Advantage: Human-readable.
Disadvantage: Lots of texts. Most of them are useless.
C. Print SPECIAL contents only.
Print one common content and some description texts. Then print
special contents which are uncommon.
Advantage: Human-readable, much less texts.
Disadvantage: A little weird to understand.
Which one do you think is better?
And any suggestions?
Thanks!
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
