Re: [ovs-dev] [PATCH] configure: check for uuid python module

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 10:02:30PM -0700, Ansis Atteka wrote: > After introducing commit a5ae88ff8a276e86c842ac102145432662bf711a > "ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is > available" Open vSwitch did not build anymore on hosts that did not > have uuid python module install

[ovs-dev] [PATCH] configure: check for uuid python module

2013-10-17 Thread Ansis Atteka
After introducing commit a5ae88ff8a276e86c842ac102145432662bf711a "ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available" Open vSwitch did not build anymore on hosts that did not have uuid python module installed (for example, we still support XenServer that still uses old python

Re: [ovs-dev] [PATCH] Fix packet-in reason for OpenFlow1.3 table-miss flow entries

2013-10-17 Thread YAMAMOTO Takashi
> On Fri, Oct 18, 2013 at 01:41:20PM +0900, YAMAMOTO Takashi wrote: >> >> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote: >> >>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote: >> >>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow >> >>>

Re: [ovs-dev] [PATCH] Fix packet-in reason for OpenFlow1.3 table-miss flow entries

2013-10-17 Thread Ben Pfaff
On Fri, Oct 18, 2013 at 01:41:20PM +0900, YAMAMOTO Takashi wrote: > >> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote: > >>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote: > >>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow > >>> >> ent

Re: [ovs-dev] [PATCH] Fix packet-in reason for OpenFlow1.3 table-miss flow entries

2013-10-17 Thread YAMAMOTO Takashi
>> On Thu, Oct 17, 2013 at 02:11:00PM +0900, YAMAMOTO Takashi wrote: >>> > On Wed, Oct 16, 2013 at 05:24:36PM +0900, YAMAMOTO Takashi wrote: >>> >> As per spec, make packet-in reason for OpenFlow1.3 table-miss flow >>> >> entries no_match rather than action. >>> >> >>> >> Signed-off-by: YAMAMOTO T

[ovs-dev] [PATCH] Fix packet-in reason for OpenFlow1.3 table-miss flow entries

2013-10-17 Thread YAMAMOTO Takashi
As per spec, make packet-in reason for OpenFlow1.3 table-miss flow entries no_match rather than action. Signed-off-by: YAMAMOTO Takashi --- OPENFLOW-1.1+ | 3 -- include/openflow/openflow-common.h | 5 +- lib/learn.c| 6 ++- lib/learning-switch.

[ovs-dev] RFC: Handle IPv4 fragmentation in kernel

2013-10-17 Thread Takayuki Usui
Hi All, I'm working an experimental patch to handle IPv4 fragmentation and reassembly in kernel. The goals are (1) flow matching an entire datagram, not a single fragment, and (2) Path MTU Discovery across an OVS network. I would really appriciate it if you could review it. https://github.com/tak

Re: [ovs-dev] [PATCH] socket-util: Add symlink based workaround for long pathnames.

2013-10-17 Thread Ben Pfaff
On Fri, Oct 18, 2013 at 11:31:37AM +0900, YAMAMOTO Takashi wrote: > > +/* Attempts to shorten 'name' by creating a symlink for the directory part > > of > > + * the name and indirecting through /. This works on > > + * systems that support symlinks, as long as isn't too long. > > + * > > + * On

Re: [ovs-dev] xenserver build failures

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 07:41:31PM -0700, Ansis Atteka wrote: > On Thu, Oct 17, 2013 at 6:19 PM, Ansis Atteka wrote: > > On Thu, Oct 17, 2013 at 3:21 PM, Ben Pfaff wrote: > >> Builds for xenserver are failing now because xenserver doesn't have the > >> uuid.py module (it uses a too-old python): >

Re: [ovs-dev] [PATCH] xenserver: Add VTEP packaging.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 07:46:01PM -0700, Justin Pettit wrote: > Add VTEP files so XenServer build doesn't fail. > > Signed-off-by: Justin Pettit Do we really want to install these files on XenServer? If so, then this is the right patch; if not, then we should delete them instead of letting the

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Add an item to improve action translation.

2013-10-17 Thread Ben Pfaff
OK, applied for now, thanks. On Thu, Oct 17, 2013 at 05:19:56PM -0700, Jarno Rajahalme wrote: > Looks good, > > And I'm working on it, you could apply this in the meanwhile if you want. > > Jarno > > > On Oct 17, 2013, at 4:51 PM, Ben Pfaff wrote: > > > > Jarno, you've been looking at this

[ovs-dev] vlan tag add/remove affect bandwidth a lot

2013-10-17 Thread Li, Chen
Hi list, We're working under Openvswitch + Openstack, the kernel is 2.6.32-358.114.1.openstack.el6.x86_64, and OVS is openvswitch.x86_64 1.10.0-1.el6. We tested the bandwidth between the virtual machine (host 1) and a physical machine (host 2). (The link between host 1 and host 2 is 10 G

Re: [ovs-dev] [PATCH] rhel: Add VTEP packaging.

2013-10-17 Thread Justin Pettit
Thanks. I pushed both the XenServer and RHEL changes. --Justin On Oct 17, 2013, at 7:51 PM, Ansis Atteka wrote: > Looks good to me. > > On Thu, Oct 17, 2013 at 7:42 PM, Justin Pettit wrote: >> Add VTEP files so RHEL build doesn't fail. >> >> Bug #20487 >> >> Signed-off-by: Justin Pettit

Re: [ovs-dev] [PATCH] xenserver: Add VTEP packaging.

2013-10-17 Thread Ansis Atteka
Looks good to me. On Thu, Oct 17, 2013 at 7:46 PM, Justin Pettit wrote: > Add VTEP files so XenServer build doesn't fail. > > Signed-off-by: Justin Pettit > --- > xenserver/openvswitch-xen.spec.in |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/xenserver/openvs

Re: [ovs-dev] [PATCH] rhel: Add VTEP packaging.

2013-10-17 Thread Ansis Atteka
Looks good to me. On Thu, Oct 17, 2013 at 7:42 PM, Justin Pettit wrote: > Add VTEP files so RHEL build doesn't fail. > > Bug #20487 > > Signed-off-by: Justin Pettit > --- > rhel/openvswitch.spec.in |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/rhel/openvswitc

[ovs-dev] [PATCH] xenserver: Add VTEP packaging.

2013-10-17 Thread Justin Pettit
Add VTEP files so XenServer build doesn't fail. Signed-off-by: Justin Pettit --- xenserver/openvswitch-xen.spec.in |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/xenserver/openvswitch-xen.spec.in b/xenserver/openvswitch-xen.spec.in index 87efd88..e9c2d16 100644 ---

[ovs-dev] [PATCH] rhel: Add VTEP packaging.

2013-10-17 Thread Justin Pettit
Add VTEP files so RHEL build doesn't fail. Bug #20487 Signed-off-by: Justin Pettit --- rhel/openvswitch.spec.in |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index f77cd3a..3faf463 100644 --- a/rhel/openvswitch.s

Re: [ovs-dev] xenserver build failures

2013-10-17 Thread Ansis Atteka
On Thu, Oct 17, 2013 at 6:19 PM, Ansis Atteka wrote: > On Thu, Oct 17, 2013 at 3:21 PM, Ben Pfaff wrote: >> Builds for xenserver are failing now because xenserver doesn't have the >> uuid.py module (it uses a too-old python): >> >>File "./ovsdb/ovsdb-doc", line 12, in ? >> import

Re: [ovs-dev] [PATCH] socket-util: Add symlink based workaround for long pathnames.

2013-10-17 Thread YAMAMOTO Takashi
> +/* Attempts to shorten 'name' by creating a symlink for the directory part of > + * the name and indirecting through /. This works on > + * systems that support symlinks, as long as isn't too long. > + * > + * On success, returns 0 and stores the short name in 'short_name' and the > + * symbol

Re: [ovs-dev] xenserver build failures

2013-10-17 Thread Ansis Atteka
On Thu, Oct 17, 2013 at 3:21 PM, Ben Pfaff wrote: > Builds for xenserver are failing now because xenserver doesn't have the > uuid.py module (it uses a too-old python): > >File "./ovsdb/ovsdb-doc", line 12, in ? > import ovs.db.schema >File > "/usr/src/redhat/BUILD/openvs

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Add an item to improve action translation.

2013-10-17 Thread Jarno Rajahalme
Looks good, And I'm working on it, you could apply this in the meanwhile if you want. Jarno > On Oct 17, 2013, at 4:51 PM, Ben Pfaff wrote: > > Jarno, you've been looking at this issue, perhaps you should review > this? > >> On Wed, Sep 11, 2013 at 09:31:49AM -0700, Ben Pfaff wrote: >> Repo

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: Add an item to improve action translation.

2013-10-17 Thread Ben Pfaff
Jarno, you've been looking at this issue, perhaps you should review this? On Wed, Sep 11, 2013 at 09:31:49AM -0700, Ben Pfaff wrote: > Reported-by: Torbjorn Tornkvist > Signed-off-by: Ben Pfaff > --- > OPENFLOW-1.1+ |5 + > 1 file changed, 5 insertions(+) > > diff --git a/OPENFLOW-1.1+

Re: [ovs-dev] [mega mask stats v2 1/2] datapath: collect mega flow mask stats

2013-10-17 Thread Jesse Gross
On Thu, Oct 17, 2013 at 3:12 PM, Andy Zhou wrote: > Collect mega flow mask stats. ovs-dpctl show command can be used to > display them. > > Signed-off-by: Andy Zhou Sorry, I noticed a couple other things this time around, one important and a couple minor. > diff --git a/datapath/datapath.c b/da

Re: [ovs-dev] [PATCH 1/2] flow: Fill in ->l7 in flow_compose().

2013-10-17 Thread Alex Wang
This makes sense, thanks. This patch looks good to me, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] flow: Fill in ->l7 in flow_compose().

2013-10-17 Thread Ben Pfaff
More specifically, this code in bfd_process_packet() sees p->l7 == NULL and does pointer arithmetic on NULL, which seems bad: msg = ofpbuf_at(p, (uint8_t *)p->l7 - (uint8_t *)p->data, BFD_PACKET_LEN); On Wed, Oct 16, 2013 at 02:20:15PM -0700, Alex Wang wrote: > Have a question, > > function

Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel structures (for GRE, VXLAN etc.)

2013-10-17 Thread Jesse Gross
Romain, would you mind continuing this conversation with Neil given that you seem to have similar concerns but much more context in this area than I? On Wed, Oct 9, 2013 at 12:33 PM, Neil Mckee wrote: > > On Oct 8, 2013, at 7:38 PM, Jesse Gross wrote: > >> I don't think that it's necessarily a g

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 03:32:03PM -0700, Jarno Rajahalme wrote: > > On Oct 17, 2013, at 12:37 PM, Ben Pfaff wrote: > > > On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: > >> This is a little bit simpler and marginally more efficient, but also makes > >> following changes easier

Re: [ovs-dev] [PATCH 7/9] ofp-actions: Set field OF 1.0/1.1 compatibility.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:48 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:09PM -0700, Jarno Rajahalme wrote: >> Output set field actions as standard OF1.0/1.1 set actions whenever possible. >> >> Signed-off-by: Jarno Rajahalme > > I think this is a reasonable idea--I considered something

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:44 PM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 12:37:27PM -0700, Ben Pfaff wrote: >> On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: >>> This is a little bit simpler and marginally more efficient, but also makes >>> following changes easier. >>> >>> Si

[ovs-dev] [PATCH] nicira-ext: Update comment.

2013-10-17 Thread Ben Pfaff
The ARP headers have been acceptable as NXAST_REG_MOVE destinations since commit f6c8a6b163 (Add software switch support for modifying ARP headers in OpenFlow.) Reported-by: Anupam Chanda Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h |5 + 1 file changed, 5 insertions(+) d

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:37 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: >> This is a little bit simpler and marginally more efficient, but also makes >> following changes easier. >> >> Signed-off-by: Jarno Rajahalme > > I had to read the patch before

Re: [ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 03:12:02PM -0700, Jarno Rajahalme wrote: > > On Oct 17, 2013, at 12:40 PM, Ben Pfaff wrote: > > > On Wed, Oct 16, 2013 at 04:16:08PM -0700, Jarno Rajahalme wrote: > >> Signed-off-by: Jarno Rajahalme > > > > Why is saving space here worthwhile? > > The difference in set

[ovs-dev] xenserver build failures

2013-10-17 Thread Ben Pfaff
Builds for xenserver are failing now because xenserver doesn't have the uuid.py module (it uses a too-old python): File "./ovsdb/ovsdb-doc", line 12, in ? import ovs.db.schema File "/usr/src/redhat/BUILD/openvswitch-2.0.90.30095/python/ovs/db/schema.py", line 20, in ?

[ovs-dev] [mega mask stats v2 2/2] dpif-linux: collect and display mega flow mask stats

2013-10-17 Thread Andy Zhou
Signed-off-by: Andy Zhou v1-v2: * format fixes * added contents to ovs-dpctl man page * allow mask count to be zero. --- NEWS |2 ++ lib/dpif-linux.c | 18 +- lib/dpif-netdev.c|2 ++ lib/dpif.h

[ovs-dev] [mega mask stats v2 1/2] datapath: collect mega flow mask stats

2013-10-17 Thread Andy Zhou
Collect mega flow mask stats. ovs-dpctl show command can be used to display them. Signed-off-by: Andy Zhou --- v1-v2: * remove get_dp_megaflow_stats(), extend get_dp_stats() instead * use __always_unused instead of GCC extensions * fix comments * fix the logic of

Re: [ovs-dev] [PATCH v4] More accurate wildcarding and fragment handling.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 02:28:20PM -0700, Jarno Rajahalme wrote: > This patch gets rid of the need for having explicit padding in struct > flow as new fields are being added. flow_wildcards_init_exact(), which > used to set bits in both compiler generated and explicit padding, is > removed. match

Re: [ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:40 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:08PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Why is saving space here worthwhile? The difference in setting an IPv4 address, any register, port number, etc., is 8 bytes vs. 24 bytes (i.

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 11:47 AM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > This raises an issue that I had resolved one way, and you resolved > another (even if you did not realize it). I am not certain that I chose

Re: [ovs-dev] [PATCHv2] vtep: Initial checkin of vtep schema.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 02:57:16PM -0700, Justin Pettit wrote: > From: Bruce Davie > > The hardware VTEP OVSDB schema specifies relations that a VTEP can use > to integrate physical ports into logical switches maintained by a > network virtualization controller such as NVP. > > Co-authored-by: B

Re: [ovs-dev] [PATCH] vswitchd: Use vswitch-specific variable name in automake.mk.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 03:01:46PM -0700, Justin Pettit wrote: > The variable OVSDB_DOT_DIAGRAM_ARG is describing the vswitch dot file, > so use the name VSWITCH_DOT_DIAGRAM_ARG to prevent confusion in the > generated makefile. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 02:59:07PM -0700, Jarno Rajahalme wrote: > > On Oct 17, 2013, at 11:47 AM, Ben Pfaff wrote: > > > On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: > >> Signed-off-by: Jarno Rajahalme > > > > This raises an issue that I had resolved one way, and you resol

[ovs-dev] [PATCH] vswitchd: Use vswitch-specific variable name in automake.mk.

2013-10-17 Thread Justin Pettit
The variable OVSDB_DOT_DIAGRAM_ARG is describing the vswitch dot file, so use the name VSWITCH_DOT_DIAGRAM_ARG to prevent confusion in the generated makefile. Signed-off-by: Justin Pettit --- vswitchd/automake.mk |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vswitch

[ovs-dev] [PATCHv2] vtep: Initial checkin of vtep schema.

2013-10-17 Thread Justin Pettit
From: Bruce Davie The hardware VTEP OVSDB schema specifies relations that a VTEP can use to integrate physical ports into logical switches maintained by a network virtualization controller such as NVP. Co-authored-by: Ben Pfaff Co-authored-by: Kenneth Duda Co-authored-by: Justin Pettit Signed

Re: [ovs-dev] [PATCH 2/5] vtep: Initial checkin of vtep schema.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 02:36:45PM -0700, Justin Pettit wrote: > > On Oct 17, 2013, at 9:15 AM, Ben Pfaff wrote: > > > On Fri, Oct 11, 2013 at 04:56:23PM -0700, Justin Pettit wrote: > >> From: Bruce Davie > >> > >> The hardware VTEP OVSDB schema specifies relations that a VTEP can use > >> to

Re: [ovs-dev] [PATCHv4] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-17 Thread Ansis Atteka
"make distcheck" passed. Thanks for review. I pushed this to master branch. On Thu, Oct 17, 2013 at 9:16 AM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 11:33:50AM -0700, Ansis Atteka wrote: >> These are auto-generated files, so it would be better not to keep them >> inside Open vSwitch repositor

Re: [ovs-dev] [PATCH 2/9] Fix ovs-ofctl documentation.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 10:10 AM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:04PM -0700, Jarno Rajahalme wrote: >> Make it clear that match fields are rejected when their prerequisities >> are not met, rather than just having their values ignored. > > What do mean when you say they're rejecte

Re: [ovs-dev] [PATCH 2/5] vtep: Initial checkin of vtep schema.

2013-10-17 Thread Justin Pettit
On Oct 17, 2013, at 9:15 AM, Ben Pfaff wrote: > On Fri, Oct 11, 2013 at 04:56:23PM -0700, Justin Pettit wrote: >> From: Bruce Davie >> >> The hardware VTEP OVSDB schema specifies relations that a VTEP can use >> to integrate physical ports into logical switches maintained by a >> network virtu

Re: [ovs-dev] [PATCH] lib/flow: Always zero init before use.

2013-10-17 Thread Jarno Rajahalme
On Oct 11, 2013, at 4:45 PM, Ben Pfaff wrote: > > I mean that Justin says it isn't necessary to match on everything, so > that we could easily get rid of the call to > flow_wildcards_init_exact(). This turned out to be a bit more work than I expected. I just sent a new patch ("[PATCH v4] More

[ovs-dev] [PATCH v4] More accurate wildcarding and fragment handling.

2013-10-17 Thread Jarno Rajahalme
This patch gets rid of the need for having explicit padding in struct flow as new fields are being added. flow_wildcards_init_exact(), which used to set bits in both compiler generated and explicit padding, is removed. match_wc_init() is now used instead, which generates the mask based on a given

Re: [ovs-dev] [PATCH] Handling code for queue get config request. This was done as part of a hackathon and hence is not yet fully tested. Sending it for basic review and this change set needs to be te

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 09:35:27AM -0700, Ben Pfaff wrote: > From: Venkitachalam Gopalakrishnan Thanks gops. I'm spending a little bit of time working on this. I'll probably post a new version tomorrow or Monday. ___ dev mailing list dev@openvswitch.o

[ovs-dev] [RFC 0/4] Show megaflow fields for each resubmit in ofproto/trace.

2013-10-17 Thread Alex Wang
This series of patches makes the ofproto/trace show the megaflow fields for each resubmit. An exmaple is given below: Setup: ovs-vsctl add-br br0 ovs-vsctl add-port br0 p1 -- set Interface p1 ofport_request=1 ovs-ofctl add-flow br0 "table=0, dl_src=01:00:00:00:00:00/01:00:00:00:00:00, actions=d

Re: [ovs-dev] [RFC 0/4] Show megaflow fields for each resubmit in ofproto/trace.

2013-10-17 Thread Alex Wang
Hey Ethan and Justin, Could you review this series of patches when you are available? Especially, if the output format in the example above makes sense? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [RFC 4/4] ofproto/trace: Show megaflow fields in each resubmit.

2013-10-17 Thread Alex Wang
This commit makes the ofproto/trace show the megaflow fields for each resubmit. Signed-off-by: Alex Wang --- ofproto/ofproto-dpif-upcall.c |5 +++-- ofproto/ofproto-dpif-xlate.c | 10 -- ofproto/ofproto-dpif-xlate.h |7 ++- ofproto/ofproto-dpif.c| 32 +++

[ovs-dev] [RFC 1/4] ofproto/trace: Use final flow to compute "Relevant fields".

2013-10-17 Thread Alex Wang
Commit bcd2633a (ofproto-dpif: Store relevant fields for wildcarding in facet.) introduced the bug that uses original input flow as final flow to compute the "Relevant fields" in ofproto/trace ouput. This commit fixes this bug. Signed-off-by: Alex Wang --- ofproto/ofproto-dpif.c |2 +- 1 fi

[ovs-dev] [RFC 3/4] ofproto/trace: Change output field name.

2013-10-17 Thread Alex Wang
This commit changes the output field name from "Relevant fields" to "Megaflow". Signed-off-by: Alex Wang --- ofproto/ofproto-dpif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index c1347ef..e01cdbb 100644 --- a/ofproto/o

[ovs-dev] [RFC 2/4] ofproto/trace: Remove the unused variables.

2013-10-17 Thread Alex Wang
This commit removes the unused variables in ofproto_trace() function. Signed-off-by: Alex Wang --- ofproto/ofproto-dpif.c |4 1 file changed, 4 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 5dc4ac0..c1347ef 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofp

Re: [ovs-dev] [PATCH 1/5] ovsdb-dot: Include arrows by default.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 01:47:43PM -0700, Justin Pettit wrote: > On Oct 11, 2013, at 5:00 PM, Ben Pfaff wrote: > > > On Fri, Oct 11, 2013 at 04:56:22PM -0700, Justin Pettit wrote: > >> From: Ben Pfaff > >> > >> When ovsdb-dot generates diagrams for use in the manpages, the dot2pic > >> postproc

Re: [ovs-dev] [PATCH 1/5] ovsdb-dot: Include arrows by default.

2013-10-17 Thread Justin Pettit
On Oct 11, 2013, at 5:00 PM, Ben Pfaff wrote: > On Fri, Oct 11, 2013 at 04:56:22PM -0700, Justin Pettit wrote: >> From: Ben Pfaff >> >> When ovsdb-dot generates diagrams for use in the manpages, the dot2pic >> postprocessor makes nicer output if the arrowheads are omitted (dot2pic >> adds the a

Re: [ovs-dev] [PATCH 3/5] vtep: Add vtep-ctl command.

2013-10-17 Thread Justin Pettit
On Oct 17, 2013, at 9:19 AM, Ben Pfaff wrote: > On Fri, Oct 11, 2013 at 04:56:24PM -0700, Justin Pettit wrote: >> The vtep-ctl command provides a user interface to manipulate the VTEP >> OVSDB schema. >> >> Signed-off-by: Justin Pettit > > A lot of code here is cut-and-paste from ovs-vsctl.c.

Re: [ovs-dev] [PATCH 8/9] ofp-actions: Output deprecated set actions as set field's on OF 1.2+.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:10PM -0700, Jarno Rajahalme wrote: > ofpacts_check() now stores the nw_proto field from flow to port number > set actions, so that we later remember which protocol they relate to. > This is needed for an accurate tranlation to OF 1.2+ set field action. > > Simplify so

Re: [ovs-dev] [PATCH 0/9] Native OpenFlow 1.2 set field support.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:02PM -0700, Jarno Rajahalme wrote: > This series avoids using the deprecated field setting actions on OF 1.2+, > and logs a warning when they are received over OF 1.2+. Thanks, I like this series, it should be very helpful for compatibility. __

Re: [ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:08PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Why is saving space here worthwhile? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 7/9] ofp-actions: Set field OF 1.0/1.1 compatibility.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:09PM -0700, Jarno Rajahalme wrote: > Output set field actions as standard OF1.0/1.1 set actions whenever possible. > > Signed-off-by: Jarno Rajahalme I think this is a reasonable idea--I considered something similar when I initially wrote ofp-actions.c--but I think

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 12:37:27PM -0700, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: > > This is a little bit simpler and marginally more efficient, but also makes > > following changes easier. > > > > Signed-off-by: Jarno Rajahalme > > I had to read the

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: > This is a little bit simpler and marginally more efficient, but also makes > following changes easier. > > Signed-off-by: Jarno Rajahalme I had to read the patch before I understood what it did. Could you elaborate the change lo

Re: [ovs-dev] [PATCH 4/9] Add OF11 SET IP TTL action.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:06PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Same philosophical decision as for ECN here, I'll review this once we've resolved that issue. ___ dev mailing list dev@openvswitch.org http://openvswitch.o

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme This raises an issue that I had resolved one way, and you resolved another (even if you did not realize it). I am not certain that I chose the right way, so let me present the issue for discussion.

Re: [ovs-dev] [PATCH 2/9] Fix ovs-ofctl documentation.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:04PM -0700, Jarno Rajahalme wrote: > Make it clear that match fields are rejected when their prerequisities > are not met, rather than just having their values ignored. What do mean when you say they're rejected? Certainly OVS will reject a NXM or OXM that matches on

Re: [ovs-dev] [PATCH 3/3] nx-match: fix comments

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 05:26:19PM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi All applied, thank you! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] socket-util: try to deal with long path using a temporary symlink

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 01:44:37PM +0900, YAMAMOTO Takashi wrote: > the existing procfs stuff is not always usable. > stop skipping some relevant tests even if procfs is not available. > > Signed-off-by: YAMAMOTO Takashi I felt that this code could use some cleanup and refactoring, so I more or

[ovs-dev] [PATCH] socket-util: Add symlink based workaround for long pathnames.

2013-10-17 Thread Ben Pfaff
From: YAMAMOTO Takashi The existing /proc workaround only works on Linux. Symlinks are more widely available. Signed-off-by: YAMAMOTO Takashi Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- lib/socket-util.c | 213 +++-- python/ovs/soc

Re: [ovs-dev] [PATCH v2] ovs-dpctl: Add a 'filter' option to match wildcarded 'dump-flows'.

2013-10-17 Thread Gurucharan Shetty
On Thu, Oct 17, 2013 at 8:42 AM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 08:04:10AM -0700, Gurucharan Shetty wrote: >> With mega-flows, many flows in the kernel datapath are wildcarded. >> For someone that is debugging a system and wants to find a particular >> flow and its actions, it is a lit

[ovs-dev] [PATCH] Handling code for queue get config request. This was done as part of a hackathon and hence is not yet fully tested. Sending it for basic review and this change set needs to be tested

2013-10-17 Thread Ben Pfaff
From: Venkitachalam Gopalakrishnan --- lib/ofp-util.c| 32 ++ lib/ofp-util.h|5 ofproto/ofproto.c | 73 - utilities/ovs-ofctl.c | 42 4 files changed, 151 insertion

Re: [ovs-dev] [PATCH 5/5] vtep: Add Debian packaging.

2013-10-17 Thread Ben Pfaff
On Fri, Oct 11, 2013 at 04:56:26PM -0700, Justin Pettit wrote: > Co-authored-by: David Yang > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 4/5] vtep: Initial checkin of ovs-vtep.

2013-10-17 Thread Ben Pfaff
On Fri, Oct 11, 2013 at 04:56:25PM -0700, Justin Pettit wrote: > ovs-vtep is a VTEP emulator that uses Open vSwitch for forwarding. > > Co-authored-by: Gurucharan Shetty > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@open

Re: [ovs-dev] [PATCH 3/5] vtep: Add vtep-ctl command.

2013-10-17 Thread Ben Pfaff
On Fri, Oct 11, 2013 at 04:56:24PM -0700, Justin Pettit wrote: > The vtep-ctl command provides a user interface to manipulate the VTEP > OVSDB schema. > > Signed-off-by: Justin Pettit A lot of code here is cut-and-paste from ovs-vsctl.c. I'd like to reduce the duplication in the medium term. A

Re: [ovs-dev] [PATCHv4] ovsdb-doc: generate vswitch.[pic|gv] files only if dot tool is available

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 11:33:50AM -0700, Ansis Atteka wrote: > These are auto-generated files, so it would be better not to keep them > inside Open vSwitch repository. > > Behaviour before this patch was that if dot tool was not present on > the system, then ovs-vswitchd.conf.db.5 would have used

Re: [ovs-dev] [PATCH 2/5] vtep: Initial checkin of vtep schema.

2013-10-17 Thread Ben Pfaff
On Fri, Oct 11, 2013 at 04:56:23PM -0700, Justin Pettit wrote: > From: Bruce Davie > > The hardware VTEP OVSDB schema specifies relations that a VTEP can use > to integrate physical ports into logical switches maintained by a > network virtualization controller such as NVP. > > Co-authored-by: B

Re: [ovs-dev] [PATCH 2/2] ofproto/trace: Show "Relevant fields" of each resubmit.

2013-10-17 Thread Alex Wang
This patch is not valid, I and Ethan discussed offline that there is more modification to do. I'll remove this patch from patchwork as well. The PATCH 1/2 of this series is still valid. On Wed, Oct 16, 2013 at 5:32 PM, Alex Wang wrote: > This commit makes the ofproto/dpif command show the "R

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif: Use final flow to compute "Relevant fields".

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 05:32:21PM -0700, Alex Wang wrote: > Commit bcd2633a (ofproto-dpif: Store relevant fields for wildcarding > in facet.) introduced the bug that uses original input flow as final > flow to compute the "Relevant fields" in ofproto/trace ouput. This > commit fixes this bug. >

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 11:44:57AM +0300, Lori Jakab wrote: > FAIL: detailed_contr_sw_messages.DeleteEmerFlow > FAIL: message_types.QueueConfigReply Without looking at the tests, I guess that these are probably both genuine failures. OVS has never implemented the emergency flow cache, and likely

Re: [ovs-dev] [PATCH] fix some ofpbuf usage problems in write-actions code

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 07:01:55PM +0900, YAMAMOTO Takashi wrote: > for longer term, "nested" variants of some ofpact functions > which using ofpbuf->l3 might be desirable. > > Signed-off-by: YAMAMOTO Takashi Thanks! I divided this into two commits because it fixed a different bug in each place

Re: [ovs-dev] [PATCH] ovs-dpctl: Add a 'filter' option to match wildcarded 'dump-flows'.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 08:04:13AM -0700, Gurucharan Shetty wrote: > Okay. I think only the MFF_DL_VLAN is the problem. > I sent a v2 with a wrapper. I am not sure whether the name of the > wrapper function > could be better. Thanks! I think the wrapper function name is OK for now. __

Re: [ovs-dev] [PATCH] vswitch.ovsschema: A new column, 'kmod_version' in Open_vSwitch table.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 08:16:21AM -0700, Gurucharan Shetty wrote: > Do you feel it makes sense to set this as part of the system-version field? > ex: If the system_version currently says: > system_version : "12.04-precise" > We will add additional information to it that also included the kern

Re: [ovs-dev] [PATCH v2] ovs-dpctl: Add a 'filter' option to match wildcarded 'dump-flows'.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 08:04:10AM -0700, Gurucharan Shetty wrote: > With mega-flows, many flows in the kernel datapath are wildcarded. > For someone that is debugging a system and wants to find a particular > flow and its actions, it is a little hard to zero-in on the flow > because some fields ar

Re: [ovs-dev] [PATCH] vswitch.ovsschema: A new column, 'kmod_version' in Open_vSwitch table.

2013-10-17 Thread Gurucharan Shetty
On Wed, Oct 16, 2013 at 4:07 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 01:55:41PM -0700, Gurucharan Shetty wrote: >> The new column 'kmod_version' will be used by ovs-ctl to set the >> kernel module version that ovs-vswitchd will be interacting with. >> This column can be quite useful for rem

[ovs-dev] [PATCH v2] ovs-dpctl: Add a 'filter' option to match wildcarded 'dump-flows'.

2013-10-17 Thread Gurucharan Shetty
With mega-flows, many flows in the kernel datapath are wildcarded. For someone that is debugging a system and wants to find a particular flow and its actions, it is a little hard to zero-in on the flow because some fields are wildcarded. With the filter='$filter' option, we can now filter on the o

Re: [ovs-dev] [PATCH] ovs-dpctl: Add a 'filter' option to match wildcarded 'dump-flows'.

2013-10-17 Thread Gurucharan Shetty
On Wed, Oct 16, 2013 at 3:57 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 11:22:31AM -0700, Gurucharan Shetty wrote: >> On Tue, Oct 15, 2013 at 5:01 PM, Ben Pfaff wrote: >> > On Mon, Oct 14, 2013 at 08:55:35AM -0700, Gurucharan Shetty wrote: >> >> With mega-flows, many flows in the kernel datap

[ovs-dev] [PATCH] fix some ofpbuf usage problems in write-actions code

2013-10-17 Thread YAMAMOTO Takashi
for longer term, "nested" variants of some ofpact functions which using ofpbuf->l3 might be desirable. Signed-off-by: YAMAMOTO Takashi --- lib/ofp-actions.c | 5 - lib/ofp-parse.c | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c

Re: [ovs-dev] [PATCH] netdev-dummy: Count rx packets regardless of source

2013-10-17 Thread Lori Jakab
On 10/17/13 3:23 AM, Simon Horman wrote: On Wed, Oct 16, 2013 at 02:32:55PM +0300, Lori Jakab wrote: On 10/16/13 1:17 PM, Simon Horman wrote: This alters the way rx packets are accounted for by counting them when they are processed by netdev_dummy_rx_recv(), which seems to be a common path used