On Tue, Apr 23, 2013 at 12:58 AM, Simon Horman wrote:
> On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalme, Jarno (NSN - FI/Espoo)
> wrote:
>>
>> On Apr 23, 2013, at 4:51 , ext Simon Horman wrote:
>>
>> > On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN -
>> > FI/Espoo) wrote:
>>
On Mon, Apr 22, 2013 at 7:19 PM, Simon Horman wrote:
> In the case where a non-MPLS GSO skb becomes an MPLS GSO skb, via
> Open vSwitch's push MPLS action it is desirable to provide segmentation
> in software. In this case the original protocol of the skb may have allowed
> its checksumming to be
On Tue, Apr 23, 2013 at 3:28 PM, Thomas Graf wrote:
> On 04/23/2013 10:39 PM, Jesse Gross wrote:
>>
>> On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote:
>>>
>>> diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
>>> index f8948fa..c0e3c02 100644
>>> --- a/datapath/vport-netdev.c
>>>
On 04/23/2013 10:39 PM, Jesse Gross wrote:
On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote:
diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
index f8948fa..c0e3c02 100644
--- a/datapath/vport-netdev.c
+++ b/datapath/vport-netdev.c
@@ -153,10 +161,16 @@ static struct vport *netd
On 04/24/2013 12:06 AM, Jesse Gross wrote:
OK, thanks.
I was about to apply this but it adds a new warning (on a non-RHEL platform):
/home/jgross/openvswitch/datapath/linux/netdevice.c:5:13: warning:
‘can_checksum_protocol’ defined but not used [-Wunused-function]
This happens since the code in
Looks good.
--Justin
On Apr 23, 2013, at 11:07 AM, Ben Pfaff wrote:
> Other code in the tree uses HAVE_BACKTRACE and then blindly includes
> if it is present, so this doesn't make anything worse.
>
> Once we do that, HAVE_EXECINFO_H has no further users, so this commit also
> removes the che
On Tue, Apr 23, 2013 at 2:27 PM, Thomas Graf wrote:
> On 04/23/2013 10:42 PM, Jesse Gross wrote:
>>
>> On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote:
>>>
>>> diff --git a/datapath/linux/compat/include/asm/percpu.h
>>> b/datapath/linux/compat/include/asm/percpu.h
>>> index 404b937..65bce08 10
On 04/23/2013 10:42 PM, Jesse Gross wrote:
On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote:
diff --git a/datapath/linux/compat/include/asm/percpu.h
b/datapath/linux/compat/include/asm/percpu.h
index 404b937..65bce08 100644
--- a/datapath/linux/compat/include/asm/percpu.h
+++ b/datapath/linu
On Apr 23, 2013, at 9:30 AM, Ben Pfaff wrote:
> + If you still want to connect two bridges, you can use a pair of
> + patch ports. The follow example creates bridges br0 and br1, adds
s/follow/following/
Otherwise, looks good to me.
--Justin
_
On Mon, 22 Apr 2013, Simon Horman wrote:
> "net: Add support for hardware-offloaded encapsulation" introduced
> the encapsulation field of struct skb, which when set provides hints
> that GSO should handle an skb that encapsulates a packet.
>
> This patch adds an encapsulation_features field wh
On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote:
> diff --git a/datapath/linux/compat/include/asm/percpu.h
> b/datapath/linux/compat/include/asm/percpu.h
> index 404b937..65bce08 100644
> --- a/datapath/linux/compat/include/asm/percpu.h
> +++ b/datapath/linux/compat/include/asm/percpu.h
> @@ -
On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf wrote:
> diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
> index f8948fa..c0e3c02 100644
> --- a/datapath/vport-netdev.c
> +++ b/datapath/vport-netdev.c
> @@ -153,10 +161,16 @@ static struct vport *netdev_create(const struct
> vport_parm
On Apr 23, 2013, at 11:30 AM, Ben Pfaff wrote:
> I keep seeing this question.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben, very succinct explanation.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Other code in the tree uses HAVE_BACKTRACE and then blindly includes
if it is present, so this doesn't make anything worse.
Once we do that, HAVE_EXECINFO_H has no further users, so this commit also
removes the check for
Reported-by: YAMAMOTO Takashi
Signed-off-by: Ben Pfaff
---
configure.ac
On Tue, Apr 23, 2013 at 09:34:13AM -0700, Ben Pfaff wrote:
> On Tue, Apr 23, 2013 at 01:30:22AM +, YAMAMOTO Takashi wrote:
> > hi,
> >
> > > On Mon, Apr 22, 2013 at 10:20:00PM +0900, YAMAMOTO Takashi wrote:
> > >> execinfo for NetBSD and ubacktrace for uClibc.
> > >> i don't know if the latter
OVS locking was recently changed to have private OVS lock which
simplified overall locking. Therefore there is no need to have
another global genl lock to protect OVS data structures. Following
patch uses of parallel_ops genl family for OVS. This also allows
more granual OVS locking using ovs_mu
All genl callbacks are serialized by genl-mutex. This can become
bottleneck in multi threaded case.
Following patch adds an parameter to genl_family so that a
particular family can get concurrent netlink callback without
genl_lock held.
New rw-sem is used to protect genl callback from genl family u
On Tue, Apr 23, 2013 at 01:56:17AM +, pengyi Peng(Yi) wrote:
> I find that when ovs-vswitchd memory is abnormally growing, backlog
> in struct rpc is growing fast too. Almost every time in jsonrpc_run,
> stream_send returns -EAGAIN, the msg holds and waits next time to
> send. The backlog pluse
On Tue, Apr 23, 2013 at 10:09 AM, christopher barry wrote:
> This thread discusses correct configuration on debian. It seems to have
> basically trailed off. I would like the correct method to create bridges
> out of my interfaces, and have them automagically startup when the box
> is rebooted. Su
I posted a fix. Please review it:
http://openvswitch.org/pipermail/dev/2013-April/026864.html
On Mon, Apr 22, 2013 at 05:13:28PM -0700, Ben Pfaff wrote:
> I think I see the problem. It is subtle. I'll write up a fix
> tomorrow morning.
>
> On Mon, Apr 22, 2013 at 08:45:52PM +0100, Zolt
In the case where execute_controller_action() returned true to
handle_flow_miss(), indicating that the packet had been sent to the
controller, nothing ever freed the packet, causing a memory leak.
One plausible solution seemed to be to turn over ownership of the packet to
execute_controller_action
This thread discusses correct configuration on debian. It seems to have
basically trailed off. I would like the correct method to create bridges
out of my interfaces, and have them automagically startup when the box
is rebooted. Surprisingly, the answer is still elusive.
http://openvswitch.org/pip
On Tue, Apr 23, 2013 at 01:30:22AM +, YAMAMOTO Takashi wrote:
> hi,
>
> > On Mon, Apr 22, 2013 at 10:20:00PM +0900, YAMAMOTO Takashi wrote:
> >> execinfo for NetBSD and ubacktrace for uClibc.
> >> i don't know if the latter is relevant to Open vSwitch, though.
> >>
> >> Signed-off-by: YAMAMOT
On Tue, Apr 23, 2013 at 08:57:28AM -0400, Ed Maste wrote:
> > Ed, do you want to look over any of these changes? They affect code
> > for which you are a primary author, so if you would prefer to see
> > anything done a different way, etc., for maintainability purposes then
> > it would be valuabl
I keep seeing this question.
Signed-off-by: Ben Pfaff
---
FAQ | 37 +
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/FAQ b/FAQ
index e7249cf..f8faa2f 100644
--- a/FAQ
+++ b/FAQ
@@ -325,6 +325,43 @@ A: No. ERSPAN is an undocumented proprieta
On Tue, Apr 23, 2013 at 9:06 AM, Ben Pfaff wrote:
> On Tue, Apr 23, 2013 at 08:37:40AM -0700, Gurucharan Shetty wrote:
> > Currently, when we upgrade openvswitch packages, we do a restart
> > of userspace daemons automatically. This does not replace the
> > kernel module.
> >
> > But almost every
On Tue, Apr 23, 2013 at 02:10:58PM +, Kyle Mestery (kmestery) wrote:
> On Apr 22, 2013, at 11:15 PM, Ben Pfaff wrote:
> > This question keeps coming up.
> >
> > Signed-off-by: Ben Pfaff
>
>
> Looks good to me Ben.
Thanks, applied to master.
___
On Tue, Apr 23, 2013 at 08:37:40AM -0700, Gurucharan Shetty wrote:
> Currently, when we upgrade openvswitch packages, we do a restart
> of userspace daemons automatically. This does not replace the
> kernel module.
>
> But almost everytime, we want to use the new kernel module
> that comes with th
On Mon, Apr 22, 2013 at 9:26 PM, Ben Pfaff wrote:
> On Mon, Apr 22, 2013 at 05:10:21PM -0700, Gurucharan Shetty wrote:
> > On Mon, Apr 22, 2013 at 2:19 PM, Ben Pfaff wrote:
> >
> > > On Wed, Apr 17, 2013 at 03:11:12PM -0700, Gurucharan Shetty wrote:
> > > > Currently, when we upgrade openvswitch
Currently, when we upgrade openvswitch packages, we do a restart
of userspace daemons automatically. This does not replace the
kernel module.
But almost everytime, we want to use the new kernel module
that comes with the new version. This means that we need to
manually do a "force-reload-kmod". Th
On Apr 22, 2013, at 11:15 PM, Ben Pfaff wrote:
> This question keeps coming up.
>
> Signed-off-by: Ben Pfaff
Looks good to me Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 23/04/13 12:00, Ian Campbell wrote:
> Based on Waldi's RFC at
> http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
>
> To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use
> script=vif-openvswitch in the vif configuration.
>
> Appears to do the right th
On 22 April 2013 09:20, YAMAMOTO Takashi wrote:
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ed Maste
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 22 April 2013 09:20, YAMAMOTO Takashi wrote:
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ed Maste
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 22 April 2013 09:20, YAMAMOTO Takashi wrote:
> this will be used for get_stats and set_etheraddr
>
> Signed-off-by: YAMAMOTO Takashi
> ---
> lib/netdev-bsd.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
> index ba
> Ed, do you want to look over any of these changes? They affect code
> for which you are a primary author, so if you would prefer to see
> anything done a different way, etc., for maintainability purposes then
> it would be valuable to get that in review.
Yep - I'm looking at them now. I've rev
On 22 April 2013 09:20, YAMAMOTO Takashi wrote:
> on some platforms, including NetBSD-6, openssl is available but
> its pkg-config files (*.pc) are not. according to Ed Maste,
> this is the case for FreeBSD as well.
That's correct. This should be a nice convenience for anyone building
on FreeBS
On Tue, 2013-04-23 at 10:58 +0100, Bastian Blank wrote:
> On Tue, Apr 23, 2013 at 10:42:15AM +0100, Ian Campbell wrote:
> > On Tue, 2013-04-23 at 09:56 +0100, Roger Pau Monne wrote:
> > > Also, it might be interesting to add something like:
> > > if ! type ovs-vsctl > /dev/null 2>&1; then
> > I
Based on Waldi's RFC at
http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use
script=vif-openvswitch in the vif configuration.
Appears to do the right thing for PV and HVM guests (including tap devices)
and
On Tue, Apr 23, 2013 at 10:42:15AM +0100, Ian Campbell wrote:
> On Tue, 2013-04-23 at 09:56 +0100, Roger Pau Monne wrote:
> > Also, it might be interesting to add something like:
> > if ! type ovs-vsctl > /dev/null 2>&1; then
> I think type is a bash-ism but I don't know the portable alternativ
On Tue, 2013-04-23 at 09:56 +0100, Roger Pau Monne wrote:
> Also, it might be interesting to add something like:
>
> check_tools()
> {
> if ! type ovs-vsctl > /dev/null 2>&1; then
I think type is a bash-ism but I don't know the portable alternative and
this script uses #!/bin/bash anyhow.
>
On Tue, 2013-04-23 at 09:46 +0100, Roger Pau Monne wrote:
> > +ovs-vsctl --timeout=30 -- --if-exists del-port $dev -- add-port
> > "$bridge" $dev $tag_arg $trunk_arg $vif_details
> > +ip link set $dev up
>
> Should we check the return value of this two calls, so we can print a
> nice erro
On 23/04/13 10:22, Ian Campbell wrote:
> Based on Waldi's RFC at
> http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
>
> To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use
> script=vif-openvswitch in the vif configuration.
>
> Appears to do the right th
On 23/04/13 10:22, Ian Campbell wrote:
> Based on Waldi's RFC at
> http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
>
> To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use
> script=vif-openvswitch in the vif configuration.
>
> Appears to do the right th
On Mon, 2013-04-22 at 18:20 +0100, Roger Pau Monne wrote:
> On 22/04/13 19:05, Ian Campbell wrote:
> > On Mon, 2013-04-22 at 17:46 +0100, Roger Pau Monne wrote:
> >>> +offline)
> >>
> >> Don't you need a "remove" here?
> >>
> >> remove|offline)
> >>...
> >>
> >> Or it doesn't matter because
Based on Waldi's RFC at
http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use
script=vif-openvswitch in the vif configuration.
Appears to do the right thing for PV and HVM guests (including tap devices)
and
On Tue, Apr 23, 2013 at 07:41:37AM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 23, 2013, at 4:51 , ext Simon Horman wrote:
>
> > On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN - FI/Espoo)
> > wrote:
> >>
> >> Here the skb_network_header is changed to point to th
On Apr 23, 2013, at 4:51 , ext Simon Horman wrote:
> On Mon, Apr 22, 2013 at 01:55:43PM +, Rajahalme, Jarno (NSN - FI/Espoo)
> wrote:
>>
>> Here the skb_network_header is changed to point to the L3 header. Is it
>> significant that in some cases (?) mpls_stack_depth may remain at zero,
>> e
On Apr 22, 2013, at 19:16 , ext Ben Pfaff wrote:
> On Mon, Apr 22, 2013 at 09:12:23AM -0700, Ben Pfaff wrote:
>> On Thu, Apr 18, 2013 at 06:07:41PM +0300, Jarno Rajahalme wrote:
>>> This makes sure that output actions leave no changes to any flow fields,
>>> while all explicit set_field actions ar
49 matches
Mail list logo
