Looks good. --Justin
On Apr 23, 2013, at 11:07 AM, Ben Pfaff <b...@nicira.com> wrote: > Other code in the tree uses HAVE_BACKTRACE and then blindly includes > <execinfo.h> if it is present, so this doesn't make anything worse. > > Once we do that, HAVE_EXECINFO_H has no further users, so this commit also > removes the check for <execinfo.h> > > Reported-by: YAMAMOTO Takashi <y...@mwd.biglobe.ne.jp> > Signed-off-by: Ben Pfaff <b...@nicira.com> > --- > configure.ac | 2 +- > lib/timeval.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 79fb46e..9f42941 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -61,7 +61,7 @@ OVS_CHECK_STRTOK_R > AC_CHECK_MEMBERS([struct stat.st_mtim.tv_nsec, struct stat.st_mtimensec], > [], [], [[#include <sys/stat.h>]]) > AC_CHECK_FUNCS([mlockall strnlen strsignal getloadavg statvfs setmntent]) > -AC_CHECK_HEADERS([mntent.h sys/statvfs.h linux/types.h linux/if_ether.h > execinfo.h]) > +AC_CHECK_HEADERS([mntent.h sys/statvfs.h linux/types.h linux/if_ether.h]) > > OVS_CHECK_PKIDIR > OVS_CHECK_RUNDIR > diff --git a/lib/timeval.c b/lib/timeval.c > index 6e41514..163de1e 100644 > --- a/lib/timeval.c > +++ b/lib/timeval.c > @@ -37,7 +37,7 @@ > > /* backtrace() from <execinfo.h> is really useful, but it is not signal safe > * everywhere, such as on x86-64. */ > -#if HAVE_EXECINFO_H && !defined __x86_64__ > +#if HAVE_BACKTRACE && !defined __x86_64__ > # define USE_BACKTRACE 1 > # include <execinfo.h> > #else > -- > 1.7.2.5 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
