On Tue, 2013-04-23 at 09:56 +0100, Roger Pau Monne wrote: > Also, it might be interesting to add something like: > > check_tools() > { > if ! type ovs-vsctl > /dev/null 2>&1; then
I think type is a bash-ism but I don't know the portable alternative and this script uses #!/bin/bash anyhow. > fatal "Unable to find ovs-vsctl tool" > fi > if ! type ip > /dev/null 2>&1; then > fatal "Unable to find ip tool" > fi > } > > In order to check that the needed external tools are there. Can't hurt I suppose. I made it check only in the online case, since like I said before I'd like remove to try to do as much as it can. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev