On Tue, Apr 23, 2013 at 2:27 PM, Thomas Graf <tg...@redhat.com> wrote:
> On 04/23/2013 10:42 PM, Jesse Gross wrote:
>>
>> On Fri, Apr 19, 2013 at 7:01 AM, Thomas Graf <tg...@redhat.com> wrote:
>>>
>>> diff --git a/datapath/linux/compat/include/asm/percpu.h
>>> b/datapath/linux/compat/include/asm/percpu.h
>>> index 404b937..65bce08 100644
>>> --- a/datapath/linux/compat/include/asm/percpu.h
>>> +++ b/datapath/linux/compat/include/asm/percpu.h
>>> @@ -3,7 +3,7 @@
>>>
>>>   #include_next <asm/percpu.h>
>>>
>>> -#ifndef this_cpu_ptr
>>> +#if !defined this_cpu_ptr && !defined HAVE_THIS_CPU_PTR
>>
>>
>> This one surprises me - I would expect that the check for the
>> definition should already catch any backports. Can you describe what
>> the issue is?
>
>
> The reason for that is that RHEL defines this_cpu_ptr in a different
> header file and not in asm/percpu.h. I found what I proposed to be
> the easiest workaround for that.

OK, thanks.

I was about to apply this but it adds a new warning (on a non-RHEL platform):
/home/jgross/openvswitch/datapath/linux/netdevice.c:5:13: warning:
‘can_checksum_protocol’ defined but not used [-Wunused-function]

This happens since the code in netdevice.c was previously under a
single #ifdef and now the blocks can be independently used.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to