On May 10, 2012, at 9:38 AM, Ben Pfaff wrote:
> On Wed, May 09, 2012 at 04:34:21PM -0700, Arun Sharma wrote:
>> It improves to have proper out file name in bugtool archive with respect
>> to ovs-appctl commands. E.g. if command is 'ovs-appctl lacp/show' then
>> the related out file will be 'ovs-ap
Hi Ben,
Thank you for your reply. The reason I am asking these questions is
not to question Joe's patch, but to have a better understanding of the
changes. The questions rise because of my limited knowledge of the
code, and hoping to get clarified to better work on and use the code.
As I said I a
OFPFW_* are OpenFlow 1.0 protocol constants. The FWW_* masks in struct
flow_wildcards coincide where it is convenient and not otherwise.
I don't understand why you're asking these questions. Joe is clearly on
the right track with his patches.
On Thu, May 17, 2012 at 12:58:02PM +0800, YIMIN CHEN
Hi Ben,
I am new to the code, so please pardon my questions.
Based on my current understanding of the code, the wildcard fields in
flow_wildcards is used in the rule to store the wildcard mask for
run-time match. OFPFW_DL_SRC_MASK, like OFPFW_NW_SRC_MASK, can be used
to pass the wildcard bits in
The place that Joe put it, in struct flow_wildcards.
On Thu, May 17, 2012 at 12:47:26PM +0800, YIMIN CHEN wrote:
> Hi Ben,
>
> I was following the way IP mask is passing the wildcard down to dp. We
> need several bits to represent the mac addr mask, instead of the
> current OFPFW_DL_SRC single bi
Hi Ben,
I was following the way IP mask is passing the wildcard down to dp. We
need several bits to represent the mac addr mask, instead of the
current OFPFW_DL_SRC single bit. What is your advise on the proper
place to specify the wildcard bits?
Thanks!
Yimin
On Thu, May 17, 2012 at 12:33 PM,
On Thu, May 17, 2012 at 11:08:33AM +0800, YIMIN CHEN wrote:
> 2) do we also need to change the OFPFW_DL_SRC in ofp_flow_wildcards to
> OFPFW_DL_SRC_MASK? This will move DL_TYPE by many bits, and I am
> wondering whether this is the right way to do.
No. It wouldn't make sense to do that.
_
Hi Joe,
I was looking at ways to implement mac address wildcard match and read
your patch on the ovs-dev. I have some questions regarding the changes
could you please clarify for me?
1) I see util. functions to compare the masks and code to zero the
masks. I didn't find the code using the mask to
On Wed, May 16, 2012 at 04:13:14PM -0700, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> - Use 0x prefix for ToS.
>
> --8<--cut here-->8--
>
> Signed-off-by: Pravin B Shelar
>
> Bug #8822
Looks good to me.
Fixed according to comments from Jesse.
v1-v2:
- calculate ToS for packet after route lookup.
- use RT_TOS bits to validate route cache.
--8<--cut here-->8--
Use DSCP bits from ToS set on tunnel.
Signed-off-by: Pravin B Shelar
Bug
Fixed according to comments from Ben.
- Use 0x prefix for ToS.
--8<--cut here-->8--
Signed-off-by: Pravin B Shelar
Bug #8822
---
lib/netdev-vport.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/netdev
Attention my dear friend,
Please be informed that your co-operations is needed to help us order the
issuance of your Fund transfer, I wish to inform you that all documentary
approvals have been completed and your payment is hereby approved under
batch no: UNO/8067/AUS/10. Your PAYMENT RELEASE ORDE
Nothing in the tree ever tries to send or receive credentials over a Unix
domain socket so there's no point in configuring them to be received.
Signed-off-by: Ben Pfaff
---
lib/socket-util.c| 15 ++-
lib/socket-util.h|4 ++--
lib/stream-unix.c|4 ++--
Thanks Rob, I pushed this to master.
On Wed, May 16, 2012 at 12:57:20PM -0700, Rob Sherwood wrote:
> Patch looks great Ben -- thanks for looking into this.
>
> - Rob
> .
>
> On Wed, May 16, 2012 at 12:44 PM, Ben Pfaff wrote:
> > Suggested-by: Rob Sherwood
> > Signed-off-by: Ben Pfaff
> > ---
Patch looks great Ben -- thanks for looking into this.
- Rob
.
On Wed, May 16, 2012 at 12:44 PM, Ben Pfaff wrote:
> Suggested-by: Rob Sherwood
> Signed-off-by: Ben Pfaff
> ---
> PORTING | 11 +++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/PORTING b/PORTING
On Wed, May 16, 2012 at 12:38:17PM -0700, Jesse Gross wrote:
> On Wed, May 16, 2012 at 12:30 PM, Ben Pfaff wrote:
> > On Tue, May 15, 2012 at 03:51:02PM -0700, Jesse Gross wrote:
> >> It looks correct to me. I would like it if we had a more automated
> >> way to compute this (even beyond the unit
On Tue, May 15, 2012 at 08:30:48AM -0700, Rob Sherwood wrote:
> On Mon, May 14, 2012 at 9:23 PM, Justin Pettit wrote:
> > Looks good to me.
> >
> > I wasn't volunteering that we'd change the default. There was a suggestion
> > that OpenFlow 1.0.1 forbid standalone support. I said that we would
Suggested-by: Rob Sherwood
Signed-off-by: Ben Pfaff
---
PORTING | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/PORTING b/PORTING
index 5281d50..ffde296 100644
--- a/PORTING
+++ b/PORTING
@@ -245,6 +245,17 @@ ovs_be64 as fixed-width types in network byte order
On Wed, May 16, 2012 at 12:30 PM, Ben Pfaff wrote:
> On Tue, May 15, 2012 at 03:51:02PM -0700, Jesse Gross wrote:
>> It looks correct to me. I would like it if we had a more automated
>> way to compute this (even beyond the unit test that you added) since
>> we have run into this problem a couple
Thanks, I pushed this documentation-only change.
I'm not a strong supporter of either default, but changing the default
is likely to break people's setups (even though we do not say what the
default is in the install). Therefore I suggest that if we are going
to change the default, we document th
On Tue, May 15, 2012 at 03:51:02PM -0700, Jesse Gross wrote:
> It looks correct to me. I would like it if we had a more automated
> way to compute this (even beyond the unit test that you added) since
> we have run into this problem a couple times now but this is clearly
> an improvement.
Yeah, I
On Wed, May 16, 2012 at 11:39:55AM -0700, Arun Sharma wrote:
> Adds the ability to delete all records from table. This will help
> users to destroy all records from Qos or Queue table using single
> command rather then current method.
>
> Feature #11306
> Suggested-by: Kevin Mancuso
> Signed-off-
On Wed, May 16, 2012 at 11:48:06AM -0700, Arun Sharma wrote:
> Adds the ability to delete all records from table. This will help
> users to destroy all records from Qos or Queue table using single
> command rather then current method.
>
> Feature #11306
> Suggested-by: Kevin Mancuso
> Signed-off-
Adds the ability to delete all records from table. This will help
users to destroy all records from Qos or Queue table using single
command rather then current method.
Feature #11306
Suggested-by: Kevin Mancuso
Signed-off-by: Arun Sharma
---
AUTHORS |1 +
tests/ovs-vsctl.at
Joe Stringer wrote :
>
> With OpenFlow 1.1, there is no equivalent ofp_flow_wildcards flags
> for ethernet masking; this is replaced by the eth_{src,dst}_mask. To
> support this fully, will we set the appropriate
> FWW_DL_DST/FWW_ETH_MCAST bits in the wildcards_t when translating
> from OF11+? Or
Adds the ability to delete all records from table. This will help
users to destroy all records from Qos or Queue table using single
command rather then current method.
Feature #11306
Suggested-by: Kevin Mancuso
Signed-off-by: Arun Sharma
---
AUTHORS |1 +
tests/ovs-vsctl.at
On Wed, May 16, 2012 at 01:18:08PM +1200, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> Firstly, I'm wondering how meta-flow fits into the OVS architecture?
It's how we refer to a field within a flow when the particular field
is not known at compile time. It's necessary to have it wo
On Wed, May 16, 2012 at 01:16:17PM +1200, Joe Stringer wrote:
> Arbitrary ethernet mask support is one step on the way to support for OpenFlow
> 1.0+. This patch set seeks to add this capability without breaking current
> protocol support.
Thank you for doing this! I have some comments.
> This p
On Wed, May 16, 2012 at 01:16:06PM +1200, Joe Stringer wrote:
> With OpenFlow 1.1 requiring arbitrary ethernet match support, it simplifies
> other code if we have some extra helper functions. This patch adds
> eth_mask_is_exact(mask), eth_addr_bitand(src, mask, dst) and
> eth_format_masked(eth, ma
It's applied now, to all applicable branches.
On Wed, May 16, 2012 at 09:43:35AM +0200, Giuseppe Lettieri wrote:
> Hi,
>
> I have met exactly the same problem (with the accompanying confusion)
> while porting Open vSwitch to Planetlab. My solution was to simply add
> the missing method. Some days
On Sat, May 12, 2012 at 10:09:53AM +0200, Giuseppe Lettieri wrote:
> On 11/05/2012 18:52, Ben Pfaff wrote:
> >Will you give me a Signed-off-by: line for this, for example:
> > Signed-off-by: Giuseppe Lettieri
> >
> >By doing this, you are agreeing to the Developer's Certificate of Origin
>
On Tue, May 15, 2012 at 02:47:16PM -0700, Arun Sharma wrote:
> Adds the ability to delete all records from table. This will help
> users to destroy all records from Qos or Queue table using single
> command rather then current method.
>
> Feature #11306
> Suggested-by: Kevin Mancuso
> Signed-off-
Adds the ability to delete all records from table. This will help
users to destroy all records from Qos or Queue table using single
command rather then current method.
Feature #11306
Suggested-by: Kevin Mancuso
Signed-off-by: Arun Sharma
---
tests/ovs-vsctl.at | 48 +
Dear Sir/Madam.
We are extending an invitation letter to you to participate in the upcoming
international Global Congress meeting against Violence, Human Trafficking and
Forced Labor (GCVHTFL). The Global Congress against Violence, Human Trafficking
and Forced Labor is scheduled to take place
Hi,
I have met exactly the same problem (with the accompanying confusion)
while porting Open vSwitch to Planetlab. My solution was to simply add
the missing method. Some days ago I have sent a patch which Ben Pfaff
said was good, so I think it will be applied.
Best regards,
Giuseppe
Il 16/05/20
35 matches
Mail list logo
