On Wed, May 16, 2012 at 01:16:06PM +1200, Joe Stringer wrote: > With OpenFlow 1.1 requiring arbitrary ethernet match support, it simplifies > other code if we have some extra helper functions. This patch adds > eth_mask_is_exact(mask), eth_addr_bitand(src, mask, dst) and > eth_format_masked(eth, mask, output). > > Signed-off-by: Joe Stringer <j...@wand.net.nz>
Thank you for the patches. I'm happy to see that your summer plans are progressing! In eth_format_masked(), why do we not print the mask if it is zero? This introduces an unnecessary ambiguity. I see that eth_format_masked() can be used in mf_format(); please fold that into the patch. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
