It's applied now, to all applicable branches. On Wed, May 16, 2012 at 09:43:35AM +0200, Giuseppe Lettieri wrote: > Hi, > > I have met exactly the same problem (with the accompanying confusion) > while porting Open vSwitch to Planetlab. My solution was to simply add > the missing method. Some days ago I have sent a patch which Ben Pfaff > said was good, so I think it will be applied. > > Best regards, > Giuseppe > > > Il 16/05/2012 08:41, Min Chen ha scritto: > > Hi, > > > > I've been porting OVS 1.4.0 to a Broadcom chip based ServerSwitch, > > which runs on Windows. > > To take advantage of the switching chip, I am implementing my own > > "ofproto provider". > > > > Function bridge_del_ofprotos is called when all datapaths and datapath > > ports are to be deleted. > > It is done by calling ofproto_delete on each datapath with 'name' and > > 'type' spcified. This is > > comment for ofproto_delete: > > > > /* Destroys the datapath with the respective 'name' and 'type'. > > With the Linux > > * kernel datapath, for example, this destroys the datapath in the > > kernel, and > > * with the netdev-based datapath, it tears down the data > > structures that > > * represent the datapath. > > * > > * The datapath should not be currently open as an ofproto. */ > > > > > > I am a bit confused here. > > > > ofproto_enumerate_names(ofproto.c) => enumerate_names(ofproto-dpif.c) => > > dp_enumerate_names(dpif.c) => enumerate(dpif-netdev.c) > > > > For dpif_netdev_class, the enumerate function pointer is set to NULL. > > Thus for the netdev-based > > datapath, the names sset is still empty after calling > > ofproto_enumerate_names. The ofproto_delete > > will not be called at all. > > > > Am I missing something? > > > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > > > -- > Dr. Ing. Giuseppe Lettieri > Dipartimento di Ingegneria della Informazione > Universita' di Pisa > Largo Lucio Lazzarino 2, 56122 Pisa - Italy > Ph. : (+39) 050-2217.649 (direct) .599 (switch) > Fax : (+39) 050-2217.600 > e-mail: g.letti...@iet.unipi.it >
> _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
