[ovs-dev] [PATCH] nicira-ext: Rename "struct nxt_*" to "struct nx_*".

2011-12-02 Thread Ben Pfaff
Most structures in this file have an "nx_" prefix, so this makes naming more consistent. --- include/openflow/nicira-ext.h | 10 +- lib/ofp-print.c |4 ++-- lib/ofp-util.c|8 ofproto/ofproto.c |8 4 files changed, 15

[ovs-dev] [PATCH] packaging: allow smooth upgrade between kernel modules that use ODP_ and OVS_ Netlink family names

2011-12-02 Thread Ansis Atteka
Some while ago Netlink Family names were changed from ODP_* to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl wanted to remove existing datapaths from the old kernel module by using 'ovs_datapath' instead of 'odp_datapath' name. This patch allows package preinst scipts to take

Re: [ovs-dev] [PATCH] datapath: Fix build breakage on kernel 2.6.40

2011-12-02 Thread Jesse Gross
On Thu, Dec 1, 2011 at 6:25 PM, Zhi Yong Wu wrote: > On Thu, Dec 1, 2011 at 5:55 AM, Jesse Gross wrote: >> On Wed, Nov 23, 2011 at 1:58 AM, Zhi Yong Wu wrote: >>> diff --git a/datapath/linux/compat/include/linux/skbuff.h >>> b/datapath/linux/compat/include/linux/skbuff.h >>> index 311bfdb..22ba

Re: [ovs-dev] Integration of Open vSwitch

2011-12-02 Thread Jesse Gross
On Wed, Nov 30, 2011 at 5:11 AM, jamal wrote: > On Tue, 2011-11-29 at 22:25 -0800, Jesse Gross wrote: >> As I >> mentioned before, I'd like to have a bit of a design discussion of >> what it would look like if Open vSwitch were to use some of the >> existing components (and really focus on just th

Re: [ovs-dev] Integration of Open vSwitch

2011-12-02 Thread Jesse Gross
On Tue, Nov 29, 2011 at 11:00 PM, Herbert Xu wrote: > The other factor I considered is scalability.  The OVS code as is > is not really friendly to SMP/NUMA scalability (but as Eric pointed, > neither is the classifier/action layer).  However, if this were to > become a problem in future I'm sure

Re: [ovs-dev] [GIT PULL v2] Open vSwitch

2011-12-02 Thread Jesse Gross
On Wed, Nov 30, 2011 at 11:52 PM, Herbert Xu wrote: > On Thu, Dec 01, 2011 at 04:24:18PM +0900, Simon Horman wrote: >> >> So while I agree that optimizing the hash is a good idea.  I don't believe >> it is a bottle-neck at this point. Though I could be convinced otherwise if >> long collision chai

Re: [ovs-dev] [PATCH 3/3] datapath: Implement flow table re-hashing.

2011-12-02 Thread Jesse Gross
On Fri, Dec 2, 2011 at 11:00 AM, Pravin B Shelar wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index acbd3bf..ae6b39a 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -63,6 +63,10 @@ >  #error Kernels before 2.6.18 or after 3.2 are not supported by this versi

Re: [ovs-dev] [PATCH 2/2] sflow: Use ofproto_port_get_stats().

2011-12-02 Thread Ben Pfaff
This seems reasonable but I see ways to improve it. The 'netdev' member can now be removed from struct dpif_sflow_port since it can get the same netdev as ofport->netdev. The 'odp_port' member can also be removed since it can be calculated using ofp_port_to_odp_port(ofport->ofp_port). Also, in a

Re: [ovs-dev] [PATCH 1/2] ofproto: Device stats should include packets generated by userspace/controller

2011-12-02 Thread Ben Pfaff
On Fri, Dec 02, 2011 at 02:17:04PM -0800, Pravin B Shelar wrote: > Following patch account packets consumed and composed in userspace > as received on and transmitted from local port. It looks good to me, I only have two small comments. I think that the tx/rx swapping in port_get_stats() is corre

[ovs-dev] [PATCH 2/2] sflow: Use ofproto_port_get_stats().

2011-12-02 Thread Pravin B Shelar
--- ofproto/ofproto-dpif-sflow.c |8 +--- ofproto/ofproto-dpif-sflow.h |3 ++- ofproto/ofproto-dpif.c |5 +++-- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sflow.c index d17b0be..73faf03 100644 --- a/ofpr

[ovs-dev] [PATCH 1/2] ofproto: Device stats should include packets generated by userspace/controller

2011-12-02 Thread Pravin B Shelar
Following patch account packets consumed and composed in userspace as received on and transmitted from local port. --- ofproto/ofproto-dpif.c | 44 ofproto/ofproto-provider.h |4 ofproto/ofproto.c | 18 +- ofpro

Re: [ovs-dev] [PATCH 2/3] datapath: flow hash

2011-12-02 Thread Jesse Gross
On Fri, Dec 2, 2011 at 11:00 AM, Pravin B Shelar wrote: > Following patch keeps raw hash value (derived from key) in > sw_flow. So that new seed value can be used to find hash bucket. > > This patch is required for next patch related to hash-table > re-hashing. > > Signed-off-by: Pravin B Shelar

Re: [ovs-dev] [PATCH 1/3] datapath: RCU'ed dps list.

2011-12-02 Thread Jesse Gross
On Fri, Dec 2, 2011 at 11:00 AM, Pravin B Shelar wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index c86c20b..acbd3bf 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -1544,7 +1544,7 @@ static int ovs_dp_cmd_dump(struct sk_buff *skb, struct > netlink_callbac

Re: [ovs-dev] [PATCH] datapath: Remove custom version of ipv6_skip_exthdr().

2011-12-02 Thread Jesse Gross
On Fri, Dec 2, 2011 at 11:06 AM, Ben Pfaff wrote: > On Thu, Dec 01, 2011 at 06:31:28PM -0800, Jesse Gross wrote: >> On Thu, Dec 1, 2011 at 4:31 PM, Ben Pfaff wrote: >> > On Thu, Dec 01, 2011 at 04:24:07PM -0800, Jesse Gross wrote: >> >> We currently have a version of ipv6_skip_exthdr() which is >

Re: [ovs-dev] [PATCH] datapath: Remove custom version of ipv6_skip_exthdr().

2011-12-02 Thread Ben Pfaff
On Thu, Dec 01, 2011 at 06:31:28PM -0800, Jesse Gross wrote: > On Thu, Dec 1, 2011 at 4:31 PM, Ben Pfaff wrote: > > On Thu, Dec 01, 2011 at 04:24:07PM -0800, Jesse Gross wrote: > >> We currently have a version of ipv6_skip_exthdr() which is > >> identical to the main one with the addition of fragm

Re: [ovs-dev] [PATCH] ovs-dpctl: allow ovs-dpctl to fallback from ovs_datapath to odp_datapath Netlink Family

2011-12-02 Thread Ben Pfaff
On Fri, Dec 02, 2011 at 10:55:28AM -0800, Ansis Atteka wrote: > On Fri, Dec 2, 2011 at 9:55 AM, Ben Pfaff wrote: > > > On Thu, Dec 01, 2011 at 07:55:21PM -0800, Ansis Atteka wrote: > > > Some while ago Netlink Family names were changed from ODP_* > > > to OVS_*. This leaded to upgrade related iss

[ovs-dev] [PATCH 3/3] datapath: Implement flow table re-hashing.

2011-12-02 Thread Pravin B Shelar
This patch is creates an issue where dump-flow might have missing or duplicate flows. I will post other patches to fix it. --8<--cut here-->8-- Following patch introduces a timer based event to rehash flow-hash table. It makes finding collisions dif

[ovs-dev] [PATCH 2/3] datapath: flow hash

2011-12-02 Thread Pravin B Shelar
Following patch keeps raw hash value (derived from key) in sw_flow. So that new seed value can be used to find hash bucket. This patch is required for next patch related to hash-table re-hashing. Signed-off-by: Pravin B Shelar --- datapath/flow.c |3 ++- 1 files changed, 2 insertions(+), 1

[ovs-dev] [PATCH 1/3] datapath: RCU'ed dps list.

2011-12-02 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- datapath/datapath.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index c86c20b..acbd3bf 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -84,7 +84,7 @@ EXPORT_SYMBOL(ovs_dp

Re: [ovs-dev] [PATCH] ovs-dpctl: allow ovs-dpctl to fallback from ovs_datapath to odp_datapath Netlink Family

2011-12-02 Thread Ansis Atteka
On Fri, Dec 2, 2011 at 9:55 AM, Ben Pfaff wrote: > On Thu, Dec 01, 2011 at 07:55:21PM -0800, Ansis Atteka wrote: > > Some while ago Netlink Family names were changed from ODP_* > > to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl > > wanted to remove existing datapaths from

Re: [ovs-dev] rtnetlink_notifier_register() function

2011-12-02 Thread Ben Pfaff
Thanks. I pushed this to master. Did you actually notice any problems without this patch in practice? I am trying to determine whether it should be backported to branch-1.{2,3,4}. Thanks, Ben. On Fri, Dec 02, 2011 at 10:20:15AM +0100, Gaetano Catalli wrote: > I think that's fine. > > On Wed,

Re: [ovs-dev] [PATCH] ovs-dpctl: allow ovs-dpctl to fallback from ovs_datapath to odp_datapath Netlink Family

2011-12-02 Thread Ben Pfaff
On Thu, Dec 01, 2011 at 07:55:21PM -0800, Ansis Atteka wrote: > Some while ago Netlink Family names were changed from ODP_* > to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl > wanted to remove existing datapaths from the old kernel module > by using 'ovs_datapath' instead of

[ovs-dev] Bonjour

2011-12-02 Thread Mariame Fofana
-- Bonjour, Je vous prie de bien vouloir m'excuser pour cette intrusion qui peut paraître surprenante à première vue, car c'est avec courage et peur, que je vous écris cette lettre d'autant plus qu'il n'existe aucune relation entre nous. J'ai eu votre adresse dans l'annuaire international du Web p

[ovs-dev] Hello

2011-12-02 Thread Miss Cindy Kipkalya
How are you? Please get back to me i have some important discussion to discuss with you. urgently. Cindy. Nuova grafica e nuove funzionalità! Crea subito Gratis la tua nuova Casella di Posta Katamail ___ dev mailing lis

Re: [ovs-dev] rtnetlink_notifier_register() function

2011-12-02 Thread Gaetano Catalli
I think that's fine. On Wed, Nov 30, 2011 at 8:00 PM, Ben Pfaff wrote: > On Mon, Nov 28, 2011 at 09:15:08AM -0800, Ben Pfaff wrote: >> On Mon, Nov 28, 2011 at 04:19:07PM +0100, Gaetano Catalli wrote: >> > the following is a snippet of code taken from the >> > netdev_linux_create_system() function