This seems reasonable but I see ways to improve it. The 'netdev' member can now be removed from struct dpif_sflow_port since it can get the same netdev as ofport->netdev. The 'odp_port' member can also be removed since it can be calculated using ofp_port_to_odp_port(ofport->ofp_port).
Also, in a comment, s/retrive/retrieve/. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
