Thanks. I pushed this to master.
Did you actually notice any problems without this patch in practice?
I am trying to determine whether it should be backported to
branch-1.{2,3,4}.
Thanks,
Ben.
On Fri, Dec 02, 2011 at 10:20:15AM +0100, Gaetano Catalli wrote:
> I think that's fine.
>
> On Wed, Nov 30, 2011 at 8:00 PM, Ben Pfaff <b...@nicira.com> wrote:
> > On Mon, Nov 28, 2011 at 09:15:08AM -0800, Ben Pfaff wrote:
> >> On Mon, Nov 28, 2011 at 04:19:07PM +0100, Gaetano Catalli wrote:
> >> > the following is a snippet of code taken from the
> >> > netdev_linux_create_system() function in lib/netdev-linux.c. It wants
> >> > to attach a callback to interfaces status change events. The notifier
> >> > is unique for all devices so it is created when the first port is
> >> > attached to the switch and deleted when the last port is removed(in
> >> > netdev_linux_destroy()). I can't understand why this code is present
> >> > only in netdev_linux_create_system(), while it is missing in
> >> > netdev_linux_tap_create(). Does anybody have an explanation for that?
> >>
> >> It does look like we should include that as common code between the
> >> two functions.
> >
> > I sent out a patch (you are CCed). ?Please look it over.
> >
> > Thanks,
> >
> > Ben.
>
>
>
> --
> gaetano catalli
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
