On Thu, Sep 22, 2011 at 06:15:41PM -0700, Justin Pettit wrote:
> .IP "\fBshow\-log\fI db\fR"
> -Prints a summary of the records in \fBdb\fR's log, including the time
> +Prints a summary of the records in \fIdb\fR's log, including the time
> and date at which each database change occurred and any
---
ovsdb/ovsdb-tool.1.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ovsdb/ovsdb-tool.1.in b/ovsdb/ovsdb-tool.1.in
index 3c2a37c..16b8b1f 100644
--- a/ovsdb/ovsdb-tool.1.in
+++ b/ovsdb/ovsdb-tool.1.in
@@ -131,7 +131,7 @@ instead, to write to a database that is served
Looks good.
(Based on our conversation earlier, I guess this is a good day, so you didn't
just push it.)
--Justin
On Sep 22, 2011, at 5:12 PM, Ben Pfaff wrote:
> ---
> debian/ovs-monitor-ipsec |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/debian/ovs-monitor-ip
Track vlan-id correctly. So that we can use that information for
composing optimized action set.
---
ofproto/ofproto-dpif.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index bd976f7..cef37a6 100644
--- a/ofproto
---
debian/ovs-monitor-ipsec |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec
index a9af8ec..019da23 100755
--- a/debian/ovs-monitor-ipsec
+++ b/debian/ovs-monitor-ipsec
@@ -136,7 +136,7 @@ path certificate "%s";
def
On Thu, Sep 22, 2011 at 04:49:33PM -0700, Neil McKee wrote:
>
> On Sep 22, 2011, at 4:07 PM, Pravin Shelar wrote:
>
> > On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote:
> >> It's not so great to have to call netdev_get_stats() for every sflow
> >> packet we send. Maybe we could rate-limit the
On Sep 22, 2011, at 4:07 PM, Pravin Shelar wrote:
> On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote:
>> On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote:
>>> v3: Fixed according to comments from Ben
>>> - Probability calculation
>>> - Coding style fixes
>>> - Now SAM
On Thu, Sep 22, 2011 at 04:07:46PM -0700, Pravin Shelar wrote:
> On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote:
> > On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote:
> > compose_controller_action() leaves some fields uninitialized.
>
> As other values are only required in case of s
On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote:
> On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote:
>> v3: Fixed according to comments from Ben
>> - Probability calculation
>> - Coding style fixes
>> - Now SAMPLE actions is not optional
>> - Using offset to fix u
On Thu, Sep 22, 2011 at 1:11 PM, Ben Pfaff wrote:
> On Mon, Sep 19, 2011 at 03:00:08PM -0700, Jesse Gross wrote:
>> Currently it is possible for a client on a single port to generate
>> a huge number of packets that miss in the kernel flow table and
>> monopolize the userspace/kernel communication
Thanks, I pushed this.
On Wed, Sep 21, 2011 at 07:25:51PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Sep 21, 2011, at 9:52 AM, Ben Pfaff wrote:
>
> > Bug #7434.
> > Reported-by: Michael Mao
> > ---
> > lib/ofp-print.c|4 +++-
> > tests/ofp-print.at | 15 +
On Thu, Sep 22, 2011 at 01:58:49PM -0700, Jesse Gross wrote:
> On Thu, Sep 22, 2011 at 12:48 PM, Ben Pfaff wrote:
> > On Mon, Sep 19, 2011 at 03:00:07PM -0700, Jesse Gross wrote:
> >> Each time we run through the poll loop, we check all file descriptors
> >> that we were waiting on to see if there
On Thu, Sep 22, 2011 at 1:58 PM, Ben Pfaff wrote:
> On Thu, Sep 22, 2011 at 01:50:26PM -0700, Jesse Gross wrote:
>> On Thu, Sep 22, 2011 at 11:33 AM, Ben Pfaff wrote:
>> > In find_dpif(), as a micro-optimization you could use
>> > HMAP_FOR_EACH_IN_BUCKET in place of HMAP_FOR_EACH_WITH_HASH.
>>
>>
On Thu, Sep 22, 2011 at 12:48 PM, Ben Pfaff wrote:
> On Mon, Sep 19, 2011 at 03:00:07PM -0700, Jesse Gross wrote:
>> Each time we run through the poll loop, we check all file descriptors
>> that we were waiting on to see if there is data available. However,
>> this requires a system call and poll
On Thu, Sep 22, 2011 at 01:50:26PM -0700, Jesse Gross wrote:
> On Thu, Sep 22, 2011 at 11:33 AM, Ben Pfaff wrote:
> > In find_dpif(), as a micro-optimization you could use
> > HMAP_FOR_EACH_IN_BUCKET in place of HMAP_FOR_EACH_WITH_HASH.
>
> You mean because comparing the ifindex is just as cheap
On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote:
> v3: Fixed according to comments from Ben
> - Probability calculation
> - Coding style fixes
> - Now SAMPLE actions is not optional
> - Using offset to fix user-action-cookie.
>
> I will post another patch to handl
On Thu, Sep 22, 2011 at 11:33 AM, Ben Pfaff wrote:
> On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote:
>> Currently we publish several multicast groups for upcalls and let
>> userspace sockets subscribe to them. The benefit of this is mostly
>> that userspace is the one doing the subsc
On Sep 22, 2011, at 12:52 PM, Jesse Gross wrote:
>> Are you suggesting that we revert the original patch or that we don't use my
>> patch? I don't like shipping software with compiler warnings, and since the
>> warning was introduced post-1.2.1, I'd like to get rid of the warning. I
>> can al
On Mon, Sep 19, 2011 at 03:00:08PM -0700, Jesse Gross wrote:
> Currently it is possible for a client on a single port to generate
> a huge number of packets that miss in the kernel flow table and
> monopolize the userspace/kernel communication path. This
> effectively DoS's the machine because no
On Thu, Sep 22, 2011 at 12:29 PM, Justin Pettit wrote:
> On Sep 22, 2011, at 11:17 AM, Jesse Gross wrote:
>
>> On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit wrote:
>>> Commit d6b37e42 (datapath: Allow a packet with no input port to omit
>>> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 188
On Mon, Sep 19, 2011 at 03:00:07PM -0700, Jesse Gross wrote:
> Each time we run through the poll loop, we check all file descriptors
> that we were waiting on to see if there is data available. However,
> this requires a system call and poll already provides information on
> which FDs caused the w
Thanks, I pushed it.
On Thu, Sep 22, 2011 at 12:30:29PM -0700, Justin Pettit wrote:
> Assuming it fixes problems, it looks reasonable to me.
>
> --Justin
>
>
> On Sep 22, 2011, at 11:54 AM, Ben Pfaff wrote:
>
> > Commit 00fa9d37c2b "Do not include net/ethernet.h and linux/if_tunnel.h"
> > intr
Assuming it fixes problems, it looks reasonable to me.
--Justin
On Sep 22, 2011, at 11:54 AM, Ben Pfaff wrote:
> Commit 00fa9d37c2b "Do not include net/ethernet.h and linux/if_tunnel.h"
> introduced a compile error on RHEL 6:
>
> lib/netdev-linux.c: In function 'netdev_linux_listen':
> lib/net
On Sep 22, 2011, at 11:17 AM, Jesse Gross wrote:
> On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit wrote:
>> Commit d6b37e42 (datapath: Allow a packet with no input port to omit
>> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the
>> "master" branch, but dropped a few lines. This
Commit 00fa9d37c2b "Do not include net/ethernet.h and linux/if_tunnel.h"
introduced a compile error on RHEL 6:
lib/netdev-linux.c: In function 'netdev_linux_listen':
lib/netdev-linux.c:734: error: 'ETH_P_ALL' undeclared (first use in this
function)
This fixes the problem.
I verified that the And
On Mon, Sep 19, 2011 at 03:00:06PM -0700, Jesse Gross wrote:
> Now that upcalls from the kernel use unicast sockets, we need to
> tell the kernel where to send them explicitly. This means that
> when the switch is restarted it's necessary to take control of any
> existing objects, which is done wh
On Thu, Sep 22, 2011 at 11:07:43AM -0700, Jesse Gross wrote:
> Yeah, I understand the rationale for the FD-swapping and I think it
> makes sense in the context of transactions and dumps being intermixed.
> The specific part that made me nervous is usage with multicast or
> unicast upcalls where it
On Wed, Sep 21, 2011 at 10:43:48PM -0700, Jesse Gross wrote:
> On Wed, Sep 21, 2011 at 10:28 PM, Ben Pfaff wrote:
> > On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote:
> >> Currently we publish several multicast groups for upcalls and let
> >> userspace sockets subscribe to them. ??The
On Mon, Sep 19, 2011 at 03:00:05PM -0700, Jesse Gross wrote:
> Currently we publish several multicast groups for upcalls and let
> userspace sockets subscribe to them. The benefit of this is mostly
> that userspace is the one doing the subscription - the actual
> multicast capability is not curren
On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit wrote:
> Commit d6b37e42 (datapath: Allow a packet with no input port to omit
> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the
> "master" branch, but dropped a few lines. This causes a compiler
> warning about an unused "done" lab
On Thu, Sep 22, 2011 at 10:38 AM, Ben Pfaff wrote:
> On Wed, Sep 21, 2011 at 11:02:03PM -0700, Jesse Gross wrote:
>> On Wed, Sep 21, 2011 at 9:37 PM, Ben Pfaff wrote:
>> > On Mon, Sep 19, 2011 at 03:00:04PM -0700, Jesse Gross wrote:
>> >> In the future, the kernel will use unicast messages instea
Thanks, I pushed it.
On Wed, Sep 21, 2011 at 06:53:39PM -0700, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Wed, Sep 21, 2011 at 14:57, Ben Pfaff wrote:
> > pychecker imports the code that it checks, which means that code at top
> > level runs, so "ovs-xapi-sync" failed to import unless
On Wed, Sep 21, 2011 at 11:02:03PM -0700, Jesse Gross wrote:
> On Wed, Sep 21, 2011 at 9:37 PM, Ben Pfaff wrote:
> > On Mon, Sep 19, 2011 at 03:00:04PM -0700, Jesse Gross wrote:
> >> In the future, the kernel will use unicast messages instead of
> >> multicast to send upcalls. ??As a result, we ne
Thanks, I pushed this to "master" and "branch-1.2".
On Wed, Sep 21, 2011 at 06:56:57PM -0700, Justin Pettit wrote:
> Looks good to me.
>
> --Justin
>
>
> On Sep 21, 2011, at 2:44 PM, Ben Pfaff wrote:
>
> > From: Daniel Roman
> >
> > Bug #5443.
> > ---
> > AUTHORS |
On Thu, Sep 22, 2011 at 09:24:09PM +0900, Simon Horman wrote:
> The series consists of the following patches
> [PATCH 1/5] Include in socket-util.h
> [PATCH 2/5] Include in socket-util.h
> [PATCH 3/5] Add fallback definition of SIG_ATOMIC_MAX
> [PATCH 4/5] Do not include net/ethernet.h and linux/
net/ethernet.h and linux/if_tunnel.h do not appear to be needed
on lib/netdev-linux.c.
I noticed this while trying to build on the Android NDK r6b (Android API
level 13) as these headers are not present there.
---
lib/netdev-linux.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
dif
sys/time.h appears to be required for a definition of timespec on Android.
Observed when compiling using the Android NDK r6b (Android API level 13).
---
lib/socket-util.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/socket-util.h b/lib/socket-util.h
index c00ade2..
netdev_find_dev_by_in4() appears to no longer be used and thus
can be removed. This also allows netdev_enumerate(), the
enumerate member of struct netdev_class and netdev_linux_enumerate()
to be removed.
I noticed this as netdev_linux_enumerate() makes use of if_nameindex()
and if_freenameindex()
Hi,
the following series is intended to bring Open vSwitch closer
to being able to be compiled when compiling using the Android NDK r6b
(Android API level 13).
The series consists of the following patches
[PATCH 1/5] Include in socket-util.h
[PATCH 2/5] Include in socket-util.h
[PATCH 3/5] Add
This appears to be necessary to get a definition of socket_t
when compiling using the Android NDK r6b (Android API level 13).
---
lib/socket-util.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/socket-util.h b/lib/socket-util.h
index 0376006..c00ade2 100644
--- a/lib
Android appears to lack SIG_ATOMIC_MAX which is only
used in fatal-signal.c.
Observed when compiling using the Android NDK r6b (Android API level 13).
Patch based on a suggestion by Ben Pfaff
---
lib/fatal-signal.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/lib
Reply if you need business or Personal loan.___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Since it's not clear from the message, this commit is for "branch-1.2".
--Justin
On Sep 21, 2011, at 11:51 PM, Justin Pettit wrote:
> Commit d6b37e42 (datapath: Allow a packet with no input port to omit
> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the
> "master" branch, but d
43 matches
Mail list logo
