On Sep 22, 2011, at 12:52 PM, Jesse Gross wrote: >> Are you suggesting that we revert the original patch or that we don't use my >> patch? I don't like shipping software with compiler warnings, and since the >> warning was introduced post-1.2.1, I'd like to get rid of the warning. I >> can also reduce the patch to only remove the "done" label. > > Not using the patch. I don't think making changes for the sole > purpose of removing compiler warnings is a particularly good > justification for doing something on a stable branch. I think the > strongest argument in favor of this patch is actually correcting the > behavior, not the warning.
I don't want to ship with compiler warnings, so, in that case, I pushed the entire patch. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
