On Thu, Sep 22, 2011 at 04:49:33PM -0700, Neil McKee wrote: > > On Sep 22, 2011, at 4:07 PM, Pravin Shelar wrote: > > > On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff <b...@nicira.com> wrote: > >> It's not so great to have to call netdev_get_stats() for every sflow > >> packet we send. Maybe we could rate-limit the calls and cache old > >> values? > > > > OK, I will keep 1 sec interval for get stats.
... > The sending of PACKET samples is a different matter. Is that what > this is about? I wasn't sure from the context. If this is about > including the sample_pool with every PACKET sample then it's worth > considering how often it will really be retrieved. With typical > settings you will only be generating a handful of samples per > second, so retrieving the latest sample_pool every time shouldn't be > too onerous(?) At any given moment only a small number of > interfaces will be "hot" and generating samples. This is about packet samples. If that's the common case, then, Pravin, let's leave it the way you had it. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
