On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit <jpet...@nicira.com> wrote:
> Commit d6b37e42 (datapath: Allow a packet with no input port to omit
> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the
> "master" branch, but dropped a few lines.  This causes a compiler
> warning about an unused "done" label.  This commit brings the two
> patches in line.
>
> Signed-off-by: Justin Pettit <jpet...@nicira.com>

I thought about this before but decided not to do it because it's not
really a bug fix (it makes the kernel slightly more restrictive about
what it accepts from userspace than is necessary but no OVS userspace
ever generates requests that don't conform) so it's mostly about
squelching a compiler warning.  From that perspective, it doesn't
really seem like stable branch material.

I guess it's mostly a backporting error, so maybe it can be considered
a bug.  I guess it's fine to push if you want.
Acked-by: Jesse Gross <je...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to