Ox64 crash Was: Re: [VOTE] Apache NuttX 12.4.0 RC0 release

2024-01-14 Thread Juha Niskanen (Haltian)
There is something wrong with this release on Ox64 board. Just running this sequence of commands in ox64:nsh defconfig machine: cd /system/bin getprime hello produces a crash: riscv_exception: EXCEPTION: Store/AMO page fault. MCAUSE: 000f, EPC: 50209134, MTVAL: 8020

Re: [DISCUSS] Default state of NDEBUG

2022-02-17 Thread Juha Niskanen (Haltian)
NDEBUG is just one macro name. I feel it is silly to have either one or two CONFIG macros to control whether or not it is defined or not. My preference is zero new CONFIG macros. We have too many already and trend seems to be remove ones that disable standard POSIX features (CONFIG_DISABLE_SIGNA

Re: [Discuss] Migrate the build system to CMake

2021-06-09 Thread Juha Niskanen (Haltian)
Hello, I agree with Sebastien. There is no problem to solve here but potential for massive breakage and extra burden on companies using NuttX to develop real products. Actual NuttX users all have their own build and CI verify infrastructure accustomed to current NuttX build system and doing th

Re: 1wire subsystem

2021-04-05 Thread Juha Niskanen (Haltian)
Sent: Saturday, April 3, 2021 5:03 PM To: dev@nuttx.apache.org Cc: Juha Niskanen (Haltian) Subject: Re: 1wire subsystem Hi Alan, yes of course, moving to include/nuttx/1wire/1wire_master.h also means splitting into different header files 1wire_master.h 1wire_slave.h and so on. Maybe juha doesn&#

Re: Can Haltian signal SGA?

2021-03-05 Thread Juha Niskanen (Haltian)
riginally written by other Haltian authors so indeed executing the SGA would be beneficial. Best Regards, Juha From: Xiang Xiao Sent: Friday, March 5, 2021 11:56 AM To: Juha Niskanen (Haltian) ; dev@nuttx.apache.org Subject: Can Haltian signal SGA? Juha, coul

Re: condition variables and signals

2021-01-13 Thread Juha Niskanen (Haltian)
BTW, looking at the spec for pthread_cond_wait, there's actually no mention about a limitation regarding using pthread_cond_signal invoked from within a signal handler to unblock a pthread_cond_wait. The restriction is elsewhere. pthread_cond_signal() is not in the list of async-signal-safe func

Re: Should TASK_NAME_SIZE be changed in most configs?

2020-11-23 Thread Juha Niskanen (Haltian)
Our in-house build system has a modified configure.sh that allows #include directives in defconfig files and subsequent entries to override the inherited config vars, like this: ~/nuttx/boards/arm/stm32l4/haltian-example-board/configs/nsh-dbg$ cat defconfig #include "../nsh/defconfig" # CONFIG_

Re: select()/pselect() function

2020-11-20 Thread Juha Niskanen (Haltian)
>From POSIX: "If the timeout interval expires without the specified condition >being true for any of the specified file descriptors, the objects pointed to >by the readfds, writefds, and errorfds arguments shall have all bits set to 0." If your select() timeouts on first loop iteration for any r

Re: nxstyle mixed case identifiers

2020-05-18 Thread Juha Niskanen (Haltian)
It would be good to document the Hz, MHz, ... exception in the section 2.8 of the coding style document, along with VOLTAGE_3p3V and CONFIG_NET_IPv6. How about also allowing VOLTAGE_2mV and CURRENT_4mA and also uV and uA? I find it odd that the battery charger drivers now charge with megavolts a

Re: [PATCH] nshlib/nsh_codeccmd.c: fix potential NULL dereference and check malloc return values

2020-04-17 Thread Juha Niskanen (Haltian)
h NuttX daily, it will be more efficient and collaborative if you can send the patch through github PR. Thanks Xiang On Thu, Apr 16, 2020 at 8:53 PM Alan Carvalho de Assis wrote: > > Hi Juha, > > I just created apps PR #183 with your patch. > > Thank you! > > BR, > >

[PATCH] nshlib/nsh_codeccmd.c: fix potential NULL dereference and check malloc return values

2020-04-16 Thread Juha Niskanen (Haltian)
Hi, Small thing I found when reading through nsh code. Best Regards, Juha From 16c0929da29f38057d42c72219afe7d86aa19962 Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Thu, 16 Apr 2020 13:36:21 +0300 Subject: [PATCH] nshlib/nsh_codeccmd.c: fix potential NULL dereference and check malloc r

[PATCH] drivers/usbdev/usbmsc.c: fix build error with DEBUGASSERT

2020-04-15 Thread Juha Niskanen (Haltian)
Hi, Another recent build failure. Best Regards, Juha From 0ed36626013fc72d25c533a950e6a2ee1100952a Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Wed, 15 Apr 2020 17:11:53 +0300 Subject: [PATCH] drivers/usbdev/usbmsc.c: fix build error with DEBUGASSERT --- drivers/usbdev/usbmsc.c | 2 +-

Re: Adding support for STM32G474RET6

2020-04-15 Thread Juha Niskanen (Haltian)
From: raiden00pl . Sent: Wednesday, April 15, 2020 8:49 AM >L1, F1+F3 in a separate directory are a bad idea for me, but L1+F1 >separation looks better. L1+F1 are not really that compatible. Only common thing is that both are quite old and not really used for new projects. L1 is much newer, it w

Re: Adding support for STM32G474RET6

2020-04-15 Thread Juha Niskanen (Haltian)
From: Nathan Hartman Sent: Wednesday, April 15, 2020 7:07 AM >How do you know whether the IP is the same? By which, I mean: Is there a > better way than to study both datasheets and manually look for differences? Unfortunately that is the only really reliable way. Sometimes there are very mino

[PATCH] arch/arm/src/stm32f7/stm32_flash.c: fix return value of stm32_flash_lock

2020-04-14 Thread Juha Niskanen (Haltian)
Hi, Yet another one Best Regards, Juha From 251c978ef83589ee3ab31b367f538692ecc77bf2 Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Tue, 14 Apr 2020 18:25:56 +0300 Subject: [PATCH] arch/arm/src/stm32f7/stm32_flash.c: fix return value of stm32_flash_lock --- arch/arm/src/stm32f7/stm

[PATCH] arch/arm/src/stm32l4/stm32l4_1wire.c: fix build error, fix typo

2020-04-14 Thread Juha Niskanen (Haltian)
Hi, Yet another trivial build error. Best Regards, Juha From 7756b0d3f401e8fc16740f2f13c57a9d76a353c0 Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Tue, 14 Apr 2020 18:20:33 +0300 Subject: [PATCH] arch/arm/src/stm32l4/stm32l4_1wire.c: fix build error, fix typo --- arch/arm/src/lc823450

[PATCH] arch/arm/src/stm32l4/stm32l4_spi.c: add missing ret

2020-04-14 Thread Juha Niskanen (Haltian)
Hi Greg, Trivial build error corrected. Best Regards, Juha From 402bdadb6f51ce8879931fa0067fa82bcf3c0677 Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Tue, 14 Apr 2020 16:42:09 +0300 Subject: [PATCH] arch/arm/src/stm32l4/stm32l4_spi.c: add missing ret --- arch/arm/src/stm32l4/stm32l4_s

Re: RTC Periodic interrupt issue

2020-03-06 Thread Juha Niskanen (Haltian)
Hi Anjana, On quick code reading, I think you are right. We have only used RTC_SET_PERIODIC and RTC_CANCEL_PERIODIC in pairs and as a third alarm so have not noticed this before. Could you please submit a patch or PR when satisfied with your testing. Best Regards, Juha _

[PATCH] arch/arm/src/stm32l4/stm32l4_iwdg.c: do not unconditionally enable debug bits

2020-03-06 Thread Juha Niskanen (Haltian)
The DBGMCU_APB1_FZ bit persists over regular software resets until next POR-reset. It can impact device power consumption and things that persist over resets are a bane for FOTA updates so make it disabled by default. OpenOCD sets this via DAP when connecting to target so enabling this from Kconfi

[PATCH] drivers/sensors/sgp30.c: reset I2C in case init msg takes too long

2020-03-05 Thread Juha Niskanen (Haltian)
Hi Greg, We have experimentally found out that this change helps with somewhat quirky CO2/VOC-sensor. Best Regards, Juha Niskanen From f09acf45e1c94e454e3379a165aebe601e39b22d Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Thu, 5 Mar 2020 09:55:57 +0200 Subject: [PATCH] drivers/sensors/s

[PATCH] Fix typos in comments

2020-03-03 Thread Juha Niskanen (Haltian)
Hi, Yet another trivial typo patch. Best Regards, Juha Niskanen From 70af33b5cff1f137ddd7ee01afe00dd1a45a8ba4 Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Tue, 3 Mar 2020 13:57:22 +0200 Subject: [PATCH] Fix typos in comments --- ReleaseNotes | 2 +

[PATCH] mm/mm_heap/mm_mallinfo.c: fix assertion broken in 312ea9f9

2020-02-17 Thread Juha Niskanen (Haltian)
Hi, Recent commit supposedly silenced warnings in mm_heap, in fact it botched mm_mallinfo() assertions completely. Attached patch fixes this. Best Regards, Juha Niskanen From 0639469819648a33d37694d6b8f5fadc25e3fa6f Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Mon, 17 Feb 2020 11:12:40

[PATCH] Fix typos in comments

2020-02-14 Thread Juha Niskanen (Haltian)
Hi Greg, Patch has trivial comment changes only, no functional change. Best Regards, Juha Niskanen From 6cab0ea08b2e5c8b8f5ebe2d893c6e32f354 Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Fri, 14 Feb 2020 12:55:01 +0200 Subject: [PATCH] Fix typos in comments --- ReleaseNotes

[PATCH] Fix typos and some incorrect comments

2020-01-20 Thread Juha Niskanen (Haltian)
Hi Greg, Patch fixes some typos and also few factually incorrect source code comments. Best Regards, Juha Niskanen From 6d586d655de5c5385a6ee746c8e45be9c9351f2b Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Mon, 20 Jan 2020 12:59:49 +0200 Subject: [PATCH] Fix typos and some incorrect com

[PATCH] net/usrsock/usrsock_dev.c: fix uninitialized 'ret' introduced in 6a3c2ade

2020-01-09 Thread Juha Niskanen (Haltian)
Hi Patch fixes recently introduced usersock failure. There is debugging discussion at https://github.com/apache/incubator-nuttx/pull/24 Best Regards, Juha Niskanen From b45e76c83b18f4443a2620fdec7121a51c1810fd Mon Sep 17 00:00:00 2001 From: Juha Niskanen Date: Thu, 9 Jan 2020 14:40:32 +0200 S

Re: [DISCUSS - NuttX Workflow]

2019-12-19 Thread Juha Niskanen (Haltian)
-1 for anything that has git submodules in it. Didn't we try submodules at one time and it did not work out and was abandoned? Why is this even discussed now? We can do the Apache transition with repositories as they are today and change the workflow or source code organization later, right? Not