[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #5962: arch/riscv: Rename SCRATCH_HARTID_OFFSET to RISCV_HARTID_OFFSET

2022-04-03 Thread GitBox
xiaoxiang781216 commented on code in PR #5962: URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841350940 ## arch/risc-v/src/common/riscv_percpu.h: ## @@ -38,10 +38,11 @@ * Pre-processor Definitions

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5962: arch/riscv: Rename SCRATCH_HARTID_OFFSET to RISCV_HARTID_OFFSET

2022-04-03 Thread GitBox
pkarashchenko commented on code in PR #5962: URL: https://github.com/apache/incubator-nuttx/pull/5962#discussion_r841283611 ## arch/risc-v/src/common/riscv_percpu.h: ## @@ -38,10 +38,11 @@ * Pre-processor Definitions **

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
liuguo09 commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#issuecomment-602171894 > @liuguo09 Sorry it took me so long to get this together after I pointed you at my proof of concept. I was tryi

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
liuguo09 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396072819 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,58 @@ +# Licen

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #18: Configure python environment and install esptool

2020-03-22 Thread GitBox
xiaoxiang781216 commented on issue #18: Configure python environment and install esptool URL: https://github.com/apache/incubator-nuttx-testing/pull/18#issuecomment-602170823 > @xiaoxiang781216 Will this suffice to fix [437](https://github.com/apache/incubator-nuttx/pull/437) ? > The P

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
liuguo09 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396072392 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,58 @@ +# Licen

[GitHub] [incubator-nuttx-testing] Ouss4 commented on issue #18: Configure python environment and install esptool

2020-03-22 Thread GitBox
Ouss4 commented on issue #18: Configure python environment and install esptool URL: https://github.com/apache/incubator-nuttx-testing/pull/18#issuecomment-602169680 @xiaoxiang781216 Will this suffice to fix [437](https://github.com/apache/incubator-nuttx/pull/437) ? The POSTBUILD script

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
xiaoxiang781216 commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#issuecomment-602163664 https://github.com/apache/incubator-nuttx/pull/437 --

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool

2020-03-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool URL: https://github.com/apache/incubator-nuttx-testing/pull/18#discussion_r396066270 ## File path: cibuild.sh ## @@ -118,6 +123,7 @@ function xtensa-esp32-gcc-toolc

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool

2020-03-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #18: Configure python environment and install esptool URL: https://github.com/apache/incubator-nuttx-testing/pull/18#discussion_r396066155 ## File path: cibuild.sh ## @@ -24,6 +24,11 @@ apps=$WD/../apps tools=$WD/../t

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396065947 ## File path: docker/linux/Dockerfile ## @@ -0,0 +1,153 @@ +# Licensed

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396065702 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,58 @@ +

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-22 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396065709 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,58 @@ +

[GitHub] [incubator-nuttx-testing] btashton opened a new pull request #18: Configure python environment and install esptool

2020-03-21 Thread GitBox
btashton opened a new pull request #18: Configure python environment and install esptool URL: https://github.com/apache/incubator-nuttx-testing/pull/18 This configures a the python user installation environment and then installs the `esptool` dependency. Should resolve the nightly build i

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056621 ## File path: docker/linux/Dockerfile ## @@ -0,0 +1,151 @@ +# Licensed

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056574 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,54 @@ +# Licen

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056440 ## File path: docker/linux/Dockerfile ## @@ -0,0 +1,151 @@ +# Licensed to the

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056422 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,56 @@ +# Licen

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056207 ## File path: docker/linux/Dockerfile ## @@ -0,0 +1,151 @@ +# Licensed to the

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-21 Thread GitBox
xiaoxiang781216 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-602150298 Replace by https://github.com/apache/incubator-nuttx-testing/pull/17, let close it. -

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 closed pull request #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-21 Thread GitBox
xiaoxiang781216 closed pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13 This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 closed pull request #2: Multibranch pipeline job example

2020-03-21 Thread GitBox
xiaoxiang781216 closed pull request #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #2: Multibranch pipeline job example

2020-03-21 Thread GitBox
xiaoxiang781216 commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-602150220 Since the current ci system base on github action, let's close this now.

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055526 ## File path: docker/linux/Dockerfile ## @@ -0,0 +1,151 @@ +# Licensed

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055892 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,54 @@ +

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055462 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,56 @@ +

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055892 ## File path: .github/workflows/docker_linux.yml ## @@ -0,0 +1,54 @@ +

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396055102 ## File path: docker/linux/Dockerfile ## @@ -0,0 +1,151 @@ +# Licensed

[GitHub] [incubator-nuttx-testing] btashton commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
btashton commented on issue #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17#issuecomment-602144959 @liuguo09 Sorry it took me so long to get this together after I pointed you at my proof of concept. I was tryin

[GitHub] [incubator-nuttx-testing] btashton opened a new pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

2020-03-21 Thread GitBox
btashton opened a new pull request #17: Add Dockerfile for CI system and hook into GitHub Actions URL: https://github.com/apache/incubator-nuttx-testing/pull/17 This is a reworking of the Docker container to be used with the GitHub Action CI job for github.com/apache/incubator-nuttx

[GitHub] [incubator-nuttx-testing] masayuki2009 commented on issue #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
masayuki2009 commented on issue #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16#issuecomment-601514544 It looks good to me. This is an automated message from the A

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
xiaoxiang781216 merged pull request #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
liuguo09 commented on a change in pull request #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395425971 ## File path: testlist/mips-riscv-x86-xtensa.dat ## @@ -5,3 +5,5 @@ -nr5m100-nexys4:nsh /x86

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395423947 ## File path: testlist/mips-riscv-x86-xtensa.dat ## @@ -5,3 +5,5 @@ -nr5m100-nexys4:nsh

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395423947 ## File path: testlist/mips-riscv-x86-xtensa.dat ## @@ -5,3 +5,5 @@ -nr5m100-nexys4:nsh

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
liuguo09 commented on issue #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16#issuecomment-601506539 Take care to merge the change since github action docker image and matrix boards should be updated synchronously. --

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #16: Add xtensa esp32 boards build support

2020-03-19 Thread GitBox
liuguo09 opened a new pull request #16: Add xtensa esp32 boards build support URL: https://github.com/apache/incubator-nuttx-testing/pull/16 1. Add xtensa esp32 gcc toolchain 2. Add xtensa esp32 boards into testlist Note nuttx and apps github action workflows also need update accor

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599889055 > My plan was to use the incubator-nuttx-testing repo. I can submit a PR with this and the action to

[GitHub] [incubator-nuttx-testing] btashton edited a comment on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
btashton edited a comment on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599870749 My plan was to use the incubator-nuttx-testing repo. I can submit a PR with this and the actio

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599870749 My plan was to use the incubator-nuttx-testing container. I can submit a PR with this and the action

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo

2020-03-16 Thread GitBox
xiaoxiang781216 merged pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo URL: https://github.com/apache/incubator-nuttx-testing/pull/14 This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599860083 Or is it possible just using the incubator-nuttx-testing to hold dockerfile and do docker publish git

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599857989 Yes, I noticed the docker publish github aciton. It seems more flexible than docker hub. If taking g

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599852966 Did you notice that the docker container is now built via actions and stored in the GitHub package re

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-16 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599851653 > @liuguo09 Sorry this took me so long. Have a look at what I have done over here: > https://githu

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-15 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599307751 @btashton thanks, I'll look into it and feedback later.

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-15 Thread GitBox
btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599183244 @liuguo09 Sorry this took me so long. Have a look at what I have done over here: https://github

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #15: cibuild.sh: make sure git log print out the last commit

2020-03-12 Thread GitBox
xiaoxiang781216 merged pull request #15: cibuild.sh: make sure git log print out the last commit URL: https://github.com/apache/incubator-nuttx-testing/pull/15 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #15: cibuild.sh: make sure git log print out the last commit

2020-03-12 Thread GitBox
liuguo09 commented on issue #15: cibuild.sh: make sure git log print out the last commit URL: https://github.com/apache/incubator-nuttx-testing/pull/15#issuecomment-598066049 @xiaoxiang781216 @masayuki2009 please take a look. --

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #15: cibuild.sh: make sure git log print out the last commit

2020-03-12 Thread GitBox
liuguo09 opened a new pull request #15: cibuild.sh: make sure git log print out the last commit URL: https://github.com/apache/incubator-nuttx-testing/pull/15 Add 'git log -1' to make sure we know where the last commit is. Signed-off-by: liuhaitao --

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo

2020-03-07 Thread GitBox
liuguo09 opened a new pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo URL: https://github.com/apache/incubator-nuttx-testing/pull/14 Signed-off-by: liuhaitao This is an automated message from the

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-07 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-596146010 Sorry I don't remember very clearly. It seems in the workflow checkout stages, it mentioned to use 2.

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-06 Thread GitBox
liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-596034731 > @liuguo09 I'll make some detailed comments tonight. Including the multistage image which will resol

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-06 Thread GitBox
liuguo09 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r389218688 ## File path: docker/Dockerfile ## @@ -0,0 +1,34 @@ +FROM ubuntu:1

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-06 Thread GitBox
liuguo09 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r389218702 ## File path: docker/Dockerfile ## @@ -0,0 +1,34 @@ +FROM ubuntu:1

[GitHub] [incubator-nuttx-testing] btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-06 Thread GitBox
btashton commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-595823686 @liuguo09 I'll make some detailed comments tonight. Including the multistage image which will resolve

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r388753487 ## File path: docker/Dockerfile ## @@ -0,0 +1,34 @@ +FROM u

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#discussion_r388753286 ## File path: docker/Dockerfile ## @@ -0,0 +1,34 @@ +FROM u

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #13: docker: initial checkin Dockerfile for nuttx github action container

2020-03-05 Thread GitBox
liuguo09 opened a new pull request #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13 The corresponding docker image: docker pull liuguo09/ubuntu-nuttx:tagname Now it is temporarily use personal

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #12: cibuild.sh: use pushd/popd to make sure testlist path correctly

2020-03-04 Thread GitBox
xiaoxiang781216 merged pull request #12: cibuild.sh: use pushd/popd to make sure testlist path correctly URL: https://github.com/apache/incubator-nuttx-testing/pull/12 This is an automated message from the Apache Git Service

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #12: cibuild.sh: use pushd/popd to make sure testlist path correctly

2020-03-04 Thread GitBox
liuguo09 opened a new pull request #12: cibuild.sh: use pushd/popd to make sure testlist path correctly URL: https://github.com/apache/incubator-nuttx-testing/pull/12 Signed-off-by: liuhaitao This is an automated message fro

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #11: Split check testlist to enable multiple jobs in CI build

2020-03-04 Thread GitBox
xiaoxiang781216 merged pull request #11: Split check testlist to enable multiple jobs in CI build URL: https://github.com/apache/incubator-nuttx-testing/pull/11 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

2020-03-04 Thread GitBox
liuguo09 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build URL: https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387615991 ## File path: cibuild.sh ## @@ -174,11 +174,11 @@ function run_builds { loc

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

2020-03-04 Thread GitBox
liuguo09 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build URL: https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387615954 ## File path: cibuild.sh ## @@ -174,11 +174,11 @@ function run_builds { loc

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

2020-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build URL: https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387533561 ## File path: cibuild.sh ## @@ -174,11 +174,11 @@ function run_builds {

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build

2020-03-04 Thread GitBox
xiaoxiang781216 commented on a change in pull request #11: Split check testlist to enable multiple jobs in CI build URL: https://github.com/apache/incubator-nuttx-testing/pull/11#discussion_r387532564 ## File path: cibuild.sh ## @@ -174,11 +174,11 @@ function run_builds {

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #11: Split check testlist to enable multiple jobs in CI build

2020-03-03 Thread GitBox
liuguo09 opened a new pull request #11: Split check testlist to enable multiple jobs in CI build URL: https://github.com/apache/incubator-nuttx-testing/pull/11 In github action free version, up to 20 jobs could be run to speed up CI build. Signed-off-by: liuhaitao --

[GitHub] [incubator-nuttx-testing] Ouss4 merged pull request #10: Revert "fulllist: remove sim:mtdpart and sim:mtdrwb configs"

2020-02-29 Thread GitBox
Ouss4 merged pull request #10: Revert "fulllist: remove sim:mtdpart and sim:mtdrwb configs" URL: https://github.com/apache/incubator-nuttx-testing/pull/10 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #4: Add prebuilt gperf needed in kconfig-frontends configure

2020-02-27 Thread GitBox
xiaoxiang781216 commented on issue #4: Add prebuilt gperf needed in kconfig-frontends configure URL: https://github.com/apache/incubator-nuttx-testing/pull/4#issuecomment-591956401 Create a JIRA for gperf: https://issues.apache.org/jira/browse/INFRA-19896 --

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 opened a new pull request #10: Revert "fulllist: remove sim:mtdpart and sim:mtdrwb configs"

2020-02-27 Thread GitBox
xiaoxiang781216 opened a new pull request #10: Revert "fulllist: remove sim:mtdpart and sim:mtdrwb configs" URL: https://github.com/apache/incubator-nuttx-testing/pull/10 since INFRA fix this issue: https://github.com/apache/infrastructure-p6/pull/258 ---

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

2020-02-26 Thread GitBox
xiaoxiang781216 merged pull request #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs URL: https://github.com/apache/incubator-nuttx-testing/pull/9 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

2020-02-26 Thread GitBox
xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs URL: https://github.com/apache/incubator-nuttx-testing/pull/9#issuecomment-591387371 Let's wait INFRA fix libz.a issue and then revert this patch. ---

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

2020-02-26 Thread GitBox
xiaoxiang781216 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs URL: https://github.com/apache/incubator-nuttx-testing/pull/9#issuecomment-591387069 Reopen in INFRA project: https://issues.apache.org/jira/browse/INFRA-19890 ---

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

2020-02-26 Thread GitBox
liuguo09 commented on issue #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs URL: https://github.com/apache/incubator-nuttx-testing/pull/9#issuecomment-591381542 Issue a jira for Apache Infra to install lib32z1-dev: https://issues.apache.org/jira/browse/NUTTX-2 -

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs

2020-02-25 Thread GitBox
liuguo09 opened a new pull request #9: fulllist: remove sim:mtdpart and sim:mtdrwb configs URL: https://github.com/apache/incubator-nuttx-testing/pull/9 Remove sim:mtdpart and sim:mtdrwb configs since i386 libz not available now in Apache Jenkins slaves. Revert this change once i386 libz

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on issue #8: cibuild.sh: remove -si option since testbuild.sh updated

2020-02-18 Thread GitBox
xiaoxiang781216 commented on issue #8: cibuild.sh: remove -si option since testbuild.sh updated URL: https://github.com/apache/incubator-nuttx-testing/pull/8#issuecomment-587496156 Follow up this change: https://github.com/apache/incubator-nuttx/pull/298 ---

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #8: cibuild.sh: remove -si option since testbuild.sh updated

2020-02-18 Thread GitBox
xiaoxiang781216 merged pull request #8: cibuild.sh: remove -si option since testbuild.sh updated URL: https://github.com/apache/incubator-nuttx-testing/pull/8 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #8: cibuild.sh: remove -si option since testbuild.sh updated

2020-02-18 Thread GitBox
liuguo09 opened a new pull request #8: cibuild.sh: remove -si option since testbuild.sh updated URL: https://github.com/apache/incubator-nuttx-testing/pull/8 Since -si/sl options have been removed from testbuild.sh, so remove it here. Signed-off-by: liuhaitao ---

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

2020-02-12 Thread GitBox
maht commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-585334298 Well, not sure if the pipeline shared library can work from a subdirectory, according with documentation (https://jenkins.io/doc/book/pipeline/

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #2: Multibranch pipeline job example

2020-02-11 Thread GitBox
liuguo09 commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-584984210 That's good. Another thing I wonder if it is necessary for us to create a subdirectory jenkins to hold the pipeline job stuffs. And create

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

2020-02-11 Thread GitBox
maht commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-584760466 I pushed new versions of the commits. Now the main repository is checked out in `$WORKSPACE/nuttx` directory, at the same level as `apps` and `t

[GitHub] [incubator-nuttx-testing] maht commented on a change in pull request #2: Multibranch pipeline job example

2020-02-11 Thread GitBox
maht commented on a change in pull request #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377561623 ## File path: vars/runContinuousIntegrationPipeline.groovy ## @@ -0,0 +1,103 @@ +#!/usr/bin/env groovy + +/**

[GitHub] [incubator-nuttx-testing] maht commented on a change in pull request #2: Multibranch pipeline job example

2020-02-11 Thread GitBox
maht commented on a change in pull request #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377561127 ## File path: vars/runContinuousIntegrationPipeline.groovy ## @@ -0,0 +1,103 @@ +#!/usr/bin/env groovy + +/**

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #2: Multibranch pipeline job example

2020-02-11 Thread GitBox
liuguo09 commented on a change in pull request #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377536019 ## File path: vars/runContinuousIntegrationPipeline.groovy ## @@ -0,0 +1,103 @@ +#!/usr/bin/env groovy +

[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull request #2: Multibranch pipeline job example

2020-02-11 Thread GitBox
liuguo09 commented on a change in pull request #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#discussion_r377534899 ## File path: vars/runContinuousIntegrationPipeline.groovy ## @@ -0,0 +1,103 @@ +#!/usr/bin/env groovy +

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #7: cibuild.sh: decouple -b option to do run_builds only

2020-02-10 Thread GitBox
xiaoxiang781216 merged pull request #7: cibuild.sh: decouple -b option to do run_builds only URL: https://github.com/apache/incubator-nuttx-testing/pull/7 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #7: cibuild.sh: decouple -b option to do run_builds only

2020-02-09 Thread GitBox
liuguo09 opened a new pull request #7: cibuild.sh: decouple -b option to do run_builds only URL: https://github.com/apache/incubator-nuttx-testing/pull/7 1. In nuttx and apps PR check build, github action/jenkins/travis CI would checkout repos accordingly. So decouple -b option to do run

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #6: Get the full directory name of the cibuild.sh no matter where called …

2020-02-07 Thread GitBox
xiaoxiang781216 merged pull request #6: Get the full directory name of the cibuild.sh no matter where called … URL: https://github.com/apache/incubator-nuttx-testing/pull/6 This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #6: Get the full directory name of the cibuild.sh no matter where called …

2020-02-07 Thread GitBox
liuguo09 opened a new pull request #6: Get the full directory name of the cibuild.sh no matter where called … URL: https://github.com/apache/incubator-nuttx-testing/pull/6 …from Or it would fail to set nuttx/apps/tools/prebuilt dirs correctly when cibuild.sh is not called by 'cd

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #5: Call testbuild.sh with -x option to set it fail fast for check build …

2020-02-07 Thread GitBox
xiaoxiang781216 merged pull request #5: Call testbuild.sh with -x option to set it fail fast for check build … URL: https://github.com/apache/incubator-nuttx-testing/pull/5 This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx-testing] maht commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build …

2020-02-07 Thread GitBox
maht commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build … URL: https://github.com/apache/incubator-nuttx-testing/pull/5#issuecomment-583416500 it looks good ok to me This is an automa

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build …

2020-02-07 Thread GitBox
liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build … URL: https://github.com/apache/incubator-nuttx-testing/pull/5#issuecomment-583400349 Thanks. @maht @xiaoxiang781216 could you help review and merge if ok. ---

[GitHub] [incubator-nuttx-testing] Ouss4 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build …

2020-02-07 Thread GitBox
Ouss4 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build … URL: https://github.com/apache/incubator-nuttx-testing/pull/5#issuecomment-583382478 Hi @liuguo09 apache/incubator-nuttx#221 was merged.

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build …

2020-02-07 Thread GitBox
liuguo09 commented on issue #5: Call testbuild.sh with -x option to set it fail fast for check build … URL: https://github.com/apache/incubator-nuttx-testing/pull/5#issuecomment-583279728 This change also depends on https://github.com/apache/incubator-nuttx/pull/221.

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #5: Call testbuild.sh with -x option to set it fail fast for check build …

2020-02-07 Thread GitBox
liuguo09 opened a new pull request #5: Call testbuild.sh with -x option to set it fail fast for check build … URL: https://github.com/apache/incubator-nuttx-testing/pull/5 …error For PR check build, call testbuild.sh with -x option to set it fail fast if build error occured. Note

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #2: Multibranch pipeline job example

2020-02-07 Thread GitBox
liuguo09 commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583278543 > @davids5 I have not tested in builds.apache.org Jenkins, since I have no rights to create the pipeline job. I tested it on an external Jen

[GitHub] [incubator-nuttx-testing] patacongo commented on issue #2: Multibranch pipeline job example

2020-02-06 Thread GitBox
patacongo commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583058333 As an Apache project, we do have follow certain rules before bringing in any 3rd party software. I think we need a software grant now.

[GitHub] [incubator-nuttx-testing] davids5 commented on issue #2: Multibranch pipeline job example

2020-02-06 Thread GitBox
davids5 commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583018447 > Well, in theory, that should be true. In practice, usually not, as far as I have seen in all my career. Yes and No. I am sp

[GitHub] [incubator-nuttx-testing] patacongo commented on issue #2: Multibranch pipeline job example

2020-02-06 Thread GitBox
patacongo commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582917813 PX4 software is welcome provided that it is properly donated via a software grant, has an Apache 2 license, and goes through the same PR pr

[GitHub] [incubator-nuttx-testing] maht commented on issue #2: Multibranch pipeline job example

2020-02-05 Thread GitBox
maht commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582702122 > > Yes, regarding time concerns check option should take less time than full and can be shortened if needed by simply removing/commenting out s

  1   2   3   4   5   6   >