davids5 commented on issue #2: Multibranch pipeline job example
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583018447
 
 
   > Well, in theory, that should be true. In practice, usually not, as far as 
I have seen in all my career.
   
   Yes and No. 
   
    I am speaking about NuttX and building the board configs that are in the 
repo when a change affects an arch and the OS.  Dead CONFIG_xxxxx are just line 
dead code - not tested and not of value. 
   
   The build is broken when a board/config does not build. PR's should not 
break the build. - There is no wiggle room on this. If we need more coverage 
expand the configs for the board.
   
   Building an arch's boards (I,E STM32F7, STM32H7, imx etc) is how this is 
tested.
   
   Yes the test vectors blow up quick, but the baseline board configs should 
catch the untested and myopic PRs.
   
   >@davids5 I did not know the PX4 CI, but looks like very mature and curated. 
It would be wonderful to reuse as much from their know-how in our CI. 
   
   This was suggested along time ago, I was under the impression @liuguo09 was 
going to use it.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to