liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-599851653 > @liuguo09 Sorry this took me so long. Have a look at what I have done over here: > https://github.com/btashton/nuttx-build-containers > > The docker file is split into a bunch of stages which makes it a lot faster to rebuild and keeps the build time dependencies isolated from the rest of the image. Note that I am not downloading all of the toolchains now instead of copying local ones in. @btashton I notice it reduce half of time for pull the docker. It's really a good job. I totally agree with using a bunch of stages in Dockerfile to faster rebuild. Do we need a official nuttx build contianer repo or just include it in testing repo? > > I also have a github action wired up to that to create the docker image and place it in the github project package registry. Since now we are using our own account to create docker image, how about switch to the official https://hub.docker.com/u/apache to hold it? I have issued a Jira before https://issues.apache.org/jira/browse/INFRA-19930 and the Infra team have responded to help setup. And it required the nuttx committer permission to access. You may the right person to access as you are skilled in docker : ) > > On thing I think we should consider is using that structure to create images that each have the needed toolchains they are very large and the ARM builds should not be paying the cost of the RISCV, but I think this is a later improvement that can be made. If the time reduced not much now, I think it may be well to keep arm and riscv toolchains together now. But considering more toolchains coming for other archs, it may be reasonable to restructure in later improvement. > > You can see this integrated and running here: > https://github.com/btashton/incubator-nuttx/runs/508883969 > > Let me know how you think and we can look at moving it forward.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
