Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 2:50 AM Alan Carvalho de Assis wrote: > > Hi Xiang, > > Normally Greg, Abdelatif, I and others are fixing these nxstyles > issues when someone submit a patch. It is described in the legacy > process of merging PR: > https://acassis.wordpress.com/2020/01/02/the-old-way-nuttx-

Re: Apache 2.0 License headers in source files

Thanks Justin. I really appreciate the links to the presentations and docs. I'll check them out. :) -adam On Sat, Mar 7, 2020 at 8:28 PM Justin Mclean wrote: > Hi. > > I wold also read [1][2]. I have also given talks at ApacheCon on this, see > [3][4] for examples. Both [3] and I think [4] pred

Build failed in Jenkins: NuttX-Nightly-Build #57

See Changes: -- [...truncated 527.55 KB...] net_ipv4addr_hdrcopy(ipv4->srcipaddr, &dev->d_ipaddr); ^~~~ tcp/tcp_send.c:336:7: warning: dereferencing type-

Re: Apache 2.0 License headers in source files

Hi. I wold also read [1][2]. I have also given talks at ApacheCon on this, see [3][4] for examples. Both [3] and I think [4] predate the work in progress disclaimer, which makes it easier for you. Thanks, Justin 1. https://www.apache.org/legal/resolved.html 2. http://www.apache.org/dev/licensi

Re: Apache 2.0 License headers in source files

Justin, Thank you for the pointer to Brennan's email. I'll look more RAT once I understand more about what needs to be done with the licenses. cheers adam On Sat, Mar 7, 2020 at 7:13 PM Justin Mclean wrote: > Hi, > > > I tried using the mailing list search link you provided, but couldn't > fin

Re: Apache 2.0 License headers in source files

Brennan, Cool, thanks, I would like a login to the fossology server. I also don't exactly understand what needs to be done with the fossology reports... is there a wiki page or something that documents the process we need to follow? cheers adam On Sat, Mar 7, 2020 at 6:45 PM Brennan Ashton wrot

Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 2:46 AM David Sidrane wrote: > > -1 It is Not inline with long term goal and a violation of the Inviolable > David, No new violation here, the code modified in patch still must pass the coding style check, the tool just ignored the unmodified part. > o Expediency is not a

Re: Apache 2.0 License headers in source files

Hi, > I tried using the mailing list search link you provided, but couldn't find > any previous discussions. It defaults to 1 month old, try change to greater than 0 days or up the months to 4. Use advanced search and type “license" into the subject line. One of the first hits is [1]. Brennan h

Re: SPI controllers with 32bit transfer mode

Hi, Petro, I'm currently working on adding SPI driver for AM335X. The MCSPI controller of AM335X supports the transfer of up to 32-bits long SPI words. Currently, SPI driver in Nuttx supports up to 16-bits long words transfer. The attached patch extends it to 32-bit long words. I am not comf

Re: Apache 2.0 License headers in source files

Adam if you look back I have a hosted instance of it running for the project, no sense in duplicating the work. I'm happy to provide you an account. The nice thing about using this is that the reports can be shared publicly and we can use the proper flow of working through the identified license an

Re: SAMA5D27 SDMMC support branch

Cool. I'll see if I can work on the imxrt file then, in the branch I linked to above. cheers adam On Sat, Mar 7, 2020 at 6:15 PM Takeyoshi Kikuchi wrote: > Adam, > > Since standards are determined by SD assotication, I think that the > number of implementations according to the specifications h

Re: SAMA5D27 SDMMC support branch

Adam, Since standards are determined by SD assotication, I think that the number of implementations according to the specifications has increased recently. https://www.sdcard.org/downloads/pls/index.html Because it includes DMA, I found it by greping the register. Since the implementation of i

Re: SAMA5D27 SDMMC support branch

They do look like the same register sets. Thanks for the pointer to them. By the way, how did you find them...? :) I have to look at both files more closely... the Sony one is about 1400 lines longer, so they seem somewhat different from each other. Have you looked at these files at all? If so whi

Re: Should we relax precheck a little bit?

On Sat, Mar 7, 2020 at 4:30 PM Gregory Nutt wrote: > The acceptance test is this: > > You run the program against all .c and .h files under sched and the > output is 100% compatible with the input you win. One byte different > you lose. Hundreds hours have gone into this challenge and all have

Re: Apache 2.0 License headers in source files

Thanks Justin. I tried using the mailing list search link you provided, but couldn't find any previous discussions. (That Pony mailing list search tool is hard to use.) I also searched the archives with Google and only came up with a couple of messages from Greg saying that new files should have t

Re: Apache 2.0 License headers in source files

Hi, > Does Apache have a recommended way to use the Fossology tool as part of a > project? In general no but your setup is complex. > Or how a podling should use it? Generally they use RAT but that is defined for simpler situations. [1] It still good idea too use it as part of your release che

Re: Apache 2.0 License headers in source files

HI, Rather than having this discussion yet again, please look back through the archives [1] and see what has already been said on this subject (just search for license). Apache also has tools to help you with this, although given the complexity of what you have they may be of limited use. Than

Re: Should we relax precheck a little bit?

Since there's no current maintainer for nxstyle... What would people think about trying Clang-Format ? It's a well-used tool (LLVM, Google, Chromium, Mozilla, Webkit, and Microsoft ), and can

Re: Apache 2.0 License headers in source files

Justin, Ok, I installed Fossology on my personal workstation, and I verified the instance works and can scan the github.com/apache/incubator-nuttx repo. I am not sure how to use it or what the process of "clearing" software licenses is. Does Apache have a recommended way to use the Fossology tool

Re: Apache 2.0 License headers in source files

Justin, I installed a Fossology instance right now using Docker (the docker-compose version) and am running it against nuttx source code. I have never used fossology, but I'll post the results to the list if I can get an intelligible report out of it. :) cheers adam On Sat, Mar 7, 2020 at 5:27 A

Re: Should we relax precheck a little bit?

Since there's no current maintainer for nxstyle... What would people think about trying Clang-Format ? It's a well-used tool (LLVM, Google, Chromium, Mozilla, Webkit, and Microsoft ), and can be c

Re: Apache 2.0 License headers in source files

HI, > Brennan has made the initial report here: > https://fossology.brennanashton.com/repo/?mod=browse&show=quick&folder=2 > We can run Adam's tools and fossology iteratively utils all copyright > issue get resolved. Adam tool as it currently is will induce issues that will be harder to detect d

Re: SAMA5D27 SDMMC support branch

Thanks. I was on my phone last night and couldn't find the right files... I'll check out the ones you mentioned. cheers adam On Fri, Mar 6, 2020 at 10:33 PM Takeyoshi Kikuchi wrote: > No, > > In addition to the board-specific parts you implemented, we need to port > the code of nuttx/arch/arm/s

Re: Should we relax precheck a little bit?

+1 for fixing nxstyle (or configuring another tool like Clang Format ) That would make it a lot easier to submit PRs that are in the right format, at least :) There is no one dedicated to maintaining nxstyle right now.  I wrote the original*, but

Re: Should we relax precheck a little bit?

+1 for fixing nxstyle (or configuring another tool like Clang Format ) That would make it a lot easier to submit PRs that are in the right format, at least :) -adam On Sat, Mar 7, 2020 at 11:44 AM Gregory Nutt wrote: > But, on the other hand, in the

[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo

liuguo09 opened a new pull request #14: cibuild.sh: switch to use the recent bitbucket tools repo URL: https://github.com/apache/incubator-nuttx-testing/pull/14 Signed-off-by: liuhaitao This is an automated message from the

[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container

liuguo09 commented on issue #13: docker: initial checkin Dockerfile for nuttx github action container URL: https://github.com/apache/incubator-nuttx-testing/pull/13#issuecomment-596146010 Sorry I don't remember very clearly. It seems in the workflow checkout stages, it mentioned to use 2.

Re: Apache 2.0 License headers in source files

Hi Greg, I'm sorry for introducing the errors. I'm glad we found them even after the merge. Re: 1 and 2, if we want to keep using the tool, I can fix those errors. cheers adam On Sat, Mar 7, 2020 at 3:45 AM Gregory Nutt wrote: > I just reviewed the changes that your tool made via PR 449. The

Re: NuttX github action pull request check build CI enabled

That's right. I'll make PR to use Bitbucket tool repository. Gregory Nutt 于2020年3月8日周日 上午5:51写道： > I maintain only the Bitbucket tool repository. > > On 3/7/2020 4:44 PM, Abdelatif Guettouche wrote: > > Haitao, thank you for your hard work , and thanks to everyone who > > helped push this forwar

Re: NuttX github action pull request check build CI enabled

Abdelatif Guettouche 于2020年3月8日周日 上午5:49写道： > Haitao, thank you for your hard work , and thanks to everyone who > helped push this forward. > > I noticed one small thing. The cibuild.sh script uses the tools > repository from Github, I believe the one in Bitbucket is more recent. > I don't know w

Re: NuttX github action pull request check build CI enabled

I maintain only the Bitbucket tool repository. On 3/7/2020 4:44 PM, Abdelatif Guettouche wrote: Haitao, thank you for your hard work , and thanks to everyone who helped push this forward. I noticed one small thing. The cibuild.sh script uses the tools repository from Github, I believe the one i

Re: NuttX github action pull request check build CI enabled

Haitao, thank you for your hard work , and thanks to everyone who helped push this forward. I noticed one small thing. The cibuild.sh script uses the tools repository from Github, I believe the one in Bitbucket is more recent. I don't know which one we should continue to support and update, but I

Re: NuttX Networking capable of dual home?

Has anyone successfully set up a dual home (two IP addresses and subnets) on an Ethernet interface? Each network device has only a couple of IP address (well, a single IPv4 address and a single IPv6 address) and a router IP address.  But think that the functionality can be supported, but I

NuttX Networking capable of dual home?

Hello, Has anyone successfully set up a dual home (two IP addresses and subnets) on an Ethernet interface? Regards, -david

Re: Should we relax precheck a little bit?

But, on the other hand, in the future, wei will want the full checks enabled.  So it seems to me the options are: - Disable full checking temporarily and focus on eliminating the problems, or - Let things continue as they are.. accept a little pain and get things in shape. To me, there are n

Re: Should we relax precheck a little bit?

Hi Xiang, Normally Greg, Abdelatif, I and others are fixing these nxstyles issues when someone submit a patch. It is described in the legacy process of merging PR: https://acassis.wordpress.com/2020/01/02/the-old-way-nuttx-workflow/ I don't know if it is fair or unfair to share/transfer this resp

RE: Should we relax precheck a little bit?

-1 It is Not inline with long term goal and a violation of the Inviolable o Expediency is not a justification for violating the coding standard. -Original Message- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Saturday, March 07, 2020 10:11 AM To: dev@nuttx.apache.org Subject:

Should we relax precheck a little bit?

Hi all, The precheck ensure the whole file content comform to the coding style, this strategy has several problems: 1.Many source file in mainline already violate the coding style 2.nxstyle frequently generate the false alarm in the current stage How about we let precheck just ensure the modified l

NuttX github action pull request check build CI enabled

With efforts and reviews from community, the nuttx and apps github action pull request check build CI now take effect. To summarize, Github action CI workflow steps as below: a. Pull docker container with build essential tools preinstalled b. Clone nuttx, apps and testing repos c. Do check job:

SPI controllers with 32bit transfer mode

Hello, I'm currently working on adding SPI driver for AM335X. The MCSPI controller of AM335X supports the transfer of up to 32-bits long SPI words. Currently, SPI driver in Nuttx supports up to 16-bits long words transfer. The attached patch extends it to 32-bit long words. Regards, Petro Karashc

Re: Apache 2.0 License headers in source files

On Sat, Mar 7, 2020 at 9:27 PM Justin Mclean wrote: > > Hi, > > > For now, I think I think that you could just find all files that contain my > > Copyright (grep -rl "Gregory Nutt" *), and then make sure the word > > Copyright appears only once in the file (count=`grep Copyright $file1`; if > >

Re: Apache 2.0 License headers in source files

Hi, > For now, I think I think that you could just find all files that contain my > Copyright (grep -rl "Gregory Nutt" *), and then make sure the word Copyright > appears only once in the file (count=`grep Copyright $file1`; if [ $count -eq > 1 ]; then …) I would take care with this, copyright

Re: Apache 2.0 License headers in source files

2.Add an option to change the license for a particular author For now, I think I think that you could just find all files that contain my Copyright (grep -rl "Gregory Nutt" *), and then make sure the word Copyright appears only once in the file (count=`grep Copyright $file1`; if [ $count -e

Re: Apache 2.0 License headers in source files

We are in apache incubation phase more than 3 months, but it is very sad that we don't have any real progress in the copyright cleanup process. Adam's tools is a good start point, at least if we: 1.Fix the issue metioned by Greg 2.Add an option to change the license for a particular author Then, we

Re: Apache 2.0 License headers in source files

I just reviewed the changes that your tool made via PR 449.  They are bad and introduce errors into the program.  I have submitted PR469 to revert them. You tool is not mature enough and has not had sufficent review. Here are at least unacceptable errors introduced by the tool: 1. The to