+1 for fixing nxstyle (or configuring another tool like Clang Format <http://clang.llvm.org/docs/ClangFormat.html>)
That would make it a lot easier to submit PRs that are in the right format, at least :) -adam On Sat, Mar 7, 2020 at 11:44 AM Gregory Nutt <spudan...@gmail.com> wrote: > But, on the other hand, in the future, wei will want the full checks > enabled. So it seems to me the options are: > > - Disable full checking temporarily and focus on eliminating the > problems, or > - Let things continue as they are.. accept a little pain and get things > in shape. > > To me, there are no surprises here. I am rather masochistically > inclined to let things continue as the are but I appreciate the other > positions as well. > > I always try to apply good engineering judgement to the warnings/errors > from nxstyle and for a personal tool, it is served me we. But we are > not going to be able to expect a generic contributor to understand what > is a quirk in the tool and what is something that needs to be fixed. A > first good step would be to make sure that all nstyle issues are > properly documented in the github issuess. > > Greg > > On 3/7/2020 12:10 PM, Xiang Xiao wrote: > > Hi all, > > The precheck ensure the whole file content comform to the coding > > style, this strategy has several problems: > > 1.Many source file in mainline already violate the coding style > > 2.nxstyle frequently generate the false alarm in the current stage > > How about we let precheck just ensure the modified line don't violate > > the coding standards? > > I am asking this question because: > > 1.The change in PR 471 has a very good shape: > > https://github.com/apache/incubator-nuttx/pull/471/files > > but the whole file precheck complain there are many errors: > > > https://github.com/apache/incubator-nuttx/pull/471/checks?check_run_id=492244725 > > It is unfair to require the contributor to fix the issue not made by > them. > > 2.Most PR will fail at precheck stage due to item 1 and then block the > > more important build test. > > > > Thanks > > Xiang > > > -- Adam Feuer <a...@starcat.io>
