Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

tps://reviews.apache.org/r/14041/#comment50776> You can reuse ZkUtils.getPartitionAssignmentForTopics instead of writing a new function. - Swapnil Ghike On Sept. 9, 2013, 9:31 p.m., Guozhang Wang wrote: > > --- > This is a

Re: Review Request 14091: Patch for KAFKA-1053

after -r, or if should be --rb= - Swapnil Ghike On Sept. 13, 2013, 11:33 p.m., Neha Narkhede wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 14091: Patch for KAFKA-1053

091/#comment51047> Just one thing, I am not super comfortable having a password in a file in plain text. - Swapnil Ghike On Sept. 16, 2013, 3:28 a.m., Neha Narkhede wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26141 --- Ship it! Ship It! - Swapnil Ghike On Sept. 16, 2013, 3:28 a.m

Review Request 14149: test summary

/14149/diff/ Testing --- Thanks, Swapnil Ghike

Review Request 14161: Patch for KAFKA-1003

/browse/KAFKA-1003 Repository: kafka Description --- test Diffs - core/src/main/scala/kafka/producer/ProducerConfig.scala 7947b18aceb297f51adc0edcb1a11a447ca83e5f Diff: https://reviews.apache.org/r/14161/diff/ Testing --- Thanks, Swapnil Ghike

Re: Review Request 14041: Patch for KAFKA-1030

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26179 --- Ship it! Ship It! - Swapnil Ghike On Sept. 17, 2013, 6 p.m

Re: Review Request 14496: Patch for KAFKA-1073

ReassignPartitions tool itself with a "checkStatus" mode make sense in trunk? - Swapnil Ghike On Oct. 4, 2013, 9:33 p.m., Jun Rao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 14496: incorporating review feedback

<https://reviews.apache.org/r/14496/#comment52036> Instead of asking the user to store the output of a dryrun into a JSON file, should the tool compute the dryrun output and use it to perform validation ? - Swapnil Ghike On Oct. 5, 2013, 6:02 p.m., Jun Rao

Re: Review Request 14676: Patch for KAFKA-1091

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/#review27072 --- Ship it! Ship It! - Swapnil Ghike On Oct. 16, 2013, 5:19 p.m

Review Request 14771: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

--- Thanks, Swapnil Ghike

Re: Review Request 14771: Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t

://reviews.apache.org/r/14771/diff/ Testing (updated) --- Unit tests pass. Thanks, Swapnil Ghike

Review Request 14772: Configure reviewboard url in kafka-patch-review tool

/browse/KAFKA-1093 Repository: kafka Description --- configure reviewboard Diffs - kafka-patch-review.py 2653465a30a0084cbd37fa07d00e07134ef3bd7f Diff: https://reviews.apache.org/r/14772/diff/ Testing --- Thanks, Swapnil Ghike

Review Request 14773: Configure reviewboard url in kafka-patch-review tool

/browse/KAFKA-1094 Repository: kafka Description --- configure reviewboard Diffs - kafka-patch-review.py 2653465a30a0084cbd37fa07d00e07134ef3bd7f Diff: https://reviews.apache.org/r/14773/diff/ Testing --- Thanks, Swapnil Ghike

Re: Review Request 15137: Patch for KAFKA-1107

tps://reviews.apache.org/r/15137/#comment5> probably don't need this statement. - Swapnil Ghike On Oct. 31, 2013, 10:28 p.m., Neha Narkhede wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 15137: Patch for KAFKA-1107

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27989 --- Ship it! Ship It! - Swapnil Ghike On Oct. 31, 2013, 10:28 p.m

Review Request 15248: DumpLogSegments should print absolute file path while printing errors

/browse/KAFKA-1121 Repository: kafka Description --- dumplogseg Diffs - core/src/main/scala/kafka/tools/DumpLogSegments.scala 89b6cb1d0c3d9a1335184d0fc778246ce47738d3 Diff: https://reviews.apache.org/r/15248/diff/ Testing --- Thanks, Swapnil Ghike

Re: Review Request 15274: Patch for KAFKA-1119

--config config1=newVal --deleteConfig config2. - Swapnil Ghike On Nov. 6, 2013, 6:13 p.m., Neha Narkhede wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 15274: Patch for KAFKA-1119

tps://reviews.apache.org/r/15274/#comment55256> Should we enforce that configsToBeAdded and configsToBeDeleted should not contain the same config? - Swapnil Ghike On Nov. 7, 2013, 6:17 p.m., Neha Narkhede wrote: > > ---

Re: Review Request 15201: address more review comments

#comment55809> typo Another caveat seems to be that the tool cannot handle changes in 1. partition leadership change 2. topic configuration change (number of partitions). - Swapnil Ghike On Nov. 12, 2013, 4:34 p.m., Jun Rao wrote: > >

Re: Review Request 15201: address all review comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28873 --- Ship it! Ship It! - Swapnil Ghike On Nov. 14, 2013, 4:24 p.m

Review Request 15665: Code clean: use Json.encode() to write json data to zookeeper

c9ca95f1937d0ef2e64c70e4d811a0d4f358d9db core/src/main/scala/kafka/utils/ZkUtils.scala 856d13605b0b4bf86010571eacbacc0fb0ba7950 Diff: https://reviews.apache.org/r/15665/diff/ Testing --- Verified Thanks, Swapnil Ghike

Re: Review Request 15665: Code clean: use Json.encode() to write json data to zookeeper

://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper Thanks, Swapnil Ghike

Re: Review Request 15665: Patch for KAFKA-1135

zookeeper data looks like the structures defined in https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper Thanks, Swapnil Ghike

Re: Review Request 15665: Patch for KAFKA-1135

defined in https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper Thanks, Swapnil Ghike

Re: Review Request 15665: Patch for KAFKA-1135

automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/#review29116 ------- On Nov. 19, 2013, 3:21 a.m., Swapnil Ghike wrote: > > --- > This is an automatically ge

Re: Review Request 15665: Patch for KAFKA-1135

ble, so that when we > > upgrade in the future we only need to upgrade in once place? > > Swapnil Ghike wrote: > My understanding was that the code may evolve to deal with situations > wherein we have some zookeeper paths that are on version n, and others are on > ver

Re: Review Request 15711: Patch for KAFKA-930

57> Will it be simpler to have a per cluster config instead of a per broker config? i cant think of any downsides. - Swapnil Ghike On Nov. 20, 2013, 1:38 a.m., Sriram Subramanian wrote: > > --- > This is an automati

Review Request 15901: ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

e.org/r/15901/diff/ Testing --- Builds Thanks, Swapnil Ghike

Re: Review Request 15901: ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle leader == -1

scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15901/diff/ Testing (updated) --- Builds with all scala versions; unit tests pass Thanks, Swapnil Ghike

Re: Review Request 15901: Patch for KAFKA-1152

scala/kafka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15901/diff/ Testing --- Builds with all scala versions; unit tests pass Thanks, Swapnil Ghike

Review Request 15915: Patch for KAFKA-1152

fka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15915/diff/ Testing --- Thanks, Swapnil Ghike

Re: Review Request 15901: Patch for KAFKA-1152

ader == -1 Diffs (updated) - core/src/main/scala/kafka/server/ReplicaManager.scala 161f58134f20f9335dbd2bee6ac3f71897cbef7c Diff: https://reviews.apache.org/r/15901/diff/ Testing --- Builds with all scala versions; unit tests pass Thanks, Swapnil Ghike

Re: Review Request 15901: Patch for KAFKA-1152

-------- On Nov. 29, 2013, 6:41 a.m., Swapnil Ghike wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15901/ > -

Re: Review Request 16022: OfflinePartitionCount in JMX can be incorrect during controlled shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16022/#review29776 --- Ship it! Ship It! - Swapnil Ghike On Dec. 4, 2013, 11:42 p.m

sbt gen-idea issue

Hi everyone, We are having an issue with the new ./sbt gen-idea where some stuff shows up in red colour. We were wondering if the last sbt related checkin caused this and if anyone else is also facing this issue. If you have already solved this issue, would appreciate if you could tell us the s

Re: 0.8 build problems

Hi Derek, We probably have a patch for adding assembly at https://issues.apache.org/jira/browse/KAFKA-733. Can you review it? Thanks, Swapnil On 2/21/13 2:46 PM, "Derek Chen-Becker" wrote: >The two simplest approaches (short of parsing SBT output for classpaths) >would be to either use https:/

Please clean your ZK and Kafka data if you check out 0.8 HEAD

Hi all, Today we checked in a patch that standardizes Zookeeper data to use JSON format (KAFKA-755). If you plan to rebase or clone to use the HEAD of 0.8 branch, your next build will have changes to the way Zk data is read and written. This data

Re: Please clean your ZK and Kafka data if you check out 0.8 HEAD

If you are using the console consumer from the 0.8/bin directory then it should be automatically updated when you package the kafka jar. Is your console consumer using a separate kafka jar that did not possibly get updated when you did git pull? Thanks, Swapnil On 2/28/13 12:04 AM, "ben fleis" w

[jira] [Created] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

Swapnil Ghike created KAFKA-786: --- Summary: Use "withRequiredArg" while parsing jopt options in all tools Key: KAFKA-786 URL: https://issues.apache.org/jira/browse/KAFKA-786 Proj

[jira] [Commented] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592863#comment-13592863 ] Swapnil Ghike commented on KAFKA-786: - Also note that withRequiredArg() does not c

[jira] [Comment Edited] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592863#comment-13592863 ] Swapnil Ghike edited comment on KAFKA-786 at 3/5/13 12:4

[jira] [Assigned] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Swapnil Ghike (was: Sriram Subramanian) > Resolve bugs

[jira] [Assigned] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Sriram Subramanian (was: Swapnil Ghike) > Resolve bugs

[jira] [Updated] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-786: Attachment: kafka-786.patch Attached a patch. > Use "withRequiredAr

[jira] [Assigned] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-786: --- Assignee: Swapnil Ghike > Use "withRequiredArg" while parsing jopt options

[jira] [Updated] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-786: Attachment: kafka-786-v2.patch Jun raised a good question: What do we do for options like "

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v5.patch Thank you for the detailed suggestions, they were incredibly helpful

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v5-corrected.patch Does it work now? > Add state change

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595025#comment-13595025 ] Swapnil Ghike commented on KAFKA-513: - Thanks for making the corrections Neha.

[jira] [Updated] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-779: Attachment: kafka-779-v3.patch Patch v3: 1. Ok, not asking the user to provide version in both the

[jira] [Created] (KAFKA-793) Include controllerId in all requests sent by controller

Swapnil Ghike created KAFKA-793: --- Summary: Include controllerId in all requests sent by controller Key: KAFKA-793 URL: https://issues.apache.org/jira/browse/KAFKA-793 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-793) Include controllerId in all requests sent by controller

[ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-793: Labels: kafka-0.8 p1 (was: ) > Include controllerId in all requests sent by control

[jira] [Commented] (KAFKA-794) Clean up controller logging

[ https://issues.apache.org/jira/browse/KAFKA-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596142#comment-13596142 ] Swapnil Ghike commented on KAFKA-794: - This should wait till KAFKA-793 is checke

[jira] [Assigned] (KAFKA-793) Include controllerId in all requests sent by controller

[ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-793: --- Assignee: Swapnil Ghike > Include controllerId in all requests sent by control

[jira] [Updated] (KAFKA-793) Include controllerId in all requests sent by controller

[ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-793: Attachment: kafka-793-v1.patch Patch v1. Created a val for "state.change.logger" in Kafka

[jira] [Created] (KAFKA-795) Improvements to PreferredReplicaLeaderElection tool

Swapnil Ghike created KAFKA-795: --- Summary: Improvements to PreferredReplicaLeaderElection tool Key: KAFKA-795 URL: https://issues.apache.org/jira/browse/KAFKA-795 Project: Kafka Issue Type

[jira] [Created] (KAFKA-798) Use biased histograms instead of uniform histograms in KafkaMetricsGroup

Swapnil Ghike created KAFKA-798: --- Summary: Use biased histograms instead of uniform histograms in KafkaMetricsGroup Key: KAFKA-798 URL: https://issues.apache.org/jira/browse/KAFKA-798 Project: Kafka

[jira] [Updated] (KAFKA-798) Use biased histograms instead of uniform histograms in KafkaMetricsGroup

[ https://issues.apache.org/jira/browse/KAFKA-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-798: Attachment: kafka-798.patch One word fix. > Use biased histograms instead

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597831#comment-13597831 ] Swapnil Ghike commented on KAFKA-797: - Bob, are you using 0.8 HEAD? We did a bunc

[jira] [Commented] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597913#comment-13597913 ] Swapnil Ghike commented on KAFKA-779: - Jay had a great suggestion about combining

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598074#comment-13598074 ] Swapnil Ghike commented on KAFKA-797: - Bob, yes, if you cloned the repo two days

[jira] [Commented] (KAFKA-799) Infinite loop trying to start a broker

[ https://issues.apache.org/jira/browse/KAFKA-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598169#comment-13598169 ] Swapnil Ghike commented on KAFKA-799: - Hmm, I tried booting up zookeeper and a k

[jira] [Commented] (KAFKA-799) Infinite loop trying to start a broker

[ https://issues.apache.org/jira/browse/KAFKA-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598178#comment-13598178 ] Swapnil Ghike commented on KAFKA-799: - Yes, booting up a kafka 0.8 server after ha

[jira] [Updated] (KAFKA-799) Infinite loop trying to start a broker

[ https://issues.apache.org/jira/browse/KAFKA-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-799: Resolution: Not A Problem Assignee: Swapnil Ghike (was: Neha Narkhede) Status

[jira] [Commented] (KAFKA-798) Use biased histograms instead of uniform histograms in KafkaMetricsGroup

[ https://issues.apache.org/jira/browse/KAFKA-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599068#comment-13599068 ] Swapnil Ghike commented on KAFKA-798: - Yes, timer includes a biased histogra

[jira] [Commented] (KAFKA-686) 0.8 Kafka broker should give a better error message when running against 0.7 zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599208#comment-13599208 ] Swapnil Ghike commented on KAFKA-686: - How do we differentiate whether the 0.8 br

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v1.patch Copy pasting the comments from patch new-v1: 1. The leader&#

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Status: Patch Available (was: Open) > Add an option to replica from the largest offset dur

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v2.patch 1. Moved earliestOrLatestOffset to SimpleConsumer class

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v3.patch Since patch new-v2 has been committed, this patch contains diff

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v4.patch Modified ConsumerFetcherThread to use

[jira] [Created] (KAFKA-811) Fix clientId in migration tool

Swapnil Ghike created KAFKA-811: --- Summary: Fix clientId in migration tool Key: KAFKA-811 URL: https://issues.apache.org/jira/browse/KAFKA-811 Project: Kafka Issue Type: Bug Affects

[jira] [Updated] (KAFKA-811) Fix clientId in migration tool

[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-811: Attachment: kafka-811.patch > Fix clientId in migration t

[jira] [Updated] (KAFKA-811) Fix clientId in migration tool

[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-811: Status: Patch Available (was: Open) > Fix clientId in migration t

[jira] [Created] (KAFKA-813) Minor cleanup in Controller

Swapnil Ghike created KAFKA-813: --- Summary: Minor cleanup in Controller Key: KAFKA-813 URL: https://issues.apache.org/jira/browse/KAFKA-813 Project: Kafka Issue Type: Bug Affects Versions

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Description: Before starting work on delete topic support, uploading a patch first to address some

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v1.patch Unit tests pass. > Minor cleanup in Control

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606672#comment-13606672 ] Swapnil Ghike commented on KAFKA-813: - @Neha: 2. If the target state is

[jira] [Updated] (KAFKA-811) Fix clientId in migration tool

[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-811: Attachment: kafka-811-v2.patch Can we check in this patch ? The 1st one had a real stupid mistake

[jira] [Comment Edited] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606672#comment-13606672 ] Swapnil Ghike edited comment on KAFKA-813 at 3/19/13 7:0

[jira] [Commented] (KAFKA-811) Fix clientId in migration tool

[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606683#comment-13606683 ] Swapnil Ghike commented on KAFKA-811: - The 1st patch will pass client ids like a

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v2.patch Addressing comments: [~junrao]: 1. Renamed the exception to

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Priority: Blocker (was: Major) > Minor cleanup in Control

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Labels: kafka-0.8 (was: ) > Minor cleanup in Control

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608130#comment-13608130 ] Swapnil Ghike commented on KAFKA-813: - A couple of comments/questions before uploa

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v3.patch Patch v3 takes care of the comments made above

[jira] [Comment Edited] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608564#comment-13608564 ] Swapnil Ghike edited comment on KAFKA-330 at 3/21/13 2:4

[jira] [Commented] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608564#comment-13608564 ] Swapnil Ghike commented on KAFKA-330: - Delete topic admin patch schema update

[jira] [Created] (KAFKA-822) Reassignment of partitions needs a cleanup

Swapnil Ghike created KAFKA-822: --- Summary: Reassignment of partitions needs a cleanup Key: KAFKA-822 URL: https://issues.apache.org/jira/browse/KAFKA-822 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-821) specifying a non-existent partition to ./bin/kafka-reassign-partitions.sh breaks all reassignment ops

[ https://issues.apache.org/jira/browse/KAFKA-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609713#comment-13609713 ] Swapnil Ghike commented on KAFKA-821: - We can make this a sub-task of KAFKA-82

[jira] [Updated] (KAFKA-822) Reassignment of partitions needs a cleanup

[ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-822: Description: 1. This is probably a left-over from when the ReassignPartitionsCommand used to be

[jira] [Updated] (KAFKA-822) Reassignment of partitions needs a cleanup

[ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-822: Assignee: Swapnil Ghike (was: Neha Narkhede) > Reassignment of partitions needs a clea

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610100#comment-13610100 ] Swapnil Ghike commented on KAFKA-813: - 30. port has been included to main

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v4.patch Thanks for pointing that out. Attached patch v4. When the leader

[jira] [Commented] (KAFKA-822) Reassignment of partitions needs a cleanup

[ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612355#comment-13612355 ] Swapnil Ghike commented on KAFKA-822: - Listing additional changes: 6. On the crea

[jira] [Created] (KAFKA-828) Preferred Replica Election does not delete the admin on controller failover

Swapnil Ghike created KAFKA-828: --- Summary: Preferred Replica Election does not delete the admin on controller failover Key: KAFKA-828 URL: https://issues.apache.org/jira/browse/KAFKA-828 Project: Kafka

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Summary: Preferred Replica Election does not delete the admin path on controller failover (was

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Attachment: kafka-828-v1.patch 1. Moving removePartitionsFromPreferredReplicaElection() to

[jira] [Updated] (KAFKA-814) Controller should not throw exception when a preferred replica is already the leader for a partition

[ https://issues.apache.org/jira/browse/KAFKA-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-814: Issue Type: Sub-task (was: Bug) Parent: KAFKA-828 > Controller should not th

  1   2   3   4   5   >