> On Dec. 2, 2013, 5:06 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 358 > > <https://reviews.apache.org/r/15901/diff/3/?file=392523#file392523line358> > > > > the check should probably be leaderId >= 0. The "leaders" in the > > LeaderAndIsrRequest is misleading, cannot be trusted and needs to be > > deprecated.
On the controller, leaders exclude shutdown brokers. val leaders = controllerContext.liveOrShuttingDownBrokers.filter(b => leaderIds.contains(b.id)) On the broker, should we not check whether the leader that it is being asked to follow is alive or not? - Swapnil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/#review29588 ----------------------------------------------------------- On Nov. 29, 2013, 6:41 a.m., Swapnil Ghike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15901/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2013, 6:41 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1152 > https://issues.apache.org/jira/browse/KAFKA-1152 > > > Repository: kafka > > > Description > ------- > > ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle > leader == -1 > > > ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle > leader == -1 > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 161f58134f20f9335dbd2bee6ac3f71897cbef7c > > Diff: https://reviews.apache.org/r/15901/diff/ > > > Testing > ------- > > Builds with all scala versions; unit tests pass > > > Thanks, > > Swapnil Ghike > >
