----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27989 -----------------------------------------------------------
Ship it! Ship It! - Swapnil Ghike On Oct. 31, 2013, 10:28 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15137/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 10:28 p.m.) > > > Review request for kafka and Jay Kreps. > > > Bugs: KAFKA-1107 > https://issues.apache.org/jira/browse/KAFKA-1107 > > > Repository: kafka > > > Description > ------- > > Remove whitespace changes to LogTest > > > Removed an unncessary log statement and fixed a few more tests that initially > had the Log public API change > > > Per Jay's suggestion, avoid changing the public API of Log > > > Avoid printing clean shutdown file log message on every log > > > KAFKA-1107 Broker unnecessarily recovers all logs when upgrading from 0.8 to > 0.8.1; Fix includes modifying Log to avoid recovery if the clean shutdown > file exists; LogManager deletes the clean shutdown file after all logs in a > log directory have finished loading; If the clean shutdown file does not > exist, fall back to 0.8.1 recovery logic > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0cc402b13e8484ae5569f1b8ff7156331a2f82d7 > core/src/main/scala/kafka/log/LogManager.scala > d489e08452ab97334d504f76f381eb314ec56901 > core/src/test/scala/unit/kafka/log/LogTest.scala > 140317c6ab6741308d125e9c1f43078b672c5f95 > > Diff: https://reviews.apache.org/r/15137/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
