----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26115 -----------------------------------------------------------
kafka-patch-review.py <https://reviews.apache.org/r/14091/#comment50967> Should we make it default to the current branch? kafka-patch-review.py <https://reviews.apache.org/r/14091/#comment50966> This is definitely useful. But I can specify versions out of order and confuse the reviewer. Is it possible to read the versions attached on the JIRA, and auto-increment the latest version by one? Wondering if there is a jira.get_attachments() function.. kafka-patch-review.py <https://reviews.apache.org/r/14091/#comment50968> Do you intend to save the patch file in current directory? I wonder if we should delete it, because it is more of a side effect with this tool. kafka-patch-review.py <https://reviews.apache.org/r/14091/#comment50970> p should be closed. kafka-patch-review.py <https://reviews.apache.org/r/14091/#comment50969> Not sure if there should be a space after -r, or if should be --rb= - Swapnil Ghike On Sept. 13, 2013, 11:33 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14091/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 11:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1053 > https://issues.apache.org/jira/browse/KAFKA-1053 > > > Repository: kafka > > > Description > ------- > > Included Guozhang's suggestion about making --version mandatory if --rb is > specified > > > Included Guozhang's suggestion about making --version mandatory if --rb is > specified > > > Attaching file using jira-python package > > > Changed the script to use the jira-python package, part 2 > > > Changed the script to use the jira-python package > > > Changed the creating a reviewboard comment as suggested by Tejas > > > Included Tejas's comments > > > Changed the post-review tool to publish the rb automatically. Updated the > tool to add a link to the rb in the JIRA > > > publish automatically > > > Patch review tool > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > kafka-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14091/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
