Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-10-09 Thread Nikolay Izhikov
/apache/kafka/pull/5759#issuecomment-428242210 > > Thanks, > -John > > On Mon, Sep 24, 2018 at 3:44 PM Nikolay Izhikov wrote: > > > Hello, John. > > > > Tests in my PR is green now. > > Please, do the review. > > > > https://github.com/apache/k

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-10-09 Thread Nikolay Izhikov
+API+to+Duration+instead+of+long+ms+times В Ср, 10/10/2018 в 01:16 +0300, Nikolay Izhikov пишет: > Hello, John > > I responded in discussion thread. > > I'm +1 for your proposal. > > В Вт, 09/10/2018 в 13:05 -0500, John Roesler пишет: > > Hi Nikolay, > >

KAFKA-6144(or other ticket to resolve)

2018-12-03 Thread Nikolay Izhikov
Hello, Kafka developers. I found the link to a KAFKA-6144 in youtube video [1] Gwen, Matthias, great video by the way :) I want to know - is this ticket actual for the Kafka product? Are commiters and other community members are interested in it's resolve? It unassigned for now and I want to wo

Re: KAFKA-6144(or other ticket to resolve)

2018-12-04 Thread Nikolay Izhikov
ons, and proposes desired semantics and how > developers would use this feature. As a second step, we can think about > implementation details. > > How does this sound? > > > -Matthias > > On 12/3/18 11:27 PM, Nikolay Izhikov wrote: > > Hello, Kafka developers. >

Tests to emulate leader change(investigation of KAFKA-7680)

2018-12-23 Thread Nikolay Izhikov
Hello, Guys. I started investigating of KAFKA-7680 [1] Jun Rao wrote that this issue can be reproduced with leader change. Please, give me the advice. How can I emulate leader change in tests? Do we have some existing tests I can look into? [1] https://issues.apache.org/jira/browse/KAFKA-7680

Contributing to Apache Kafka

2018-05-25 Thread Nikolay Izhikov
Hello, guys! I want to contribute to Apache Kafka. Please, give me permission to assign jira ticket to myself. My Jira ID - NIzhikov signature.asc Description: This is a digitally signed message part

Help with first contribution

2018-06-28 Thread Nikolay Izhikov
Hello, guys. I'm experienced java/scala engineer. I want to contribute to kafka. I read the documentation and look over jira tickets. Seems it's not easy to find a right issue to start contributing with. Can you, please, suggest some ticket(s) or JIRA filters I can take and solve. signature.asc

Re: Help with first contribution

2018-06-28 Thread Nikolay Izhikov
As with label "newbie" or "beginner"? What > component of Kafka do you want to work on/interests you most? > > > -Matthias > > On 6/28/18 3:20 AM, Nikolay Izhikov wrote: > > Hello, guys. > > > > I'm experienced java/scala engineer. >

Re: Help with first contribution

2018-07-01 Thread Nikolay Izhikov
Hello, Matthias. Thank you! I took this ticket. В Вс, 01/07/2018 в 18:10 -0700, Matthias J. Sax пишет: > How about this: https://issues.apache.org/jira/browse/KAFKA-7125 > > -Matthias > > On 6/28/18 8:31 AM, Nikolay Izhikov wrote: > > Hello, Matthias! > > > >

Permission to create KIP

2018-08-13 Thread Nikolay Izhikov
Hello, Guys. I want to create KIP for ticket [1]. Please, give me sufficient permissions. My JIRA ID - nizhikov. [1] https://issues.apache.org/jira/browse/KAFKA-7277 signature.asc Description: This is a digitally signed message part

[DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-16 Thread Nikolay Izhikov
Hello, Kafka developers. I would like to start a discussion of KIP-358 [1]. It based on a ticket KAFKA-7277 [2]. I crawled through Stream API and made my suggestions for API changes. I have several questions about changes. Please, share your comments: 1. I propose do not remove existing API met

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-19 Thread Nikolay Izhikov
rval should also be durations. > > 9. In StreamsMetrics, recordLatency could be just a Duration, but I > actually think this one is better left alone. IMO, it's more effort for > little gain to require users to construct a Duration before they call the > method, since they vary lik

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-20 Thread Nikolay Izhikov
type. For getter methods, we don't > use get as prefix (as least for new code). > > Cheers > > On Sun, Aug 19, 2018 at 8:03 AM Nikolay Izhikov wrote: > > > Hello, John. > > > > Thank you very much for your feedback! > > I've addressed all your comme

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-21 Thread Nikolay Izhikov
> > On Mon, Aug 20, 2018 at 12:39 PM Nikolay Izhikov > wrote: > > > Hello, Ted. > > > > Thanks for the comment. > > > > I've edit KIP and change proposal to `windowSize`. > > > > Guys, any other comments? > > > >

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-23 Thread Nikolay Izhikov
> - SessionStore#findSessions() (2x) > > Thus, it might make sense to keep old and just add new ones? End users > can use the "nicer" new ones, while we can still use the existing ones > internally? Not sure if it would be possible to keep the old ones > without exp

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-27 Thread Nikolay Izhikov
ow it looks: > > > > > > > > public abstract class Windows { > > > > public abstract Map windowsFor(final long timestamp); > > > > public abstract long size(); > > > > public abstract long gracePeriodMs(); > > > > } > > &

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-28 Thread Nikolay Izhikov
Hello, I want to start VOTE for this KIP today. Any objections? В Пн, 27/08/2018 в 10:20 +0300, Nikolay Izhikov пишет: > Hello, Matthias, John. > > Thanks in advance. > > > I wanted to let you know that we have dropped the `grace(long)` method from > > the Windows in

[VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-29 Thread Nikolay Izhikov
Hello, All. Calling a vote on KIP-358 [1] [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-358%3A+Migrate+Streams+API+to+Duration+instead+of+long+ms+times signature.asc Description: This is a digitally signed message part

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-30 Thread Nikolay Izhikov
ussion possible. In > general, to justify some of those comments, it's easier to add missing > methods later on than to remove them, so I'm erring on the side of only > adding new variants when they show up in DSL code, not worrying about the > lower-level APIs. > > What do

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-30 Thread Nikolay Izhikov
e, it looks good to me! > > Thanks so much, > -John > > On Thu, Aug 30, 2018 at 5:30 AM Nikolay Izhikov wrote: > > > Hello, John. > > > > I've updated KIP according on your comments. > > Please, take a look. > > > > Are we ready to vot no

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-30 Thread Nikolay Izhikov
the dual use methods? Or does that imply > we'll strive for more clear delineation between DSL and internal use? > > Thanks, > Bill > > > > On Thu, Aug 30, 2018 at 5:59 PM Nikolay Izhikov wrote: > > > John, thank you. > > > > I've

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-08-31 Thread Nikolay Izhikov
we'll be in a > better position to see what else can/should be done, and we can talk about > follow-on work at that time. > > Thanks for the clarification, > -John > > On Fri, Aug 31, 2018 at 1:19 AM Nikolay Izhikov wrote: > > > Hello, Bill > > > >

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-03 Thread Nikolay Izhikov
018 at 11:09 AM Bill Bejeck wrote: > > > Hi Nickolay, > > > > Thanks for the clarification. > > > > -Bill > > > > On Fri, Aug 31, 2018 at 11:59 AM Nikolay Izhikov > > wrote: > > > > > Hello, John. > > > > >

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-05 Thread Nikolay Izhikov
> > public abstract long size(); > > > > public abstract long gracePeriodMs(); > > > > } > > > > > > > > Notice that there is no part of this involved with the DSL. When you're > > > > writing a topology, you don

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-07 Thread Nikolay Izhikov
t; (\cc John)? > > > Thanks, > > -Matthias > > > > ps: there are many KIPs in-flight in parallel, and it takes some time to > get around. Please be patient :) > > > > > On 9/5/18 12:25 AM, Nikolay Izhikov wrote: > > Hello, Guys. > &g

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-10 Thread Nikolay Izhikov
> > ReadOnlyWindowStores, and WindowStore is only used *internally*, so it's > > free to offer `long` methods if needed for performance reasons. > > > > Does this make sense? The same reasoning extends to the other stores. > > > > (4) Yes, that was my suggestion. I'

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-11 Thread Nikolay Izhikov
high punctuation frequency creating a new > > instance of Instant may be costly. > > > > 2) I'm fine with keeping KeyValueStore extending ReadOnlyKeyValueStore with > > APIs of `long` as well as inheriting APIs of `Duration`. > > > > > > Guozhang &g

Re: [ANNOUNCE] Kafka Committers Guidelines

2018-09-11 Thread Nikolay Izhikov
Hello, guys. Can you, please, share non trivial tickets(improvement ideas) that waiting for a brave contributor? Which area of documentation needs to be improved? пн, 10 сент. 2018 г., 10:53 Dongjin Lee : > Comprehensive, Clear and Helpful. Thanks for your great work! > > Best, > Dongjin > > On

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-12 Thread Nikolay Izhikov
Note, that a `Processor` would use the "read-write" > interfaces and thus, we can add the more efficient read methods using > `long` there. > > Does this make sense? > > > -Matthias > > On 9/11/18 12:20 AM, Nikolay Izhikov wrote: > > Hello, Guozhang, Bi

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Nikolay Izhikov
gt; > > Yes, the changes we discussed for ReadOnlyXxxStore and XxxStore should be > > in this KIP. > > > > And you're right, it seems like ReadOnlySessionStore is not necessary to > > touch, since it doesn't reference any `long` timestamps. > > > >

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Nikolay Izhikov
> > long timeTo); > > KeyValueIterator, V> fetchAll(long timeFrom, long timeTo); > > } > > Ie, long-versions are replaced with Instant/Duration in > `ReadOnlyWindowStore`, and `long` method are added in `WindowStore` -- > this way, we effectively "move&q

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-16 Thread Nikolay Izhikov
t; > > > Ie, long-versions are replaced with Instant/Duration in > > `ReadOnlyWindowStore`, and `long` method are added in `WindowStore` -- > > this way, we effectively "move" the long-versions from > > `ReadOnlyWindowStore` to `WindowStore`. > > >

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-17 Thread Nikolay Izhikov
J. Sax > wrote: > > > Thanks for the KIP. > > > > +1 (binding) > > > > > > -Matthias > > > > On 9/5/18 8:52 AM, John Roesler wrote: > > > I'm a +1 (non-binding) > > > > > > On Mon, Sep 3, 2018 at 8:33 AM N

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-17 Thread Nikolay Izhikov
ng your pr *merged* for 2.1 is _October 1st_, > so you basically have 2 weeks to send the PR, have the reviews, and get it > merged. > > (see > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=91554044) > > Thanks again, > -John > > On Mon, S

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-22 Thread Nikolay Izhikov
Hello I've opened a PR [1] for this KIP. [1] https://github.com/apache/kafka/pull/5682 John, can you take a look? В Пн, 17/09/2018 в 20:16 +0300, Nikolay Izhikov пишет: > John, > > Got it. > > Will do my best to meet this deadline. > > В Пн, 17/09/2018 в 11:52

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-24 Thread Nikolay Izhikov
ohn > > On Sat, Sep 22, 2018 at 2:36 AM Nikolay Izhikov wrote: > > > Hello > > > > I've opened a PR [1] for this KIP. > > > > [1] https://github.com/apache/kafka/pull/5682 > > > > John, can you take a look? > > > >

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-24 Thread Nikolay Izhikov
Hello, John. Tests in my PR is green now. Please, do the review. https://github.com/apache/kafka/pull/5682 В Пн, 24/09/2018 в 20:36 +0300, Nikolay Izhikov пишет: > Hello, John. > > Thank you. > > There are failing tests in my PR. > I'm fixing them wright now. > >

KIP-358: Merge required

2018-10-02 Thread Nikolay Izhikov
Hello, Kafka commiters. I've implemented KIP-358 [1] My PR [2] accepted by John Roesler and Bill Bejeck. Tests passed. Can you merge it to the trunk? [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-358%3A+Migrate+Streams+API+to+Duration+instead+of+long+ms+times [2] https://github.com

KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-09-16 Thread Nikolay Izhikov
Hello, Kafka team. I implemented KAFKA-8584 [1]. PR - [2] Please, do the review. [1] https://issues.apache.org/jira/browse/KAFKA-8584 [2] https://github.com/apache/kafka/pull/7342 signature.asc Description: This is a digitally signed message part

Re: KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-09-19 Thread Nikolay Izhikov
oduct. Please, let me know, what do you think. В Вт, 17/09/2019 в 01:52 +0300, Nikolay Izhikov пишет: > Hello, Kafka team. > > I implemented KAFKA-8584 [1]. > PR - [2] > Please, do the review. > > [1] https://issues.apache.org/jira/browse/KAFKA-8584 > [2] https://gith

[DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Nikolay Izhikov
All, I'd like to start a discussion for adding a NothingSerde to Serdes. https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+NothingSerde+to+Serdes Your comments and suggestions are welcome. signature.asc Description: This is a digitally signed message part

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Nikolay Izhikov
Hello, Andrew. Seems, usage null or nothing is matter of taste. I dont mind if we call it NullSerde чт, 19 сент. 2019 г., 20:28 Andrew Otto : > Why 'NothingSerdes' instead of 'NullSerdes'? > > On Thu, Sep 19, 2019 at 1:10 PM Nikolay Izhikov > wrote: > &

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-19 Thread Nikolay Izhikov
Hello, Andrew. OK, if nobody mind, let's change it to Null. В Чт, 19/09/2019 в 13:54 -0400, Andrew Otto пишет: > NullSerdes seems more descriptive, but up to you! :) > > On Thu, Sep 19, 2019 at 1:37 PM Nikolay Izhikov wrote: > > > Hello, Andrew. > > > &

Re: KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-09-20 Thread Nikolay Izhikov
Hello, all. Any feedback on this? Do we need support of ByteBuffer in RPC generated code? Which PR should be reviwed and merged? В Чт, 19/09/2019 в 10:11 +0300, Nikolay Izhikov пишет: > Hello, guys. > > Looks like we have duplicate tickets and PR's here. > > One from

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-23 Thread Nikolay Izhikov
Hello, guys Any additional feeback on this KIP? Should I start a vote? В Пт, 20/09/2019 в 08:52 +0300, Nikolay Izhikov пишет: > Hello, Andrew. > > OK, if nobody mind, let's change it to Null. > > В Чт, 19/09/2019 в 13:54 -0400, Andrew Otto пишет: > > NullSerdes seem

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-24 Thread Nikolay Izhikov
> > Because the actually data type is `Void`, I am wondering if `VoidSerde` > > might be a more descriptive name? > > > > -Matthias > > > > On 9/23/19 12:25 PM, Nikolay Izhikov wrote: > > > Hello, guys > > > > > > Any additional feeback o

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-28 Thread Nikolay Izhikov
Hello. Any additional comments? Should I start a vote for this KIP? В Вт, 24/09/2019 в 16:20 +0300, Nikolay Izhikov пишет: > Hello, > > KIP [1] updated to VoidSerde. > > [1] > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes > > &g

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-09-30 Thread Nikolay Izhikov
ternative in the KIP is rather a workaround than a > rejected alternative. IMO it would be better to instead list the > rejected names for the Serde there if anything. > > Best, > Bruno > > On Sat, Sep 28, 2019 at 1:42 PM Nikolay Izhikov wrote: > > > > Hello. > >

[VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-01 Thread Nikolay Izhikov
Hello. I would like to start vote for KIP-527: Add VoidSerde to Serdes KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes Discussion thread - https://lists.apache.org/thread.html/e6f95799898cc5d6e7d44dfd3fc2206117feb384a0a229a1c781ecd4@%3Cdev.kafka.apache

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-06 Thread Nikolay Izhikov
Hello, Any additional feedback on this? Do we need this in Kafka? В Ср, 02/10/2019 в 08:30 +0200, Bruno Cadonna пишет: > Hi Nikolay, > > Thank you for the KIP! > > +1 (non-binding) > > Best, > Bruno > > On Tue, Oct 1, 2019 at 5:57 PM Nikolay Izhikov wrote: &g

Re: KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-10-07 Thread Nikolay Izhikov
ll take a > look at your PR today and see if we can get it into shape for what we need. > > best, > Colin > > On Fri, Sep 20, 2019, at 09:18, Nikolay Izhikov wrote: > > Hello, all. > > > > Any feedback on this? > > Do we need support of ByteBuffer in

KAFKA-8104: Help with the fair reproducer and review

2019-10-07 Thread Nikolay Izhikov
Hello. We have KAFKA-8104 "Consumer cannot rejoin to the group after rebalancing" [1] issue. It reproduces on many production environments. I prepared reproducer and fix [2] for this issue. But, I need assistance with the "fair" reproducer. Please, help me with the review and "fair" reproducer:

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-08 Thread Nikolay Izhikov
9 PM Bill Bejeck wrote: > > > Thanks for the KIP. > > > > +1(binding) > > > > -Bill > > > > On Mon, Oct 7, 2019 at 5:57 PM Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > > > > -Matthias &

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-09 Thread Nikolay Izhikov
; Thanks, I'm +1 (binding). > > On Tue, Oct 8, 2019 at 2:33 AM Nikolay Izhikov wrote: > > > Hello, Guozhang. > > > > Following added to the KIP: > > > > > If not null parameters passed then an java.lang.IllegalArgumentException > > > >

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-10-10 Thread Nikolay Izhikov
new classes? > > > > -Matthias > > On 9/30/19 9:26 AM, Nikolay Izhikov wrote: > > Hello, Bruno. > > > > Thanks for feedback. > > KIP [1] updated according to your comments. > > > > [1] > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3

Re: KAFKA-8104: Help with the review

2019-10-14 Thread Nikolay Izhikov
21:37 +0300, Nikolay Izhikov пишет: > Hello. > > We have KAFKA-8104 "Consumer cannot rejoin to the group after rebalancing" > [1] issue. > It reproduces on many production environments. > > I prepared reproducer and fix [2] for this issue. > But, I need ass

Re: KAFKA-8104: Help with the review

2019-10-14 Thread Nikolay Izhikov
ll try to make another pass on it asap. > > > Guozhang > > On Mon, Oct 14, 2019 at 12:46 PM Nikolay Izhikov > wrote: > > > Hello. > > > > I got very helpfull advices from guozhang. > > And now, we have a ready fix and reproducer. > > > &g

Re: [DISCUSS] KIP-527: Add NothingSerde to Serdes

2019-10-16 Thread Nikolay Izhikov
Hello. I've got PR accepted by the Sophie Blee-Goldman. Tests are green. Please, others committers join the review. чт, 10 окт. 2019 г. в 16:52, Nikolay Izhikov : > Hello. > > This KIP was accepted. > > I created PR [1] for it. > Please, review. > > [1] https:/

Re: KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-10-17 Thread Nikolay Izhikov
42 [2] https://issues.apache.org/jira/browse/KAFKA-8885 пн, 7 окт. 2019 г. в 10:08, Nikolay Izhikov : > Hello. > > Please, review my changes [1] > I fixed all conflicts after KAFKA-8885 [2] merge [3]. > > [1] https://github.com/apache/kafka/pull/7342 > [2] https://issues.apache.

Re: [VOTE] KIP-527: Add VoidSerde to Serdes

2019-10-18 Thread Nikolay Izhikov
Hello. This KIP adopted by commit - https://github.com/apache/kafka/commit/4e094217f7360becd3640a38587e25f9a3bfd4b3 Thanks Sophie and Matthias for the review and merge. Thanks Guozhang, Bill, Matthias, Bruno for the votes and feedback. В Ср, 09/10/2019 в 15:55 +0300, Nikolay Izhikov пишет

Re: KAFKA-8584: Support of ByteBuffer for bytes field implemented[Convert Kafka RPCs to use automatically generated code]

2019-10-23 Thread Nikolay Izhikov
your changes on top of trunk, rather > than merging trunk into your branch? It is difficult to follow which changes > are yours and which come from the merge, when you do it the other way. > > best, > Colin > > > On Thu, Oct 17, 2019, at 02:59, Nikolay Izhikov wrote: > &

Re: Running system tests on mac

2020-06-29 Thread Nikolay Izhikov
Hello, I successfully run system tests on Mac with Docker. I followed the instruction on [1] and it works like a charm. [1] https://github.com/apache/kafka/tree/trunk/tests#running-tests-using-docker > 29 июня 2020 г., в 12:14, Gokul Ramanan Subramanian > написал(а): > > Hi. > > Has anyone

Re: Running system tests on mac

2020-06-29 Thread Nikolay Izhikov
t think I am running low on resources. > > Is this common? At this rate, the tests would take about 2 days to complete > and there'd probably be lots of failures. > > On Mon, Jun 29, 2020 at 11:21 AM Gokul Ramanan Subramanian < > gokul24...@gmail.com> wrote: > >> Tha

[DISCUSSION] Upgrade system tests to python 3

2020-08-14 Thread Nikolay Izhikov
Hello. > If anyone's interested in porting it to Python 3 it would be a good change. I’ve created a ticket [1] to upgrade system tests to python3. Does someone have any additional inputs or objections for this change? [1] https://issues.apache.org/jira/browse/KAFKA-10402 > 1 июля 2020 г., в 00

Re: [DISCUSSION] Upgrade system tests to python 3

2020-08-24 Thread Nikolay Izhikov
л(а): > > +1 > > On Fri, Aug 14, 2020 at 7:42 AM John Roesler wrote: > >> Thanks Nikolay, >> >> No objection. This would be very nice to have. >> >> Thanks, >> John >> >> On Fri, Aug 14, 2020, at 09:18, Nikolay Izhikov wrote: >&g

Re: [DISCUSSION] Upgrade system tests to python 3

2020-08-28 Thread Nikolay Izhikov
Hello! Any feedback on this? What I should additionally do to prepare system tests migration? > 24 авг. 2020 г., в 11:17, Nikolay Izhikov написал(а): > > Hello. > > PR [1] is ready. > Please, review. > > But, I need help with the two following questions: > &g

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-03 Thread Nikolay Izhikov
Hello! Just a friendly reminder. Patch to resolve some kind of technical debt - python2 in system tests is ready! Can someone, please, take a look? https://github.com/apache/kafka/pull/9196 > 28 авг. 2020 г., в 11:19, Nikolay Izhikov написал(а): > > Hello! > > Any feedback

Re: [DISCUSS] KIP-567: Kafka Cluster Audit

2020-09-07 Thread Nikolay Izhikov
Hello, Viktor. Do you want to implement the exact approach as it described in the current KIP? Or you have another proposal on how it has to be implemented? I abandoned this KIP due to lack of interest from community. Guess we can collaborate during implementation. > 7 сент. 2020 г., в 13:13, Vi

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-14 Thread Nikolay Izhikov
Hello! I got 2 approvals from Ivan Daschinskiy and Magnus Edenhill. Committers, please, join the review. > 3 сент. 2020 г., в 11:06, Nikolay Izhikov написал(а): > > Hello! > > Just a friendly reminder. > > Patch to resolve some kind of technical debt - python2 in sys

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-16 Thread Nikolay Izhikov
suite once your PR is cleanly rebased to verify the > whole suite works and then I can merge (I'm trusting Ivan and Magnus here > for their reviews :) > > Guozhang > > On Mon, Sep 14, 2020 at 3:56 AM Nikolay Izhikov wrote: > >> Hello! >> >> I got 2 a

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-21 Thread Nikolay Izhikov
afka/pull/9196 >> [3] >> https://github.com/apache/kafka/pull/9196/files#diff-9235a7bdb1ca9268681c0e56f3f3609bR39 >> >>> 16 сент. 2020 г., в 07:32, Guozhang Wang >> написал(а): >>> >>> Hello Nikolay, >>> >>> I can help ru

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-04-24 Thread Nikolay Izhikov
run the system tests with TLS 1.3. Do we > run them nightly? > > Ismael > > On Fri, Feb 14, 2020 at 4:17 AM Nikolay Izhikov wrote: > >> Hello, Kafka team. >> >> I ran system tests that use SSL for the TLSv1.3. >> You can find the results of the tests in t

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-04-27 Thread Nikolay Izhikov
that TLS 1.3 is exercised in the system tests > by default. > > Ismael > > On Fri, Apr 24, 2020 at 7:32 AM Nikolay Izhikov wrote: > >> Hello, Ismael. >> >> AFAIK we don’t run system tests nightly. >> Do we have resources to run system tests periodi

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-04-30 Thread Nikolay Izhikov
Ticket created: https://issues.apache.org/jira/browse/KAFKA-9943 I will prepare the PR, shortly. > 27 апр. 2020 г., в 17:55, Ismael Juma написал(а): > > Yes, a PR would be great. > > Ismael > > On Mon, Apr 27, 2020, 2:10 AM Nikolay Izhikov wrote: > >> Hello,

[REVIEW REQUEST] KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-07 Thread Nikolay Izhikov
Hello, Kafka Team. I prepared a PR [1] for the KAFKA-3184 [2] Can someone, please, do the review. [1] https://github.com/apache/kafka/pull/8592 [2] https://issues.apache.org/jira/browse/KAFKA-3184

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-05-18 Thread Nikolay Izhikov
The cipher suite names are different in TLS 1.3. What would be the behavior > if the client requests TLS 1.3, but the server only has cipher suites for > TLS 1.2? It would be good to explain the expected behavior and add tests to > verify it. > > Ismael > > On Thu, Apr 30, 2020 at

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-05-18 Thread Nikolay Izhikov
with the explicit configuration property "ssl.enabled.protocols" ``` > 25 февр. 2020 г., в 08:57, Nikolay Izhikov > написал(а): > > Hello. > > Any feedback on this? > > This change seems very simple, I can start vote right now if nothing to > discuss

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-05-18 Thread Nikolay Izhikov
cryptoroadmap.html), but it currently does not > support it. One way to handle this would be to check if the underlying JVM > supports TLS 1.3 before enabling it. > > I hope this clarifies my questions. > > Ismael > > On Mon, May 18, 2020 at 6:44 AM Nikolay Izhikov wrote:

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-05-18 Thread Nikolay Izhikov
add test for this case? I can prepare the preliminary PR for this KIP and add this kind of test to it. What do you think? > 18 мая 2020 г., в 18:59, Nikolay Izhikov написал(а): > >> 1. I meant that `ssl.protocol` is TLSv1.2 while `ssl.enabled.protocols` is >> `TLSv1.2, TLSv

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-05-18 Thread Nikolay Izhikov
enable TLS 1.3 by default even if the cipher suite is >> specified? >> >> best, >> Colin >> >> >> On Mon, May 18, 2020, at 09:26, Ismael Juma wrote: >>> Sounds good. >>> >>> Ismael >>> >>> >>> On Mo

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-05-19 Thread Nikolay Izhikov
PR - https://github.com/apache/kafka/pull/8695 > 18 мая 2020 г., в 23:30, Nikolay Izhikov написал(а): > > Hello, Colin > > We need hack only because TLSv1.3 not supported in java8. > >> Java 8 will receive TLS 1.3 support later this year >> (https://java.com

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-05-20 Thread Nikolay Izhikov
on so that TLS 1.3 is exercised in the system tests > by default. > > Ismael > > On Fri, Apr 24, 2020 at 7:32 AM Nikolay Izhikov wrote: > >> Hello, Ismael. >> >> AFAIK we don’t run system tests nightly. >> Do we have resources to run system tests p

Re: [VOTE] KIP-573: Enable TLSv1.3 by default

2020-05-21 Thread Nikolay Izhikov
olay, you have enough votes and 72 hours have passed, so you can close > this vote as successful whenever you're ready. > > Ismael > > On Mon, Mar 2, 2020 at 10:55 AM Nikolay Izhikov wrote: > >> Hello. >> >> I would like to start vote for K

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-05-21 Thread Nikolay Izhikov
plicitly. If such > users want to use TLS 1.3, they will have to update the list of ciphers to > include TLS 1.3 ciphers (which use a different naming convention). TLS 1.2 > will continue to work as usual, so there is no compatibility issue. > > Ismael > > On Tue, May 19, 202

Re: [VOTE] KIP-865: Support --bootstrap-server in kafka-streams-application-reset

2022-09-13 Thread Nikolay Izhikov
+1 (non-binding) пн, 12 сент. 2022 г. в 21:16, Chris Egerton : > +1 (binding). Thanks! > > On Mon, Sep 12, 2022 at 1:43 PM Bill Bejeck wrote: > > > Thanks for the KIP! > > > > +1(binding) > > > > -Bill > > > > On Mon, Sep 12, 2022 at 1:39 PM Николай Ижиков > > wrote: > > > > > Community, please

Re: [VOTE] KIP-865: Support --bootstrap-server in kafka-streams-application-reset

2022-09-13 Thread Nikolay Izhikov
Thanks all! This KIP has passed with one +1 (non-binding) votes from myself and three +1 (binding) votes from Chris Egerton, Bill Bejeck, Guozhang Wang. вт, 13 сент. 2022 г. в 19:30, Nikolay Izhikov : > +1 (non-binding) > > пн, 12 сент. 2022 г. в 21:16, Chris Egerton : > >> +1

[DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2019-12-24 Thread Nikolay Izhikov
Hello, I'd like to start a discussion of KIP. Its goal is to enable TLSv1.3 and disable obsolete versions by default. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=142641956 Your comments and suggestions are welcome.

Re: [VOTE] KIP-553: Disable all SSL protocols except TLSV1.2 by default.

2020-01-27 Thread Nikolay Izhikov
Thanks everyone! After 3+ business days since this thread started, I'm concluding the vote on KIP-553. The KIP has passed with: 4 binding votes from Mickael Maison, Manikumar, Rajini Sivaram, M. Manna. 2 non-binding vote from Ted Yu, Ron Dagostino. Thank you all for voting! > 22 янв. 2020 г.,

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-01-27 Thread Nikolay Izhikov
feedback. >>>>>> >>>>>> Should I mark this KIP as declined? >>>>>> Or just wait for the system tests results? >>>>>> >>>>>>> 6 янв. 2020 г., в 17:26, Rajini Sivaram >>>>>> написал(а): >>>

Re: [DISCUSS] KIP-561: Regex Expressions Support for ConsumerGroupCommand

2020-01-28 Thread Nikolay Izhikov
Hello, Alexander. As I can see from the previous discussion - you got positive feedback from the community. If you resolved all the comments and suggestions I think you should consider starting voting for this KIP. > 28 янв. 2020 г., в 10:56, Alexander Dunayevsky > написал(а): > > Any additi

Re: [VOTE] KIP-553: Disable all SSL protocols except TLSV1.2 by default.

2020-01-28 Thread Nikolay Izhikov
KIP adopted by https://github.com/apache/kafka/commit/172409c44b8551e2315bd93044a8a95ccda4699f > 27 янв. 2020 г., в 13:10, Nikolay Izhikov написал(а): > > Thanks everyone! > > After 3+ business days since this thread started, I'm concluding the vote > on KIP-553. >

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-01-29 Thread Nikolay Izhikov
a time instead of running them all together. That way, you could just run > all the tests that enable SSL. Details of running a subset of tests are in > the README in tests. > > On Mon, Jan 27, 2020 at 6:29 PM Nikolay Izhikov wrote: > Hello, Rajini. > > I’m tried to run al

Re: [DISCUSS] KIP-553: Enable TLSv1.3 by default and disable all protocols except [TLSV1.2, TLSV1.3]

2020-02-14 Thread Nikolay Izhikov
ent-17036930 [5] https://github.com/apache/kafka/pull/8106/files#diff-6dd015b94706f6920d9de524c355ddd8R51 > 29 янв. 2020 г., в 15:27, Nikolay Izhikov написал(а): > > Hello, Rajini. > > Thanks for the feedback. > > I’ve searched tests by the «ssl» keyword and found the following

[DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-02-21 Thread Nikolay Izhikov
Hello, I'd like to start a discussion of KIP [1] This is follow-up for the KIP-553 [2] Its goal is to enable TLSv1.3 by default. Your comments and suggestions are welcome. [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-573%3A+Enable+TLSv1.3+by+default [2] https://cwiki.apache.org/c

Fix of System tests on JDK11

2020-02-21 Thread Nikolay Izhikov
Hello, Kafka team. I found that system tests that starts earlier versions of Kafka doesn’t work with JDK11 [1] There is two main reason for it: * Kafka startup scripts contains removed JVM options like `-XX:+PrintGCDateStamps or `-XX:UseParNewGC`. * 0.10.0.1, 0.10.1.1, 0.10.2.2, 0.11.0

Re: [DISCUSS] KIP-573: Enable TLSv1.3 by default

2020-02-24 Thread Nikolay Izhikov
Hello. Any feedback on this? This change seems very simple, I can start vote right now if nothing to discuss here. > 21 февр. 2020 г., в 15:18, Nikolay Izhikov > написал(а): > > Hello, > > I'd like to start a discussion of KIP [1] > This is follow-up for the KI

Re: Fix of System tests on JDK11

2020-02-28 Thread Nikolay Izhikov
:30, Nikolay Izhikov > написал(а): > > Hello, Kafka team. > > I found that system tests that starts earlier versions of Kafka doesn’t work > with JDK11 [1] > > There is two main reason for it: > >* Kafka startup scripts contains removed JVM options l

[VOTE] KIP-573: Enable TLSv1.3 by default

2020-03-02 Thread Nikolay Izhikov
Hello. I would like to start vote for KIP-573: Enable TLSv1.3 by default KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-573%3A+Enable+TLSv1.3+by+default Discussion thread - https://lists.apache.org/thread.html/r1158b6caf416e7db802780de71115b3e2d3ef2c4664b7ec8cb32ea86%40%3Cdev.kafka

Re: Need for histogram type for Kafka Connect JMX Metrics

2020-03-19 Thread Nikolay Izhikov
Hello, Kanupriya Recently, I’ve implemented a histogram metric [1] in Apache Ignite. My implementation can work on a stream load. It just counts events that is fall into the predefined intervals(buckets). I think histogram can be useful to measure consumer lag or similar metrics. So, If the comm

Re: [DISCUSS] Should we automatically close stale PRs?

2022-02-05 Thread Nikolay Izhikov
Hello, David, Luke. What about KIPs? Should we have some special state on KIPs that was rejected or can’t be implemented due to lack of design or when Kafka goes in another direction? Right now those kind of KIPs just have no feedback. For me as a contributor it’s not clear - what is wrong with t

  1   2   >