Hello, Kafka team. PR [1] seems to be ready for merge.
If fixes system tests that start earlier versions of Kafka with JDK11 [1] I got LGTM from Guozhang and Ron Dagostino Can someone, please, make a final review? [1] https://github.com/apache/kafka/pull/8138 > 21 февр. 2020 г., в 16:30, Nikolay Izhikov <nizhikov....@gmail.com> > написал(а): > > Hello, Kafka team. > > I found that system tests that starts earlier versions of Kafka doesn’t work > with JDK11 [1] > > There is two main reason for it: > > * Kafka startup scripts contains removed JVM options like > `-XX:+PrintGCDateStamps or `-XX:UseParNewGC`. > * 0.10.0.1, 0.10.1.1, 0.10.2.2, 0.11.0.3 depends on JAXB that was removed > in JDK11. > > I fixed both of this issues. > Tests results [3] > > 1. Can you, please, review my changes? > 2. Now `upgrade_test.py` has only 2 failed tests for 0.8.2.2. Stack trace > below. > I seems like unfixable for me. > Can someone suggest how to fix it? > 3. What tests should be checked on JDK11 for these changes? > > ``` > Exception in thread "main" java.lang.NoClassDefFoundError: > org/apache/kafka/common/utils/Exit > at > org.apache.kafka.tools.VerifiableProducer.main(VerifiableProducer.java:540) > Caused by: java.lang.ClassNotFoundException: > org.apache.kafka.common.utils.Exit > at > java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) > at > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) > ... 1 more > > ``` > > I can provide full tests logs if you need it. Full size 7.5gb. > > [1] https://issues.apache.org/jira/browse/KAFKA-9573 > [2] https://github.com/apache/kafka/pull/8138 > [3] > https://issues.apache.org/jira/browse/KAFKA-9573?focusedCommentId=17041847&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17041847
