[
https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201985#comment-14201985
]
Manikumar Reddy commented on KAFKA-1739:
Created reviewboard h
07677c1c26768ef9c9032626180d0015f12cb0e0
Diff: https://reviews.apache.org/r/27684/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203262#comment-14203262
]
Manikumar Reddy commented on KAFKA-1743:
Updated reviewboard h
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1743:
---
Attachment: KAFKA-1743_2014-11-08_11:49:31.patch
> ConsumerConnector.commitOffsets in 0.
aces here, since its
> > none-obvious and someone may try to refactor in the future... Perhaps link
> > to the email thread?
Agreed. Added a comment.
- Manikumar Reddy
---
This is an automatically generated e-mail. T
problem will come in 0.8.3.
How to handle this?
2 methods, one w/o parenthsis and one with 1 parameter is getting compiled on
all scala versions.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://
method private
> >
> > def commitOffsets(retryOnFailure: Boolean = true)
> >
> > Another question, will scala compiler be confused with 2 methods, one
> > w/o parenthsis and one with 1 parameter having a default? Could you try
> > compiling the code on al
scala
07677c1c26768ef9c9032626180d0015f12cb0e0
Diff: https://reviews.apache.org/r/27684/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1743:
---
Attachment: KAFKA-1743_2014-11-14_22:29:21.patch
> ConsumerConnector.commitOffsets in 0.
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212481#comment-14212481
]
Manikumar Reddy commented on KAFKA-1743:
Updated reviewboard h
method private
> >
> > def commitOffsets(retryOnFailure: Boolean = true)
> >
> > Another question, will scala compiler be confused with 2 methods, one
> > w/o parenthsis and one with 1 parameter having a default? Could you try
> > compiling the code on al
https://reviews.apache.org/r/27684/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1743:
---
Attachment: KAFKA-1743_2014-11-16_12:11:51.patch
> ConsumerConnector.commitOffsets in 0.
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213869#comment-14213869
]
Manikumar Reddy commented on KAFKA-1743:
Updated reviewboard h
ethods, same as what's defined in
> > ConsumerConnector?
Done. Added the following APIs in ZookeeperConsumerConnector.
def commitOffsets(retryOnFailure: Boolean)
def commitOffsets
- Manikumar Reddy
---
This is an automatica
[
https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214296#comment-14214296
]
Manikumar Reddy commented on KAFKA-1173:
+1 for this patch. It is really us
kafka/consumer/ZookeeperConsumerConnectorTest.scala
bad099a904967651bc3a38b6bb9a9cdb592b832b
Diff: https://reviews.apache.org/r/27684/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1743:
---
Attachment: KAFKA-1743_2014-11-18_10:59:05.patch
> ConsumerConnector.commitOffsets in 0.
[
https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215733#comment-14215733
]
Manikumar Reddy commented on KAFKA-1743:
Updated reviewboard h
^
> > two errors found
> > FAILED
Oh My Bad! missed the test classes. Pl review the latest patch.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27684/#rev
://reviews.apache.org/r/28536/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228703#comment-14228703
]
Manikumar Reddy commented on KAFKA-1799:
Created reviewboard h
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1799:
---
Attachment: KAFKA-1799.patch
> ProducerConfig.METRIC_REPORTER_CLASSES_CONFIG doesn
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1799:
---
Assignee: Manikumar Reddy
Status: Patch Available (was: Open
8d886105341555a548ecc7b2901e7fc5d6b1ee8c
Diff: https://reviews.apache.org/r/28536/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1799:
---
Attachment: KAFKA-1799_2014-11-30_15:58:32.patch
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229065#comment-14229065
]
Manikumar Reddy commented on KAFKA-1799:
Updated reviewboard h
ommon/config/AbstractConfig.java
8d886105341555a548ecc7b2901e7fc5d6b1ee8c
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/28536/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1799:
---
Attachment: KAFKA-1799_2014-11-30_16:04:16.patch
[
https://issues.apache.org/jira/browse/KAFKA-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229066#comment-14229066
]
Manikumar Reddy commented on KAFKA-1799:
Updated reviewboard h
throw a ConfigException instead.
Used ConfigException.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28536/#review63295
---
[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1499:
---
Attachment: KAFKA-1499_2014-12-16_22:39:10.patch
> Broker-side compression configurat
,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248503#comment-14248503
]
Manikumar Reddy commented on KAFKA-1499:
Updated reviewboard h
[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248520#comment-14248520
]
Manikumar Reddy commented on KAFKA-1499:
[~jjkoshy] can you review this p
https://reviews.apache.org/r/24704/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1499:
---
Attachment: KAFKA-1499_2014-12-26_21:37:51.patch
> Broker-side compression configurat
t; > }
> >
> > If the resulting collection needs to be a java Collection you could
> > import the JavaConversions implicits, or just ignore me.
Thanks for the suggestion.
- Manikumar Reddy
---
This is
[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259127#comment-14259127
]
Manikumar Reddy commented on KAFKA-1499:
Updated reviewboard h
ompressionCodec and BrokerCompressionCodec and the new
> > ProducerCompressionCodec only extend from BrokerCompressionCodec
> >
> > (or see if there is an altogether different better way)
Joel, i implemented your suggestion here. Merged the new Brok
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262555#comment-14262555
]
Manikumar Reddy commented on KAFKA-1723:
Created reviewboard h
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Assignee: Manikumar Reddy
Status: Patch Available (was: Open)
> make the metrics n
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723.patch
> make the metrics name in new producer more stand
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262572#comment-14262572
]
Manikumar Reddy commented on KAFKA-1723:
Submitted a first level patch for
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264523#comment-14264523
]
Manikumar Reddy commented on KAFKA-1723:
Thanks for summarizing the solu
[
https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264537#comment-14264537
]
Manikumar Reddy commented on KAFKA-1499:
[~jjkoshy] Uploaded a new patch
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267407#comment-14267407
]
Manikumar Reddy commented on KAFKA-1723:
Thanks for the suggestion. will re
/StringSerializer.java
<https://reviews.apache.org/r/29590/#comment111066>
we should support null values right?. This is required for compaction..
- Manikumar Reddy O
On Jan. 5, 2015, 7:47 p.m., Jun Rao wrote:
>
> ---
.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269489#comment-14269489
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard h
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723_2015-01-08_21:41:13.patch
> make the metrics name in new producer m
7b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269513#comment-14269513
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard h
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723_2015-01-08_22:02:22.patch
> make the metrics name in new producer m
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269585#comment-14269585
]
Manikumar Reddy commented on KAFKA-1723:
1. Added MetricName object and rel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29738/#review67374
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 9, 2015, 1:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29724/#review67376
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 8, 2015, 8:47 p.m
.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723_2015-01-09_14:24:18.patch
> make the metrics name in new producer m
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270783#comment-14270783
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard h
me/password"
- Manikumar Reddy O
On Jan. 9, 2015, 8:09 a.m., Jaikiran Pai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
756/#comment111442>
Did you tested the failure senario? I did not get error message. I think we
will get exception only after invoking jira.issue().
- Manikumar Reddy O
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> ---
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I
> >
twork/SelectorTest.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
twork/SelectorTest.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar Reddy updated KAFKA-1723:
---
Attachment: KAFKA-1723_2015-01-09_23:43:22.patch
> make the metrics name in new producer m
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271637#comment-14271637
]
Manikumar Reddy commented on KAFKA-1723:
Updated reviewboard h
Jan. 8, 2015, 9:21 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java,
> > line 336
> > <https://reviews.apache.org/r/29523/diff/20/?file=813222#file813222line336>
> >
> > Should this be passed in? O
e metric, right? Absent the
> > group/tags info...
I have implemented toString() method in MetricName. So this will print complete
info about the metric name (name , group, description , tags)
- Manikumar Reddy
---
This is an aut
[
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271663#comment-14271663
]
Manikumar Reddy commented on KAFKA-1723:
1. Submitted new patch with sugge
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I
> >
801 - 872 of 872 matches
Mail list logo
