[ 
https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271663#comment-14271663
 ] 
Manikumar Reddy commented on KAFKA-1723:
----------------------------------------

1. Submitted new patch with suggested changes.

2. producer-metrics, producer-node-metrics, producer-topic-metrics are used for 
group names
Jconsole MBean hierachy will look like this

kafka.producer  --> producer-metrics  --> producer-1 --> metrics
kafka.producer  --> producer-node-metrics  --> producer-1 --> node-0 --> metrics
kafka.producer  --> producer-topic-metrics  --> my-topic --> metrics

{quote}
Another question: How are you supposed to make use of the .metrics() api on the 
producer and consumer now? 
{quote}
I am still thinking about this. We can implement criteria based metric 
retrieval or predicate based retrieval..



> make the metrics name in new producer more standard
> ---------------------------------------------------
>
>                 Key: KAFKA-1723
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1723
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients
>    Affects Versions: 0.8.2
>            Reporter: Jun Rao
>            Assignee: Manikumar Reddy
>            Priority: Blocker
>             Fix For: 0.8.2
>
>         Attachments: KAFKA-1723.patch, KAFKA-1723_2015-01-08_21:41:13.patch, 
> KAFKA-1723_2015-01-08_22:02:22.patch, KAFKA-1723_2015-01-09_14:24:18.patch, 
> KAFKA-1723_2015-01-09_23:43:22.patch
>
>
> The jmx name in the new producer looks like the following:
> kafka.producer.myclientid:type=mytopic
> However, this can be ambiguous since we allow "." in client id and topic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to