> On Nov. 29, 2014, 8:02 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java, > > line 153 > > <https://reviews.apache.org/r/28536/diff/1/?file=778386#file778386line153> > > > > We probably should throw a ConfigException instead.
Used ConfigException. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28536/#review63295 ----------------------------------------------------------- On Nov. 30, 2014, 10:35 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28536/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2014, 10:35 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1799 > https://issues.apache.org/jira/browse/KAFKA-1799 > > > Repository: kafka > > > Description > ------- > > Explicit string to class conversion done in > gAbstractConfig.getConfiguredInstances(), Addrresing Jun's comments > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java > 8d886105341555a548ecc7b2901e7fc5d6b1ee8c > > clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28536/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
