[jira] [Resolved] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-2344. Resolution: Fixed Fix Version/s: 0.8.3 Issue resolved by pull request 4 [https://github.com/i

[jira] [Reopened] (KAFKA-2344) kafka-merge-pr should support reviewers in commit message

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-2344: I closed the issue to test the script. > kafka-merge-pr should support reviewers in commit message > --

[jira] [Updated] (KAFKA-2344) kafka-merge-pr improvements

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2344: --- Summary: kafka-merge-pr improvements (was: kafka-merge-pr should support reviewers in commit message)

[GitHub] kafka pull request: KAFKA-2344; kafka-merge-pr improvements

GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/90 KAFKA-2344; kafka-merge-pr improvements The first 4 commits are adapted from changes that have been done to the Spark version and the last one is the feature that @gwenshap asked for. You can merge thi

[jira] [Commented] (KAFKA-2344) kafka-merge-pr improvements

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634868#comment-14634868 ] ASF GitHub Bot commented on KAFKA-2344: --- GitHub user ijuma opened a pull request:

[jira] [Updated] (KAFKA-2344) kafka-merge-pr improvements

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2344: --- Reviewer: Gwen Shapira Status: Patch Available (was: Reopened) I've added the feature requested

[jira] [Commented] (KAFKA-2344) kafka-merge-pr improvements

[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634922#comment-14634922 ] Ismael Juma commented on KAFKA-2344: As an example, the squashed commit message for th

[jira] [Commented] (KAFKA-2092) New partitioning for better load balancing

[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634927#comment-14634927 ] Gianmarco De Francisci Morales commented on KAFKA-2092: --- [hachikuji]

[jira] [Comment Edited] (KAFKA-2092) New partitioning for better load balancing

[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634927#comment-14634927 ] Gianmarco De Francisci Morales edited comment on KAFKA-2092 at 7/21/15 10:42 AM: ---

[VOTE] Switch to GitHub pull requests for new contributions

Hi all, I would like to start a vote on switching to GitHub pull requests for new contributions. To be precise, the vote is on whether we should: * Update the documentation to tell users to use pull requests instead of patches and Review Board (i.e. merge KAFKA-2321 and KAFKA-2349) * Use pull req

[jira] [Updated] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-251: -- Status: In Progress (was: Patch Available) Change to "In Progress" since the patch doesn't apply cleanly

[jira] [Commented] (KAFKA-388) Add a highly available consumer co-ordinator to a Kafka cluster

[ https://issues.apache.org/jira/browse/KAFKA-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634992#comment-14634992 ] Ismael Juma commented on KAFKA-388: --- Is this still relevant or can we close? > Add a hig

[jira] [Updated] (KAFKA-863) System Test - update 0.7 version of kafka-run-class.sh for Migration Tool test cases

[ https://issues.apache.org/jira/browse/KAFKA-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-863: -- Status: In Progress (was: Patch Available) Setting back to "In Progress" as it potentially needs more wo

[jira] [Updated] (KAFKA-2342) transient unit test failure in testConsumptionWithBrokerFailures

[ https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2342: --- Status: Patch Available (was: Open) There's a pull request from [~hachikuji], so setting the status a

[jira] [Updated] (KAFKA-2342) transient unit test failure in testConsumptionWithBrokerFailures

[ https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2342: --- Status: In Progress (was: Patch Available) Sorry, I didn't notice that the tests were timing out. Set

Re: Review Request 34641: Patch for KAFKA-2214

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92403 --- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala (li

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review92404 --- build.gradle (line 388)

Re: Review Request 36548: Patch for KAFKA-2336

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36548/#review92406 --- core/src/main/scala/kafka/server/OffsetManager.scala (line 447)

[GitHub] kafka pull request: auto.offset.reset docs not in sync with valida...

GitHub user sslavic opened a pull request: https://github.com/apache/kafka/pull/91 auto.offset.reset docs not in sync with validation In this commit https://github.com/apache/kafka/commit/0699ff2ce60abb466cab5315977a224f1a70a4da#diff-5533ddc72176acd1c32f5abbe94aa672 among other thi

Re: Review Request 36548: Patch for KAFKA-2336

> On July 21, 2015, 2:43 p.m., Ismael Juma wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 454 > > > > > > Is `topicData` guaranteed to have a key for `topic`? If not, it's > > better to do `to

[jira] [Commented] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635208#comment-14635208 ] Edward Ribeiro commented on KAFKA-251: -- [~ijuma] Hi, if it is still relevant and no on

[jira] [Commented] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635215#comment-14635215 ] Ismael Juma commented on KAFKA-251: --- [~eribeiro], I don't know if it's still relevant as

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635216#comment-14635216 ] Edward Ribeiro commented on KAFKA-2338: --- Oh, ignore the previous message, [~gwenshap

Re: Review Request 36593: Patch for KAFKA-2347

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92410 --- Ship it! Ship It! - Grant Henke On July 18, 2015, 10:14 p.m., As

[jira] [Commented] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635224#comment-14635224 ] Edward Ribeiro commented on KAFKA-251: -- I cannot. Afaik, it depends on the project, an

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 non-binding. A suggestion, we should try to phase out old system of reviews gradually, instead of forcing it over a night. Maybe a time bound switch? We can say like in x months from now we will completely move to PRs? On Tuesday, July 21, 2015, Ismael Juma wrote: > Hi all, > > I would like

[jira] [Commented] (KAFKA-251) The ConsumerStats MBean's PartOwnerStats attribute is a string

[ https://issues.apache.org/jira/browse/KAFKA-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635231#comment-14635231 ] Ismael Juma commented on KAFKA-251: --- [~eribeiro], I am not a committer and I can. :) Ask

Re: [VOTE] Switch to GitHub pull requests for new contributions

On Tue, Jul 21, 2015 at 4:11 PM, Ashish Singh wrote: > +1 non-binding. > > A suggestion, we should try to phase out old system of reviews gradually, > instead of forcing it over a night. I agree. Maybe a time bound switch? We can say > like in x months from now we will completely move to PRs?

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 . I think phasing out a good idea but rather than x months  we should move to github PRs for any new JIRAs that are not already in review board. For the JIRA’s that are in review board we can continue to use that until  they merged in. -Harsha On July 21, 2015 at 8:11:17 AM, Ashish Singh (a

Contributor request

Hello, I'm interested in being added to the contributor list for Apache Kafka so that I may assign myself to newbie JIRA tickets, please. My JIRA handle is eribeiro. Cheers, Eddie

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635281#comment-14635281 ] Daniel Schierbeck commented on KAFKA-2260: -- Where is the KIP being discussed? I c

[jira] [Commented] (KAFKA-2188) JBOD Support

[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635283#comment-14635283 ] Flavio Junqueira commented on KAFKA-2188: - hey tim, I had a look at the proposal,

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635287#comment-14635287 ] Ewen Cheslack-Postava commented on KAFKA-2260: -- [~dasch] http://search-hadoo

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635289#comment-14635289 ] Ismael Juma commented on KAFKA-2260: [~dasch] The KIP is: https://cwiki.apache.org/co

[jira] [Issue Comment Deleted] (KAFKA-2260) Allow specifying expected offset on produce

[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2260: --- Comment: was deleted (was: [~dasch] The KIP is: https://cwiki.apache.org/confluence/display/KAFKA/KIP

Re: [DISCUSS] KIP-27 - Conditional Publish

For 1, yes, when there is a transient leader change, it's guaranteed that a prefix of the messages in a request will be committed. However, it seems that the client needs to know what subset of messages are committed in order to resume the sending. Then the question is how. As Flavio indicated, fo

[jira] [Commented] (KAFKA-2188) JBOD Support

[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635305#comment-14635305 ] Jun Rao commented on KAFKA-2188: Another thing that's worth mentioning is that currently w

[jira] [Updated] (KAFKA-388) Add a highly available consumer co-ordinator to a Kafka cluster

[ https://issues.apache.org/jira/browse/KAFKA-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-388: -- Resolution: Duplicate Status: Resolved (was: Patch Available) This is now handled in KAFKA-1326. > Add

[jira] [Created] (KAFKA-2352) Possible memory leak in MirrorMaker and/or new Producer

Kostya Golikov created KAFKA-2352: - Summary: Possible memory leak in MirrorMaker and/or new Producer Key: KAFKA-2352 URL: https://issues.apache.org/jira/browse/KAFKA-2352 Project: Kafka Issue

Re: Review Request 35734: Patch for KAFKA-2293

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35734/#review92416 --- Ship it! Ship It! - Grant Henke On June 22, 2015, 5:35 p.m., Adi

Re: Review Request 36341: Patch for KAFKA-2311

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36341/#review92417 --- Ship it! Ship It! - Grant Henke On July 9, 2015, 1:04 a.m., Tim

[jira] [Updated] (KAFKA-2352) Possible memory leak in MirrorMaker and/or new Producer

[ https://issues.apache.org/jira/browse/KAFKA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostya Golikov updated KAFKA-2352: -- Description: I've been playing around with Mirror Maker (version from trunk, dated July 7th) an

[jira] [Updated] (KAFKA-2352) Possible memory leak in MirrorMaker and/or new Producer

[ https://issues.apache.org/jira/browse/KAFKA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostya Golikov updated KAFKA-2352: -- Attachment: producer.conf consumer.conf output.log > Possible me

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 (binding) Agree with Ismael. We may not want to rush to push the PR right away. Having said that, if it works well with say, 10 patches, I'd consider that enough to require the new JIRAs to submit patches using the PRs instead. Thanks, Neha On Tue, Jul 21, 2015 at 8:19 AM, Sriharsha Chintalap

[jira] [Commented] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635330#comment-14635330 ] Edward Ribeiro commented on KAFKA-2338: --- Updated reviewboard https://reviews.apache.

Re: Review Request 36578: Patch for KAFKA-2338

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36578/ --- (Updated July 21, 2015, 4:21 p.m.) Review request for kafka. Bugs: KAFKA-2338

[jira] [Updated] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

[ https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro updated KAFKA-2338: -- Attachment: KAFKA-2338_2015-07-21_13:21:19.patch > Warn users if they change max.message.bytes t

Re: Review Request 36565: Patch for KAFKA-2345

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36565/#review92422 --- Ship it! Ship It! - Grant Henke On July 17, 2015, 5:21 p.m., Ash

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 non-binding On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede wrote: > +1 (binding) > > Agree with Ismael. We may not want to rush to push the PR right away. > Having said that, if it works well with say, 10 patches, I'd consider that > enough to require the new JIRAs to submit patches using th

Re: [DISCUSS] KIP-27 - Conditional Publish

In KV store usage, all instances are writers, aren't they? There is no leader or master, thus there is no fail over. The offset based CAS ensures an update is based on the latest value and doesn't care who is writing the new value. I think the idea of the offset based CAS is great. I think it work

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 On Tue, Jul 21, 2015 at 9:31 AM, Grant Henke wrote: > +1 non-binding > > On Tue, Jul 21, 2015 at 11:19 AM, Neha Narkhede wrote: > > > +1 (binding) > > > > Agree with Ismael. We may not want to rush to push the PR right away. > > Having said that, if it works well with say, 10 patches, I'd co

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 (binding) on using PRs. It sounds like we need additional discussion on how the transition will happen. Maybe move that to a separate thread, to keep the vote easy to follow. On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma wrote: > Hi all, > > I would like to start a vote on switching to GitHub

[jira] [Updated] (KAFKA-2342) transient unit test failure in testConsumptionWithBrokerFailures

[ https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2342: --- Description: If a rebalance occurs with an in-flight fetch, the new KafkaConsumer can end up

[jira] [Updated] (KAFKA-2342) KafkaConsumer rebalance with in-flight fetch can cause invalid position

[ https://issues.apache.org/jira/browse/KAFKA-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2342: --- Summary: KafkaConsumer rebalance with in-flight fetch can cause invalid position (was: transi

Re: [DISCUSS] KIP-27 - Conditional Publish

That's a fair point. I've added some imagined job logic to the KIP, so we can make sure the proposal stays in sync with the usages we're discussing. (The logic is just a quick sketch for now -- I expect I'll need to elaborate it as we get into more detail, or to address other concerns...) On Tue,

Re: Kafka High level consumer rebalancing

Any ideas? On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal wrote: > Hi all, > > Is there any way I can force Zookeeper/Kafka to rebalance new consumers > only for subset of total number of partitions. I have a situation where out > of 120 partitions 60 have been already consumed, but the zookeep

Re: Review Request 36578: Patch for KAFKA-2338

> On July 21, 2015, 6:57 a.m., Ewen Cheslack-Postava wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 90 > > > > > > This format call isn't working because it's being called on the second > > strin

Re: Kafka High level consumer rebalancing

Not sure if you can do that with High level consumer. Thanks, Mayuresh On Tue, Jul 21, 2015 at 10:53 AM, Pranay Agarwal wrote: > Any ideas? > > On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal > wrote: > > > Hi all, > > > > Is there any way I can force Zookeeper/Kafka to rebalance new consumer

[jira] [Commented] (KAFKA-2345) Attempt to delete a topic already marked for deletion throws ZkNodeExistsException

[ https://issues.apache.org/jira/browse/KAFKA-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635596#comment-14635596 ] Edward Ribeiro commented on KAFKA-2345: --- [~singhashish], [~gwenshap], sorry, late to

Submitting a patch (Jira errors)

Hi, I had to clean up existing kafka repo on my linux box and start with a fresh one. I followed the instructions here : https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review I am trying to upload a patch and I am getting these errors : Configuring reviewboard url to ht

[jira] [Updated] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2299: -- Resolution: Won't Fix Status: Resolved (was: Patch Available) Moving to Github PRs, so

[jira] [Closed] (KAFKA-2299) kafka-patch-review tool does not correctly capture testing done

[ https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh closed KAFKA-2299. - > kafka-patch-review tool does not correctly capture testing done > --

[jira] [Created] (KAFKA-2353) SocketServer.Processor should catch exception and close the socket properly in configureNewConnections.

Jiangjie Qin created KAFKA-2353: --- Summary: SocketServer.Processor should catch exception and close the socket properly in configureNewConnections. Key: KAFKA-2353 URL: https://issues.apache.org/jira/browse/KAFKA-235

Re: Submitting a patch (Jira errors)

Did you setup your jira.ini? On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat < gharatmayures...@gmail.com> wrote: > Hi, > > I had to clean up existing kafka repo on my linux box and start with a > fresh one. > > I followed the instructions here : > > > https://cwiki.apache.org/confluence/displa

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 (non-binding) Thanks Parth On 7/21/15, 10:24 AM, "Gwen Shapira" wrote: >+1 (binding) on using PRs. > >It sounds like we need additional discussion on how the transition >will happen. Maybe move that to a separate thread, to keep the vote >easy to follow. > >On Tue, Jul 21, 2015 at 4:28 AM, I

Re: Submitting a patch (Jira errors)

Yes. Thanks, Mayuresh On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Did you setup your jira.ini? > > On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat < > gharatmayures...@gmail.com> wrote: > > > Hi, > > > > I had to clean up existing kafka repo on

Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/ --- Review request for kafka. Bugs: KAFKA-2351 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Status: Patch Available (was: Open) > Brokers are having a problem shutting down correctly >

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351.patch > Brokers are having a problem shutting down correctly >

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635734#comment-14635734 ] Mayuresh Gharat commented on KAFKA-2351: Created reviewboard https://reviews.apach

Re: Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92465 --- Thanks for the patch, some comments. core/src/main/scala/kafka/net

Re: Review Request 36652: Patch for KAFKA-2351

On July 21, 2015, 8:18 p.m., Mayuresh Gharat wrote: > > T Yes. Got it, I thought that we should be catching all exceptions and exit. But doing the above will catch the exception and exit when its shutting down and thats the only thing that this ticket considers. - Mayuresh

Re: Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92470 --- core/src/main/scala/kafka/network/SocketServer.scala (line 266)

Re: Review Request 36652: Patch for KAFKA-2351

> On July 21, 2015, 8:26 p.m., Grant Henke wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 266 > > > > > > What errors were seen that should be caught here? Can we catch a more > > specific exc

Re: Review Request 36652: Patch for KAFKA-2351

> On July 21, 2015, 8:26 p.m., Grant Henke wrote: > > core/src/main/scala/kafka/network/SocketServer.scala, line 266 > > > > > > What errors were seen that should be caught here? Can we catch a more > > specific exc

Re: Submitting a patch (Jira errors)

Resolved this. Thanks, Mayuresh On Tue, Jul 21, 2015 at 12:59 PM, Mayuresh Gharat < gharatmayures...@gmail.com> wrote: > Yes. > > Thanks, > > Mayuresh > > On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar < > aaurad...@linkedin.com.invalid> wrote: > >> Did you setup your jira.ini? >> >> On Tue,

[jira] [Created] (KAFKA-2354) setting log.dirs property makes tools fail if there is a comma

Michael Graff created KAFKA-2354: Summary: setting log.dirs property makes tools fail if there is a comma Key: KAFKA-2354 URL: https://issues.apache.org/jira/browse/KAFKA-2354 Project: Kafka

[jira] [Updated] (KAFKA-2354) setting log.dirs property makes tools fail if there is a comma

[ https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Graff updated KAFKA-2354: - Description: If one sets log.dirs=/u1/kafka,/u2/kafka, the tools fail to run: kafka-topics --desc

[jira] [Commented] (KAFKA-2354) setting log.dirs property makes tools fail if there is a comma

[ https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635864#comment-14635864 ] Edward Ribeiro commented on KAFKA-2354: --- Hi [~Skandragon], unfortunately, I was unab

Re: Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/ --- (Updated July 21, 2015, 9:58 p.m.) Review request for kafka. Bugs: KAFKA-2351

[jira] [Commented] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635885#comment-14635885 ] Mayuresh Gharat commented on KAFKA-2351: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2351: --- Attachment: KAFKA-2351_2015-07-21_14:58:13.patch > Brokers are having a problem shutting down

[jira] [Commented] (KAFKA-2354) setting log.dirs property makes tools fail if there is a comma

[ https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635915#comment-14635915 ] Michael Graff commented on KAFKA-2354: -- Closing as this now appears to be a local err

[jira] [Resolved] (KAFKA-2354) setting log.dirs property makes tools fail if there is a comma

[ https://issues.apache.org/jira/browse/KAFKA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Graff resolved KAFKA-2354. -- Resolution: Not A Problem > setting log.dirs property makes tools fail if there is a comma > ---

Re: Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review92488 --- Ship it! Latest patch looks good to me. - Jiangjie Qin On July 2

Re: [VOTE] Switch to GitHub pull requests for new contributions

+1 -Jay On Tue, Jul 21, 2015 at 4:28 AM, Ismael Juma wrote: > Hi all, > > I would like to start a vote on switching to GitHub pull requests for new > contributions. To be precise, the vote is on whether we should: > > * Update the documentation to tell users to use pull requests instead of > pa

Review Request 36664: Patch for KAFKA-2353

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36664/ --- Review request for kafka. Bugs: KAFKA-2353 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2353) SocketServer.Processor should catch exception and close the socket properly in configureNewConnections.

[ https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2353: Attachment: KAFKA-2353.patch > SocketServer.Processor should catch exception and close the socket pr

[jira] [Updated] (KAFKA-2353) SocketServer.Processor should catch exception and close the socket properly in configureNewConnections.

[ https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2353: Status: Patch Available (was: Open) > SocketServer.Processor should catch exception and close the s

[jira] [Commented] (KAFKA-2353) SocketServer.Processor should catch exception and close the socket properly in configureNewConnections.

[ https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635987#comment-14635987 ] Jiangjie Qin commented on KAFKA-2353: - Created reviewboard https://reviews.apache.org/

Re: Review Request 36664: Patch for KAFKA-2353

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36664/#review92496 --- Thanks for looking into that. Exception handling was the most challe

[jira] [Commented] (KAFKA-2353) SocketServer.Processor should catch exception and close the socket properly in configureNewConnections.

[ https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636020#comment-14636020 ] Jiangjie Qin commented on KAFKA-2353: - [~gwenshap] Can you help take a look at this pa

[jira] [Commented] (KAFKA-2353) SocketServer.Processor should catch exception and close the socket properly in configureNewConnections.

[ https://issues.apache.org/jira/browse/KAFKA-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636040#comment-14636040 ] Gwen Shapira commented on KAFKA-2353: - I left comments in RB :) > SocketServer.Proces

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/ --- (Updated July 22, 2015, 12:08 a.m.) Review request for kafka. Bugs: KAFKA-221

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636051#comment-14636051 ] Parth Brahmbhatt commented on KAFKA-2210: - Updated reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Attachment: KAFKA-2210_2015-07-21_17:08:21.patch > KafkaAuthorizer: Add all public entities,

Re: Review Request 34492: Patch for KAFKA-2210

> On June 1, 2015, 1:11 a.m., Jun Rao wrote: > > Thanks for that patch. A few comments below. > > > > Also, two common types of users are consumers and publishers. Currently, if > > you want to allow a user to consume from topic t in consumer group g, you > > have to grant (1) read permission

Re: Review Request 34492: Patch for KAFKA-2210

> On July 21, 2015, 2:13 a.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/security/auth/PermissionType.scala, line 21 > > > > > > the semi-colon is trying to scape here, catch it! :) Indeed it was, removed.

Re: Review Request 34492: Patch for KAFKA-2210

> On July 21, 2015, 2:15 a.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/security/auth/PermissionType.scala, line 21 > > > > > > Just kidding, please remove it. removed. - Parth

Re: Review Request 34492: Patch for KAFKA-2210

> On July 21, 2015, 2:09 a.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 166 > > > > > > Please, put a space between ``if`` and ``(``. Fixed. - Parth --

  1   2   >