[
https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634922#comment-14634922
]
Ismael Juma commented on KAFKA-2344:
------------------------------------
As an example, the squashed commit message for this PR (with some imaginary
reviewers) looks like:
{code}
KAFKA-2344; Improvements to merge PR script
Author: Ismael Juma <ism...@juma.me.uk>
Reviewers: Fred Brooks <f...@brooks.co.uk>, Alex James <a...@james.com>
Closes #4 from ijuma/kafka-2344-merge-pr-improvements and squashes the
following commits:
d847c94 [Ismael Juma] Allow reviewers to be entered during merge
0d7cb23 [Ismael Juma] Allow primary author to be overridden during merge
da2fd94 [Ismael Juma] Set JIRA resolution to "Fixed" instead of relying on
default transition
392623a [Ismael Juma] Check return value of doctest.testmod()
76b58a0 [Ismael Juma] Fix instructions on how to install the `jira-python`
library
2040890 [Ismael Juma] KAFKA-2328; merge-kafka-pr.py script should not leave
user in a detached branch
{code}
> kafka-merge-pr improvements
> ---------------------------
>
> Key: KAFKA-2344
> URL: https://issues.apache.org/jira/browse/KAFKA-2344
> Project: Kafka
> Issue Type: Improvement
> Reporter: Gwen Shapira
> Assignee: Ismael Juma
> Priority: Minor
> Fix For: 0.8.3
>
>
> Two suggestions for the new pr-merge tool:
> * The tool doesn't allow to credit reviewers while committing. I thought the
> review credits were a nice habit of the Kafka community and I hate losing it.
> OTOH, I don't want to force-push to trunk just to add credits. Perhaps the
> tool can ask about committers?
> * Looks like the tool doesn't automatically resolve the JIRA. Would be nice
> if it did.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
