Review Request 36503: Patch for KAFKA-2188

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36503/ --- Review request for kafka. Bugs: KAFKA-2188 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2188) JBOD Support

[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-2188: Attachment: KAFKA-2188.patch > JBOD Support > > > Key: KAFKA-2188 >

[jira] [Commented] (KAFKA-2188) JBOD Support

[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627708#comment-14627708 ] Timothy Chen commented on KAFKA-2188: - Created reviewboard https://reviews.apache.org/

Re: Review Request 36474: Patch for KAFKA-2188

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36474/ --- (Updated July 15, 2015, 8:19 a.m.) Review request for kafka and Joe Stein. Bu

[jira] [Commented] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627727#comment-14627727 ] Flavio Junqueira commented on KAFKA-2300: - thank you, [~bob.cot...@gmail.com]. how

Re: [DISCUSS] Json libraries for Kafka

On Mon, Jul 13, 2015 at 10:05 PM, Ismael Juma wrote: > * It's not thread-safe (so external locks are needed to use it in a > concurrent environment) > I realise now that I didn't make the impact of this very clear. The current code is acquiring a JVM-wide lock for the duration of every Json pars

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628122#comment-14628122 ] David Hay commented on KAFKA-1835: -- It seems to me that there are two aspects to sending

Contributor Request

Hi, I'm interested in being added to the contributor list for Apache Kafka so that I may assign myself to a newbie JIRA ticket. Thank you Warren Green 248.390.8849 Computer Science Major | UIUC

[jira] [Created] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

Ismael Juma created KAFKA-2335: -- Summary: Javadoc for Consumer says that it's thread-safe Key: KAFKA-2335 URL: https://issues.apache.org/jira/browse/KAFKA-2335 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628320#comment-14628320 ] Jason Gustafson commented on KAFKA-2275: Hey [~onurkaraman], I think that seems li

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628323#comment-14628323 ] Ewen Cheslack-Postava commented on KAFKA-2335: -- Good catch, it seems we misse

[jira] [Assigned] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-2335: -- Assignee: Jason Gustafson > Javadoc for Consumer says that it's thread-safe > -

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628335#comment-14628335 ] Jason Gustafson commented on KAFKA-2335: Yep, my bad. I went ahead and assigned th

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628336#comment-14628336 ] Ismael Juma commented on KAFKA-2335: Go for it. :) > Javadoc for Consumer says that i

[jira] [Commented] (KAFKA-2320) Configure GitHub pull request build in Jenkins

[ https://issues.apache.org/jira/browse/KAFKA-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628358#comment-14628358 ] Ismael Juma commented on KAFKA-2320: Jun has created a Jenkins job: https://builds.ap

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628365#comment-14628365 ] Edward Ribeiro commented on KAFKA-2335: --- I was going to work on this, but go ahead.

[GitHub] kafka pull request: KAFKA-2335; fix comment about thread safety

GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/78 KAFKA-2335; fix comment about thread safety You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-2335 Alternatively you can re

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628373#comment-14628373 ] ASF GitHub Bot commented on KAFKA-2335: --- GitHub user hachikuji opened a pull request

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628377#comment-14628377 ] Jason Gustafson commented on KAFKA-2335: Woops, sorry about that [~eribeiro]. Can

[jira] [Updated] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2335: - Reviewer: Guozhang Wang Fix Version/s: 0.8.3 Component/s: consumer

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628383#comment-14628383 ] Edward Ribeiro commented on KAFKA-2335: --- LOL, no need to apologize. :) I have just j

Re: Contributor Request

Can you share your JIRA username? I couldn't find you. On Tue, Jul 14, 2015 at 8:04 PM, Warren Green wrote: > Hi, > > I'm interested in being added to the contributor list for Apache Kafka so > that I may assign myself to a newbie JIRA ticket. > > Thank you > > Warren Green > 248.390.8849 > Compu

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628392#comment-14628392 ] Ashish K Singh commented on KAFKA-2275: --- [~onurkaraman] I think your suggestion make

[jira] [Comment Edited] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628392#comment-14628392 ] Ashish K Singh edited comment on KAFKA-2275 at 7/15/15 5:25 PM:

[GitHub] kafka pull request: KAFKA-2320; Test commit

Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Commented] (KAFKA-2320) Configure GitHub pull request build in Jenkins

[ https://issues.apache.org/jira/browse/KAFKA-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628396#comment-14628396 ] ASF GitHub Bot commented on KAFKA-2320: --- Github user ijuma closed the pull request a

[jira] [Updated] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1944: -- Assignee: Aravind Selvan (was: Ashish K Singh) > Rename LogCleaner and related classes to LogCo

[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628397#comment-14628397 ] Ashish K Singh commented on KAFKA-1944: --- [~aravind.selvan] all yours. This will prob

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628413#comment-14628413 ] Guozhang Wang commented on KAFKA-1835: -- I agree that either way there will be an API

[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628414#comment-14628414 ] Jiangjie Qin commented on KAFKA-1944: - [~ashishujjain], LogCleaner is not a public API

[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628419#comment-14628419 ] Ashish K Singh commented on KAFKA-1944: --- {quote} Ashish Singh, LogCleaner is not a p

[jira] [Updated] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2335: - Status: Patch Available (was: Open) > Javadoc for Consumer says that it's thread-

[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628432#comment-14628432 ] Joel Koshy commented on KAFKA-1944: --- Perhaps KIP would be overkill for this. I would rec

[jira] [Updated] (KAFKA-2276) Initial patch for KIP-25

[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2276: - Fix Version/s: 0.8.3 Status: Patch Available (was: Open) > Initial pat

[jira] [Updated] (KAFKA-2276) Initial patch for KIP-25

[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2276: - Reviewer: Gwen Shapira > Initial patch for KIP-25 > > >

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628452#comment-14628452 ] Jiangjie Qin commented on KAFKA-1835: - Hey Guozhang, from your proposal it is not clea

[jira] [Created] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

Grant Henke created KAFKA-2336: -- Summary: Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment Key: KAFKA-2336 URL: https://issues.apache.org/jira/browse

[jira] [Work started] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2336 started by Grant Henke. -- > Changing offsets.topic.num.partitions after the offset topic is created > breaks c

Re: [jira] [Created] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

Makes sense! On Wednesday, July 15, 2015, Joel Koshy (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628432#comment-14628432 > ] > > Joel Koshy commented on KAFKA-1944: > -

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628510#comment-14628510 ] Guozhang Wang commented on KAFKA-1835: -- Jiangjie, I was trying to argue that for thos

[jira] [Created] (KAFKA-2337) Verify that metric names will not collide when creating new topics

Gwen Shapira created KAFKA-2337: --- Summary: Verify that metric names will not collide when creating new topics Key: KAFKA-2337 URL: https://issues.apache.org/jira/browse/KAFKA-2337 Project: Kafka

[jira] [Created] (KAFKA-2338) Warn users if they change max.message.bytes that they also need to update broker and consumer settings

Ewen Cheslack-Postava created KAFKA-2338: Summary: Warn users if they change max.message.bytes that they also need to update broker and consumer settings Key: KAFKA-2338 URL: https://issues.apache.org/jira

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2123: - Resolution: Fixed Assignee: Jason Gustafson (was: Ewen Cheslack-Postava) Status: Res

Re: Review Request 36333: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91808 --- Ship it! Ship It! - Guozhang Wang On July 15, 2015, 1:21 a.m., J

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628606#comment-14628606 ] Guozhang Wang commented on KAFKA-2123: -- Thanks [~hachikuji] for the patience working

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

+1 Thanks, Jun On Tue, Jul 14, 2015 at 2:09 PM, Ewen Cheslack-Postava wrote: > Hi all, > > Let's start a vote on KIP-26: Add Copycat connector framework for data > import/export > > For reference, here's the wiki: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=58851767 > An

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628621#comment-14628621 ] Jiangjie Qin commented on KAFKA-1835: - Guozhang, what you said makes sense and I also

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

Another questions regarding the "kafka-merge-pr.py" script: once a committer gives a LGTM on the PR, could the contributor use the script to push to the git repo himself, or it must be executed by the committer? I thought it is the former case but seems not. If not we need to make it clear on the w

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

The script just runs a git push, it will be with your user (from git configuration), so you need privileges to push. On Wed, Jul 15, 2015 at 12:59 PM, Guozhang Wang wrote: > Another questions regarding the "kafka-merge-pr.py" script: once a > committer gives a LGTM on the PR, could the contributo

Re: Review Request 36333: Patch for KAFKA-2123

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91810 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/C

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2337: Assignee: Grant Henke > Verify that metric names will not collide when creating new topics > ---

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628656#comment-14628656 ] David Hay commented on KAFKA-1835: -- With this example, we would still be required to wrap

[jira] [Updated] (KAFKA-2337) Verify that metric names will not collide when creating new topics

[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2337: Reviewer: Gwen Shapira > Verify that metric names will not collide when creating new topics > --

Build failed in Jenkins: Kafka-trunk #542

See Changes: [wangguoz] KAFKA-2123: add callback in commit api and use a delayed queue for async requests; reviewed by Ewen Cheslack-Postava and Guozhang Wang -- [...truncated 2529 lines...] kafka.lo

[jira] [Created] (KAFKA-2339) broker becomes unavailable if bad data is passed through the protocol

Joe Stein created KAFKA-2339: Summary: broker becomes unavailable if bad data is passed through the protocol Key: KAFKA-2339 URL: https://issues.apache.org/jira/browse/KAFKA-2339 Project: Kafka

Jenkins build is back to normal : KafkaPreCommit #148

See

[jira] [Commented] (KAFKA-2288) Follow-up to KAFKA-2249 - reduce logging and testing

[ https://issues.apache.org/jira/browse/KAFKA-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628877#comment-14628877 ] Jun Rao commented on KAFKA-2288: [~gwenshap], now that you are a committer, do you want to

[jira] [Commented] (KAFKA-2333) Add rename topic support

[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628878#comment-14628878 ] Jay Kreps commented on KAFKA-2333: -- Word. Probably does need a KIP, though. Presumably t

[jira] [Resolved] (KAFKA-2249) KafkaConfig does not preserve original Properties

[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2249. Resolution: Fixed Resolving the jira since the remaining issues are being followed up in KAFKA-2288. > Kaf

[jira] [Assigned] (KAFKA-2333) Add rename topic support

[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-2333: -- Assignee: Grant Henke > Add rename topic support > > >

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

Thanks Gwen, will update the wiki then. On Wed, Jul 15, 2015 at 1:03 PM, Gwen Shapira wrote: > The script just runs a git push, it will be with your user (from git > configuration), so you need privileges to push. > > On Wed, Jul 15, 2015 at 12:59 PM, Guozhang Wang > wrote: > > Another question

[GitHub] kafka pull request: KAFKA-2335; fix comment about thread safety

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/78 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628893#comment-14628893 ] ASF GitHub Bot commented on KAFKA-2335: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2335: - Resolution: Fixed Status: Resolved (was: Patch Available) > Javadoc for Consumer says tha

[jira] [Commented] (KAFKA-2333) Add rename topic support

[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628898#comment-14628898 ] Grant Henke commented on KAFKA-2333: I am thinking the expected behavior if there are

[jira] [Commented] (KAFKA-2333) Add rename topic support

[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628897#comment-14628897 ] Gwen Shapira commented on KAFKA-2333: - In pretty much every database in existence writ

Re: Contributor Request

Hi Gwen, My username is: wgreen Thanks! Warren Green 248.390.8849 Computer Science Major | UIUC On Wed, Jul 15, 2015 at 12:23 PM, Gwen Shapira wrote: > Can you share your JIRA username? I couldn't find you. > > On Tue, Jul 14, 2015 at 8:04 PM, Warren Green > wrote: > > Hi, > > > > I'm intere

Re: Review Request 36333: Patch for KAFKA-2123

> On July 15, 2015, 8:10 p.m., Onur Karaman wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java, > > lines 280-282 > > > > > > I think this is a bug. schedule takes a timest

Re: Contributor Request

Cool, added you. Thanks for volunteering to help out! On Wed, Jul 15, 2015 at 3:49 PM, Warren Green wrote: > Hi Gwen, > > My username is: wgreen > > Thanks! > > Warren Green > 248.390.8849 > Computer Science Major | UIUC > > On Wed, Jul 15, 2015 at 12:23 PM, Gwen Shapira > wrote: > >> Can you s

[jira] [Commented] (KAFKA-2333) Add rename topic support

[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628909#comment-14628909 ] Jay Kreps commented on KAFKA-2333: -- [~gwenshap] Yeah totally, agree it will be tricky. Th

[jira] [Commented] (KAFKA-2330) Vagrantfile sets global configs instead of per-provider override configs

[ https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628928#comment-14628928 ] Geoffrey Anderson commented on KAFKA-2330: -- +1 from me I confirmed on my mac tha

Build failed in Jenkins: KafkaPreCommit #149

See Changes: [wangguoz] KAFKA-2335; fix comment about thread safety -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu legacy-ubuntu) in workspace

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628960#comment-14628960 ] Guozhang Wang commented on KAFKA-1835: -- Hey [~dhay], I think the proposal in KIP-19 w

Re: Review Request 35615: Patch for KAFKA-1782

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35615/ --- (Updated July 15, 2015, 11:58 p.m.) Review request for kafka. Bugs: KAFKA-178

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-1782: - Attachment: KAFKA-1782_2015-07-15_16:57:44.patch > Junit3 Misusage > --- > >

[jira] [Updated] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Pakulov updated KAFKA-1782: - Status: Patch Available (was: In Progress) > Junit3 Misusage > --- > >

Re: Review Request 35615: Patch for KAFKA-1782

> On July 14, 2015, 2:49 a.m., Guozhang Wang wrote: > > Some general comments: > > > > 1. Regarding the @Before and @After annotations, one suggestion from the > > JIRA was that we remove any annotations other than "@Test" itself but use > > scalatest features (for example, > > http://doc.sca

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628964#comment-14628964 ] Alexander Pakulov commented on KAFKA-1782: -- Updated reviewboard https://reviews.a

Build failed in Jenkins: Kafka-trunk #543

See Changes: [wangguoz] KAFKA-2335; fix comment about thread safety -- [...truncated 799 lines...] kafka.log.LogTest > testCorruptIndexRebuild PASSED kafka.log.LogTest > testTruncateTo PASSED kafka.

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628983#comment-14628983 ] Guozhang Wang commented on KAFKA-1835: -- Hi Jiangjie, yeah that makes more sense to me

[GitHub] kafka pull request: [Minor] fix new consumer heartbeat reschedule ...

GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/79 [Minor] fix new consumer heartbeat reschedule bug This commit fixes a minor issue introduced in the patch for KAFKA-2123. The schedule method requires the time the task should be executed, not a del

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628994#comment-14628994 ] ASF GitHub Bot commented on KAFKA-2123: --- GitHub user hachikuji opened a pull request

[jira] [Commented] (KAFKA-2288) Follow-up to KAFKA-2249 - reduce logging and testing

[ https://issues.apache.org/jira/browse/KAFKA-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628995#comment-14628995 ] Gwen Shapira commented on KAFKA-2288: - Will do. I missed the RB comment. > Follow-up

[jira] [Created] (KAFKA-2340) Add additional unit tests for new consumer Fetcher

Jason Gustafson created KAFKA-2340: -- Summary: Add additional unit tests for new consumer Fetcher Key: KAFKA-2340 URL: https://issues.apache.org/jira/browse/KAFKA-2340 Project: Kafka Issue Ty

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629007#comment-14629007 ] Jason Gustafson commented on KAFKA-2335: [~eribeiro], I created KAFKA-2340 just no

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629014#comment-14629014 ] Jiangjie Qin commented on KAFKA-1835: - Oh, I see your concern. My understanding is tha

Confluence Wiki Permissions

Hi there, I'm interested in posting a KIP (for this ticket: https://issues.apache.org/jira/browse/KAFKA-2260) but I don't seem to have the right permissions to create the wiki page. Can anyone here set that up? (Username is `bkirwi`.)

[jira] [Commented] (KAFKA-2335) Javadoc for Consumer says that it's thread-safe

[ https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629030#comment-14629030 ] Edward Ribeiro commented on KAFKA-2335: --- Thanks [~hachikuji]! Going to tackle it asa

Re: Confluence Wiki Permissions

Done. Thanks, Jun On Wed, Jul 15, 2015 at 5:22 PM, Ben Kirwin wrote: > Hi there, > > I'm interested in posting a KIP (for this ticket: > https://issues.apache.org/jira/browse/KAFKA-2260) but I don't seem to > have the right permissions to create the wiki page. > > Can anyone here set that up?

Re: Confluence Wiki Permissions

Great -- thank you! On Wed, Jul 15, 2015 at 9:13 PM, Jun Rao wrote: > Done. > > Thanks, > > Jun > > On Wed, Jul 15, 2015 at 5:22 PM, Ben Kirwin wrote: > >> Hi there, >> >> I'm interested in posting a KIP (for this ticket: >> https://issues.apache.org/jira/browse/KAFKA-2260) but I don't seem to >

[jira] [Commented] (KAFKA-2330) Vagrantfile sets global configs instead of per-provider override configs

[ https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629055#comment-14629055 ] Ewen Cheslack-Postava commented on KAFKA-2330: -- [~granders] Uggh, that's real

[jira] [Commented] (KAFKA-2330) Vagrantfile sets global configs instead of per-provider override configs

[ https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629060#comment-14629060 ] Geoffrey Anderson commented on KAFKA-2330: -- Sorry, for reference, the aws machine

[GitHub] kafka pull request: [Minor] fix new consumer heartbeat reschedule ...

Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629067#comment-14629067 ] ASF GitHub Bot commented on KAFKA-2123: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-2328) merge-kafka-pr.py script should restore previous branch after merge is cancelled

[ https://issues.apache.org/jira/browse/KAFKA-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629072#comment-14629072 ] Guozhang Wang commented on KAFKA-2328: -- Even if I finished the merge process it seems

Re: Review Request 34492: Patch for KAFKA-2210

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91836 --- Thanks for the patch. A few comments below. Also, 1. For making use

Build failed in Jenkins: Kafka-trunk #544

See Changes: [wangguoz] [MINOR] fix new consumer heartbeat reschedule bug -- [...truncated 1489 lines...] kafka.log.OffsetMapTest > testClear PASSED kafka.log.LogManagerTest > testCleanupSegmentsToMa

Build failed in Jenkins: KafkaPreCommit #150

See Changes: [wangguoz] [MINOR] fix new consumer heartbeat reschedule bug -- [...truncated 1881 lines...] kafka.admin.DeleteTopicTest > testDeleteNonExistingTopic PASSED kafka.admin.AddPartitionsT

Re: kafka git commit: Hot fix for LIKAFKA-3492; force offset commit/fetches to go to kafka regardless of request version

My bad - I accidentally pushed this to apache instead of our internal linkedin repo! I will delete this. On Thu, Jul 16, 2015 at 05:26:55AM +, jjko...@apache.org wrote: > Repository: kafka > Updated Branches: > refs/heads/hotfix [created] a098de48e > > > Hot fix for LIKAFKA-3492; force off