On Mon, Jul 13, 2015 at 10:05 PM, Ismael Juma <ism...@juma.me.uk> wrote:

> * It's not thread-safe (so external locks are needed to use it in a
> concurrent environment)
>

I realise now that I didn't make the impact of this very clear. The current
code is acquiring a JVM-wide lock for the duration of every Json parse call
(and parsing is slow with this library, accentuating the issue):

https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/utils/Json.scala#L35

Even if it's not used in the most performance sensitive parts of the app,
it is likely to lead to concurrency bottlenecks as the number of threads
goes up.

Best,
Ismael

Reply via email to