[ 
https://issues.apache.org/jira/browse/KAFKA-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628323#comment-14628323
 ] 

Ewen Cheslack-Postava commented on KAFKA-2335:
----------------------------------------------

Good catch, it seems we missed on reference to thread safety in KAFKA-2168. 
You're right that the intended behavior is to not be thread safe, so the 
earlier statement should be removed or updated.

> Javadoc for Consumer says that it's thread-safe
> -----------------------------------------------
>
>                 Key: KAFKA-2335
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2335
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ismael Juma
>
> This looks like it was left there by mistake:
> {quote}
>  * The consumer is thread safe but generally will be used only from within a 
> single thread. The consumer client has no threads of it's own, all work is 
> done in the caller's thread when calls are made on the various methods 
> exposed.
> {quote}
> A few paragraphs below it says:
> {quote}
> The Kafka consumer is NOT thread-safe. All network I/O happens in the thread 
> of the application making the call. It is the responsibility of the user to 
> ensure that multi-threaded access is properly synchronized. Un-synchronized 
> access will result in {@link ConcurrentModificationException}.
> {quote}
> This matches what the code does, so the former quoted section should probably 
> be deleted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to