Re: Review Request 33204: Patch for KAFKA-1646 add test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated May 11, 2015, 10 a.m.) Review request for kafka. Summary (updated) -

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537786#comment-14537786 ] Honghai Chen commented on KAFKA-1646: - Add test cases https://reviews.apache.org/r/332

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150422.patch) > Improve consumer read performance for Windows > -

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150422.patch > Improve consumer read performance for Windows >

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537787#comment-14537787 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > Improve consumer rea

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537791#comment-14537791 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150511_AddTestcases.patch) > Improve consumer read performance fo

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch > Improve consumer read performance for Windows >

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch > Improve consumer read performance for Windows >

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > Improve consumer rea

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537793#comment-14537793 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150511_AddTestcases.patch) > Improve consumer read performance fo

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > Improve consumer rea

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150422.patch) > Improve consumer read performance for Windows > -

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch > Improve consumer read performance for Windows >

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537796#comment-14537796 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150511_AddTestcases.patch) > Improve consumer read performance fo

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150511_AddTestcases.patch > Improve consumer read performance for Windows >

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537798#comment-14537798 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646.patch) > Improve consumer read performance for Windows > --

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150312_200352.patch) > Improve consumer read performance for Wind

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Created reviewboard against branch origin/trunk) > Improve consumer rea

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150414_184503.patch) > Improve consumer read performance for Wind

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150414_035415.patch) > Improve consumer read performance for Wind

[jira] [Updated] (KAFKA-1977) Make logEndOffset available in the Zookeeper consumer

[ https://issues.apache.org/jira/browse/KAFKA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1977: --- Status: In Progress (was: Patch Available) [~willf], thanks for the patch. This is a useful feature to add. I

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538199#comment-14538199 ] Jun Rao commented on KAFKA-2169: Parth, Thanks for the patch. Since we haven't officially

Re: Review Request 33557: Patch for KAFKA-1936

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33557/#review83234 --- core/src/main/scala/kafka/server/KafkaRequestHandler.scala

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Status: Patch Available (was: Open) > Upgrade to zkclient-0.5 > --- > >

Review Request 34047: Patch for KAFKA-2169

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34047/ --- Review request for kafka. Bugs: KAFKA-2169 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169.patch > Upgrade to zkclient-0.5 > --- > >

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538313#comment-14538313 ] Parth Brahmbhatt commented on KAFKA-2169: - Created reviewboard https://reviews.apa

Review Request 34050: Patch for KAFKA-2169

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/ --- Review request for kafka. Bugs: KAFKA-2169 https://issues.apache.org/jira/b

Re: [DISCUSS] KIP-21 Configuration Management

I totally agree that ZK is not in-and-of-itself a configuration management solution and it would be better if we could just keep all our config in files. Anyone who has followed the various config discussions over the past few years of discussion knows I'm the biggest proponent of immutable file-dr

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538376#comment-14538376 ] Parth Brahmbhatt commented on KAFKA-2169: - Created reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169.patch > Upgrade to zkclient-0.5 > --- > >

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538409#comment-14538409 ] Parth Brahmbhatt commented on KAFKA-2169: - Posted a review on review board. https:

[jira] [Created] (KAFKA-2184) ConsumerConfig does not honor default java.util.Properties

Jason Whaley created KAFKA-2184: --- Summary: ConsumerConfig does not honor default java.util.Properties Key: KAFKA-2184 URL: https://issues.apache.org/jira/browse/KAFKA-2184 Project: Kafka Issue

[jira] [Updated] (KAFKA-2184) ConsumerConfig does not honor default java.util.Properties

[ https://issues.apache.org/jira/browse/KAFKA-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Whaley updated KAFKA-2184: Description: When creating a ConsumerConfig from java.util.Properties, an IllegalArgumentException

Re: Review Request 33916: Patch for KAFKA-2163

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33916/#review83264 --- Ship it! Thanks for the patch. Looks good. Just a couple of minor c

Re: [DISCUSS] KIP-21 Configuration Management

I understand your point here, Jay, but I disagree that we can't have two configuration systems. We have two different types of configuration information. We have configuration that relates to the service itself (the Kafka broker), and we have configuration that relates to the content within the ser

[jira] [Created] (KAFKA-2185) Update to Gradle 2.4

Ismael Juma created KAFKA-2185: -- Summary: Update to Gradle 2.4 Key: KAFKA-2185 URL: https://issues.apache.org/jira/browse/KAFKA-2185 Project: Kafka Issue Type: Improvement Components:

Review Request 34056: Patch for KAFKA-2185

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34056/ --- Review request for kafka. Bugs: KAFKA-2185 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538537#comment-14538537 ] Ismael Juma commented on KAFKA-2185: Created reviewboard https://reviews.apache.org/r/

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Status: Patch Available (was: Open) > Update to Gradle 2.4 > > >

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Attachment: KAFKA-2185.patch > Update to Gradle 2.4 > > > Key: KA

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Assignee: (was: Ismael Juma) > Update to Gradle 2.4 > > > Key

Re: Review Request 34056: Patch for KAFKA-2185

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34056/ --- (Updated May 11, 2015, 7:55 p.m.) Review request for kafka. Bugs: KAFKA-2185

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Attachment: KAFKA-2185_2015-05-11_20:55:08.patch > Update to Gradle 2.4 > > >

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2185: --- Attachment: (was: KAFKA-2185.patch) > Update to Gradle 2.4 > > >

[jira] [Commented] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538544#comment-14538544 ] Ismael Juma commented on KAFKA-2185: Updated reviewboard https://reviews.apache.org/r/

Re: Review Request 34056: Patch for KAFKA-2185

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34056/ --- (Updated May 11, 2015, 8:02 p.m.) Review request for kafka. Bugs: KAFKA-2185

Re: [DISCUSS] KIP-21 Configuration Management

Hi Jay, I don't say we can't get rid of configuration file, I believe we can - it is just a lot of work and not a good idea IMO. I think the analogy to "normal unix services" stands. MySQL and Postgres use configuration files. I think there two topics here: 1. Configuring dynamically created ent

Re: [DISCUSS] KIP-21 Configuration Management

What Todd said :) (I think my ops background is showing...) On Mon, May 11, 2015 at 10:17 PM, Todd Palino wrote: > I understand your point here, Jay, but I disagree that we can't have two > configuration systems. We have two different types of configuration > information. We have configuration

Re: Review Request 34050: Patch for KAFKA-2169

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/#review83278 --- Thanks for the patch. A couple of comments blow. core/src/main/sca

[jira] [Comment Edited] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538409#comment-14538409 ] Parth Brahmbhatt edited comment on KAFKA-2169 at 5/11/15 8:25 PM: --

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538592#comment-14538592 ] Jun Rao commented on KAFKA-2169: 1) By api compatibility, I meant the following. Let's say

Re: Review Request 34050: Patch for KAFKA-2169

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/ --- (Updated May 11, 2015, 8:53 p.m.) Review request for kafka. Bugs: KAFKA-2169

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2169: Attachment: KAFKA-2169_2015-05-11_13:52:57.patch > Upgrade to zkclient-0.5 > ---

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538629#comment-14538629 ] Parth Brahmbhatt commented on KAFKA-2169: - Updated reviewboard https://reviews.apa

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated May 11, 2015, 9:51 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538703#comment-14538703 ] Aditya A Auradkar commented on KAFKA-2136: -- Updated reviewboard https://reviews.a

Re: Review Request 34050: Patch for KAFKA-2169

> On May 11, 2015, 8:25 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 1116-1120 > > > > > > We register two StateListeners on the same zkclient instance in the > > broker.

[jira] [Updated] (KAFKA-2136) Client side protocol changes to return quota delays

[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2136: - Attachment: KAFKA-2136_2015-05-11_14:50:56.patch > Client side protocol changes to return

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538709#comment-14538709 ] Jun Rao commented on KAFKA-2169: Parth, 1. Have you done the api compatibility test? 3. D

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538713#comment-14538713 ] Parth Brahmbhatt commented on KAFKA-2169: - [~junrao] 1) Yes I tested with 0.8.2 an

Re: Review Request 34050: Patch for KAFKA-2169

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34050/#review83286 --- core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538762#comment-14538762 ] Jun Rao commented on KAFKA-1997: A late comment: shouldn't we hardcode the key/value seria

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538801#comment-14538801 ] Jiangjie Qin commented on KAFKA-1997: - Hey [~junrao], good point. I will do that when

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-05-11_16:09:36.patch > new java producer needs ssl s

Re: Review Request 33620: Patch for KAFKA-1690

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated May 11, 2015, 11:09 p.m.) Review request for kafka. Bugs: KAFKA-1690

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538838#comment-14538838 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard https:/

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated May 11, 2015, 11:16 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-05-11_16:16:01.patch > byte rate metrics per client ID (produc

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538850#comment-14538850 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated May 11, 2015, 11:17 p.m.) Review request for kafka, Joel Koshy and Jun

Kafka KIP hangout May 12

Hi, Everyone, We will have a KIP hangout at 11 PST on May 12. The following is the agenda. If you want to attend and is not on the invite, please let me know. Agenda: KIP-11 (authorization): any remaining issues KIP-12 (sasl/ssl authentication): status check KIP-19 (Add a request timeout to Netwo

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538900#comment-14538900 ] Jun Rao commented on KAFKA-1997: The reasoning is that there is no good default value to s

Re: [DISCUSS] KIP-21 Configuration Management

So the general concern here is the dichotomy of configs (which we already have - i.e., in the form of broker config files vs topic configs in zookeeper). We (at LinkedIn) had some discussions on this last week and had this very question for the operations team whose opinion is I think to a large de

[jira] [Commented] (KAFKA-2150) FetcherThread backoff need to grab lock before wait on condition.

[ https://issues.apache.org/jira/browse/KAFKA-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538994#comment-14538994 ] Guozhang Wang commented on KAFKA-2150: -- My bad on missing this but while reviewing. +

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review83332 --- Ship it! Ship It! - Guozhang Wang On April 25, 2015, 8:35 p.m.,

[jira] [Updated] (KAFKA-2150) FetcherThread backoff need to grab lock before wait on condition.

[ https://issues.apache.org/jira/browse/KAFKA-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2150: - Resolution: Fixed Status: Resolved (was: Patch Available) > FetcherThread backoff need to

Re: Review Request 33916: Patch for KAFKA-2163

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33916/#review8 --- core/src/main/scala/kafka/server/OffsetManager.scala

[jira] [Created] (KAFKA-2186) Follow-up patch of KAFKA-1650

Jiangjie Qin created KAFKA-2186: --- Summary: Follow-up patch of KAFKA-1650 Key: KAFKA-2186 URL: https://issues.apache.org/jira/browse/KAFKA-2186 Project: Kafka Issue Type: Bug Reporte

RE: [DISCUSS] KIP-21 Configuration Management

I did initially think having everything in ZK was better than having the dichotomy Joel referred to primarily because all kafka configs can be managed consistently. I guess the biggest disadvantage of driving broker config primarily from ZK is that it requires everyone to manage Kafka configura

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review83341 --- core/src/main/scala/kafka/api/FetchResponse.scala

Review Request 34070: Patch for KAFKA-2186

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/ --- Review request for kafka. Bugs: KAFKA-2186 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2186) Follow-up patch of KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2186: Attachment: KAFKA-2186.patch > Follow-up patch of KAFKA-1650 > - > >

[jira] [Updated] (KAFKA-2186) Follow-up patch of KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-2186: Status: Patch Available (was: Open) > Follow-up patch of KAFKA-1650 > -

[jira] [Commented] (KAFKA-2186) Follow-up patch of KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539074#comment-14539074 ] Jiangjie Qin commented on KAFKA-2186: - Created reviewboard https://reviews.apache.org/

Build failed in Jenkins: KafkaPreCommit #99

See Changes: [wangguoz] KAFKA-2150; move partitionMapCond.await into partitionMapLock; reviewed by Guozhang Wang -- [...truncated 2140 lines...] kafka.utils.SchedulerTest > testRestart PASSED kafk

Re: Review Request 34070: Patch for KAFKA-2186

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83343 --- Ship it! core/src/main/scala/kafka/javaapi/consumer/ConsumerConnec

[jira] [Updated] (KAFKA-2146) adding partition did not find the correct startIndex

[ https://issues.apache.org/jira/browse/KAFKA-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2146: - Status: In Progress (was: Patch Available) > adding partition did not find the correct startIndex

[jira] [Commented] (KAFKA-2146) adding partition did not find the correct startIndex

[ https://issues.apache.org/jira/browse/KAFKA-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539129#comment-14539129 ] Guozhang Wang commented on KAFKA-2146: -- [~chenshangan...@163.com] Thanks for the patc

RE: [DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

All issues fixed, test cases added, performance result on windows attached. The patch can help improve the consume performance around 25%~50%. Thanks, Honghai Chen -Original Message- From: Jun Rao [mailto:j...@confluent.io] Sent: Wednesday, May 6, 2015 5:39 AM To: dev@kafka.apache.org

[jira] [Updated] (KAFKA-2186) Follow-up patch of KAFKA-1650

[ https://issues.apache.org/jira/browse/KAFKA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2186: --- Reviewer: Joel Koshy > Follow-up patch of KAFKA-1650 > - > > Key:

[jira] [Updated] (KAFKA-2169) Upgrade to zkclient-0.5

[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2169: --- Reviewer: Jun Rao > Upgrade to zkclient-0.5 > --- > > Key: KAFKA-2169 >

[jira] [Updated] (KAFKA-2185) Update to Gradle 2.4

[ https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2185: --- Reviewer: Jun Rao Assignee: Ismael Juma > Update to Gradle 2.4 > > >

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2132: --- Reviewer: Jay Kreps (was: Gwen Shapira) > Move Log4J appender to clients module > ---

[jira] [Updated] (KAFKA-2178) Loss of highwatermarks on incorrect cluster shutdown/restart

[ https://issues.apache.org/jira/browse/KAFKA-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2178: --- Reviewer: Jun Rao > Loss of highwatermarks on incorrect cluster shutdown/restart > ---

  1   2   >