----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33916/#review83333 -----------------------------------------------------------
core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/33916/#comment134281> I think either is fine. i.e., this is one of those logs which would be useful in debugging and is not completely out of place at the INFO level. This should only occur periodically every offset retention check interval period which is by default 10 minutes. It is helpful for debugging offset management issues if any. When we remove offsets after topic deletion (KAFKA-2000) it would help get a breakdown of what was removed due to expiration and what was removed due to topic deletion. I'm okay either way though. Let me know if you have a strong preference. core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/33916/#comment134283> Similar to above - this used to be debug level in the earlier version, but can be very useful for troubleshooting any issues. - Joel Koshy On May 6, 2015, 10:06 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33916/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2163 > https://issues.apache.org/jira/browse/KAFKA-2163 > > > Repository: kafka > > > Description > ------- > > fix > > > renames and logging improvements > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 122b1dbbe45cb27aed79b5be1e735fb617c716b0 > core/src/main/scala/kafka/server/OffsetManager.scala > 18680ce100f10035175cc0263ba7787ab0f6a17a > > Diff: https://reviews.apache.org/r/33916/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
