[
https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538199#comment-14538199
]
Jun Rao commented on KAFKA-2169:
--------------------------------
Parth,
Thanks for the patch. Since we haven't officially switched to github, could you
still attach the patch to the jira?
A few comments on the patch.
1. Could you verify that zkClient 0.5 is api compatible with 0.3? For example,
in the 0.8.2.0 release, if you just replace zkclient 0.3 jar with the 0.5 jar,
does the consumer still work?
2. I agree with [~i_maravic]. If we can't establish a new ZK session, we should
probably just let the broker or the consumer exit.
3. In the broker, the broker and the controller use the same zkclient instance.
So the actually logic for handleSessionEstablishmentError() just needs to be
done in one place. Similarly, on the consumer side, there is only one zkclient
instance.
> Upgrade to zkclient-0.5
> -----------------------
>
> Key: KAFKA-2169
> URL: https://issues.apache.org/jira/browse/KAFKA-2169
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.2.0
> Reporter: Neha Narkhede
> Assignee: Parth Brahmbhatt
> Priority: Critical
>
> zkclient-0.5 is released
> http://mvnrepository.com/artifact/com.101tec/zkclient/0.5 and has the fix for
> KAFKA-824
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
