[ 
https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538409#comment-14538409
 ] 

Parth Brahmbhatt commented on KAFKA-2169:
-----------------------------------------

Posted a review on review board. https://reviews.apache.org/r/34050/diff/
1) I tried console-producer and console-consumer at trunk with only my changes 
applied and it works.
2) I do not disagree with the approach, however that is a change in behavior 
and I was trying to get the upgrade in given its blocking other jiras without 
having to tie that behavior change discussion to this jira. I have modified the 
behavior so it will not do System.exit.
3) Not sure what you mean here , we are handling it as part of 
handleSessionEstablishmentError() in all cases. 

> Upgrade to zkclient-0.5
> -----------------------
>
>                 Key: KAFKA-2169
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2169
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2.0
>            Reporter: Neha Narkhede
>            Assignee: Parth Brahmbhatt
>            Priority: Critical
>         Attachments: KAFKA-2169.patch, KAFKA-2169.patch
>
>
> zkclient-0.5 is released 
> http://mvnrepository.com/artifact/com.101tec/zkclient/0.5 and has the fix for 
> KAFKA-824



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to