[jira] [Commented] (KAFKA-1903) Zk Expiration causes controller deadlock

[ https://issues.apache.org/jira/browse/KAFKA-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296572#comment-14296572 ] yufeng.chen commented on KAFKA-1903: kafka_2.11-0.8.2-beta doesn't have the issue, th

[jira] [Created] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

Ewen Cheslack-Postava created KAFKA-1907: Summary: ZkClient can block controlled shutdown indefinitely Key: KAFKA-1907 URL: https://issues.apache.org/jira/browse/KAFKA-1907 Project: Kafka

Re: Cannot stop Kafka server if zookeeper is shutdown first

Looks like a bug to me -- the underlying ZK library wraps a lot of blocking method implementations with waitUntilConnected() calls without any timeouts. Ideally we could just add a version of ZkUtils.getController() with a timeout, but I don't see an easy way to accomplish that with ZkClient. Ther

Re: [VOTE] 0.8.2.0 Candidate 3

+1 on librdkafka interop Minor nitpick: KAFKA-1781 (state required gradle version in README) is included in the Release notes but is not actually fixed 2015-01-29 6:22 GMT+01:00 Jun Rao : > This is the third candidate for release of Apache Kafka 0.8.2.0. > > Release Notes for the 0.8.2.0 rele

Re: Changing the default Kafka data log directory (was Re: What to do when file.rename fails?)

It's seems a good idea . use /tmp/kafka-log as default dir maybe delete by other people and very unsafe . 2015-01-29 14:26 GMT+08:00 Jaikiran Pai : > I have created a JIRA for this proposed change https://issues.apache.org/ > jira/browse/KAFKA-1906 and uploaded a patch for review > https://review

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 27799: New consumer

> On Jan. 20, 2015, 8:03 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/KafkaClient.java, lines 30-33 > > > > > > Wondering why we make newline for @param but keep the same line for > > @

Re: Review Request 27799: New consumer

> On Jan. 22, 2015, 5:35 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/clients/RequestCompletionHandler.java, > > line 21 > > > > > > nit. Can we remove the public from the interface methods?

Re: Review Request 27799: New consumer

> On Jan. 27, 2015, 10:25 a.m., Onur Karaman wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java, > > line 205 > > > > > > You left a blah. This one is actually intentional. We have

Re: Review Request 27799: New consumer

> On Jan. 28, 2015, 1:34 a.m., Guozhang Wang wrote: > > "patch -p1 < patch-file" does not do the renaming of > > RequestCompletionHandler.java so I have to do that manually (weird), but > > other than that, build / test LGTM. > > > > It seems some of previous comments are not addressed yet. F

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/ --- (Updated Jan. 29, 2015, 11:20 a.m.) Review request for kafka. Bugs: KAFKA-176

[jira] [Updated] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1760: - Attachment: KAFKA-1760_2015-01-29_03:20:20.patch > Implement new consumer client > ---

[jira] [Commented] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296710#comment-14296710 ] Jay Kreps commented on KAFKA-1760: -- Updated reviewboard https://reviews.apache.org/r/2779

[jira] [Created] (KAFKA-1908) Split brain

Alexey Ozeritskiy created KAFKA-1908: Summary: Split brain Key: KAFKA-1908 URL: https://issues.apache.org/jira/browse/KAFKA-1908 Project: Kafka Issue Type: Bug Components: core

Re: Review Request 28769: Patch for KAFKA-1809

> On Jan. 23, 2015, 1:57 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 182-183 > > > > > > Since this is also used for communication btw the controller and the > > brokers, perhap

[jira] [Resolved] (KAFKA-1903) Zk Expiration causes controller deadlock

[ https://issues.apache.org/jira/browse/KAFKA-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani resolved KAFKA-1903. --- Resolution: Won't Fix Closing this as won't fix as this is fixed 0.8.2 , re-o

Re: Review Request 30403: Patch for KAFKA-1906

Maybe I'm in the minority here, but I actually don't think there should be a default for this param and you should be required to explicitly set this. On Thu, Jan 29, 2015 at 5:43 AM, Jay Kreps wrote: > > > > On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > > We added --override option to Ka

Re: Review Request 27799: New consumer

> On Jan. 20, 2015, 8:03 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java, > > line 114 > > > > > > Should this inherit from CommonClientConfig? > > Jay Kreps

Re: Cannot stop Kafka server if zookeeper is shutdown first

Ewen is right. ZkClient APIs are blocking and the right fix for this seems to be patching ZkClient. At some point, if we find ourselves fiddling too much with ZkClient, it wouldn't hurt to write our own little zookeeper client wrapper. On Thu, Jan 29, 2015 at 12:57 AM, Ewen Cheslack-Postava wrote

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 28769: Patch for KAFKA-1809

+1 I also feel, having security.* would be easy going forward. Thanks Bosco On 1/29/15, 6:08 AM, "Jeff Holoman" wrote: > > >> On Jan. 23, 2015, 1:57 a.m., Jun Rao wrote: >> > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 182-183 >> > >>

Re: Review Request 28108: Patch for KAFKA-1664

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Jan. 29, 2015, 6:26 p.m.) Review request for kafka. Summary (updated

[jira] [Updated] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1664: -- Attachment: KAFKA-1664_2015-01-29_10:26:20.patch > Kafka does not properly parse multipl

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297291#comment-14297291 ] Ashish Kumar Singh commented on KAFKA-1664: --- Updated reviewboard https://reviews

Re: Review Request 28108: Patch for KAFKA-1664

> On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote: > > Sorry for the late review. Can check this in once you get a chance to > > address these review suggestions. Thanks for the review. Addressed the concerns. > On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/k

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

Hi Bhavesh, I think it is the right discussion to have when we are talking about the new new design for MM. Please see the inline comments. Jiangjie (Becket) Qin On 1/28/15, 10:48 PM, "Bhavesh Mistry" wrote: >Hi Jiangjie, > >I just wanted to let you know about our use case and stress the point

Re: Review Request 30259: Add static code coverage reporting capability

> On Jan. 27, 2015, 1:39 a.m., Eric Olander wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, line 17 > > > > > > Are there any open issues against scoverage that would explain why it > > can't instrument this

Re: Review Request 30259: Patch for KAFKA-1722

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30259/ --- (Updated Jan. 29, 2015, 8:33 p.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1722) static analysis code coverage for pci audit needs

[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297604#comment-14297604 ] Ashish Kumar Singh commented on KAFKA-1722: --- Updated reviewboard https://reviews

[jira] [Updated] (KAFKA-1722) static analysis code coverage for pci audit needs

[ https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1722: -- Attachment: KAFKA-1722_2015-01-29_12:33:01.patch > static analysis code coverage for pci

Re: Review Request 30259: Patch for KAFKA-1722

> On Jan. 27, 2015, 1:39 a.m., Eric Olander wrote: > > This is a nice improvement to the project. Thanks! Thanks for the review. Addressed your concern. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://r

Re: Review Request 27799: New consumer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27799/#review70291 --- Ship it! - Guozhang Wang On Jan. 29, 2015, 11:20 a.m., Jay Kreps

[jira] [Commented] (KAFKA-1760) Implement new consumer client

[ https://issues.apache.org/jira/browse/KAFKA-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297847#comment-14297847 ] Guozhang Wang commented on KAFKA-1760: -- LGTM, let's commit to trunk now. > Implement

Re: [VOTE] 0.8.2.0 Candidate 3

In meetup we said that KAFKA-1650 and follow up patches is included in 0.8.2, but it seems not on the list. On 1/29/15, 1:01 AM, "Magnus Edenhill" wrote: >+1 on librdkafka interop > >Minor nitpick: > KAFKA-1781 (state required gradle version in README) is included in the >Release notes but is

Re: [VOTE] 0.8.2.0 Candidate 3

I think we were just confirming whether that issue was fixed in 0.8.2 not. Given that this issue only happens in unclean shutdown, I don't think it's a blocker for 0.8.2. Also, the patch is not trivial and it's better to test it out a bit longer in trunk. Thanks, Jun On Thu, Jan 29, 2015 at 5:36

[jira] [Commented] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298059#comment-14298059 ] Joel Koshy commented on KAFKA-1729: --- Thanks Jun - will do. When you get a chance, take a

[jira] [Assigned] (KAFKA-1905) KafkaProducer's performance could be halved when MaxInFlightRequest is set to 1

[ https://issues.apache.org/jira/browse/KAFKA-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-1905: --- Assignee: Jiangjie Qin > KafkaProducer's performance could be halved when MaxInFlightRequest

[jira] [Commented] (KAFKA-1905) KafkaProducer's performance could be halved when MaxInFlightRequest is set to 1

[ https://issues.apache.org/jira/browse/KAFKA-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298106#comment-14298106 ] Jay Kreps commented on KAFKA-1905: -- It's not every day you double performance by moving a

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

Hi Jiangjie, Thanks for the input. a) Is MM will producer ack will be attach to Producer Instance or per topic. Use case is that one instance of MM needs to handle both strong ack and also ack=0 for some topic. Or it would be better to set-up another instance of MM. b) Regarding TCP connectio

Build failed in Jenkins: Kafka-trunk #384

See Changes: [jay.kreps] KAFKA-1760: New consumer. -- [...truncated 1171 lines...] kafka.log.BrokerCompressionTest > testBrokerSideCompression[14] PASSED kafka.log.BrokerCompressionTest > testBrokerS

Build failed in Jenkins: Kafka-trunk #385

See Changes: [jay.kreps] KAFKA-1760 Follow-up: fix compilation issue with Scala 2.11 -- [...truncated 2177 lines...] at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:52)