> On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote: > > Sorry for the late review. Can check this in once you get a chance to > > address these review suggestions.
Thanks for the review. Addressed the concerns. > On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/zk/ZKPathTest.scala, line 63 > > <https://reviews.apache.org/r/28108/diff/3/?file=789148#file789148line63> > > > > typo: zkConnectWithInvaidRoot Good catch! - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/#review69582 ----------------------------------------------------------- On Jan. 29, 2015, 6:26 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28108/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 6:26 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1664 > https://issues.apache.org/jira/browse/KAFKA-1664 > > > Repository: kafka > > > Description > ------- > > KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root > chroot > > > Diffs > ----- > > core/src/main/scala/kafka/utils/ZkUtils.scala > c14bd455b6642f5e6eb254670bef9f57ae41d6cb > core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/28108/diff/ > > > Testing > ------- > > Tested with and without the fix. > > > Thanks, > > Ashish Singh > >
