> On Jan. 27, 2015, 1:39 a.m., Eric Olander wrote: > > This is a nice improvement to the project. Thanks!
Thanks for the review. Addressed your concern. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30259/#review69727 ----------------------------------------------------------- On Jan. 29, 2015, 8:33 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30259/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 8:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1722 > https://issues.apache.org/jira/browse/KAFKA-1722 > > > Repository: kafka > > > Description > ------- > > KAFKA-1722: Add static code coverage capability > > > Diffs > ----- > > build.gradle a980f61def59ae59dbd5e58050285a801b21674f > core/src/main/scala/kafka/utils/ZkUtils.scala > c14bd455b6642f5e6eb254670bef9f57ae41d6cb > > Diff: https://reviews.apache.org/r/30259/diff/ > > > Testing > ------- > > How to run: ./gradlew sonarRunner -PscalaVersion=2.11 > > Note that if you do not have sonarqube running on your system. The > sonarRunner task will fail, but it would have generated coverage reports for > core and clients at core/build/reports/scoverage/ and > clients/build/reports/jacocoHtml respectively. Open index.html in any of > those dirs to see the coverage. > > Once gradle-scoverage starts publishing scoverage report, a single report > generated from sonar will be available. > > > Thanks, > > Ashish Singh > >
