> On Jan. 27, 2015, 1:39 a.m., Eric Olander wrote: > > core/src/main/scala/kafka/utils/ZkUtils.scala, line 17 > > <https://reviews.apache.org/r/30259/diff/1/?file=833669#file833669line17> > > > > Are there any open issues against scoverage that would explain why it > > can't instrument this class? If not, it might be worth contacting that > > project to see if they have any ideas why it blows up on this class. > > Probably would be good to add a TODO explaining that once scoverage can > > process this class the $COVERAGE-OFF$ should be removed.
I actually planned to put the todo and completely forgot about it. Thanks for pointing this out. I contacted gradle-scoverage guy to get insight into why is this not working, but suggestion was to skip this for now. However, I have not created an issue on the project. I will create an issue and put that in the TODO as well. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30259/#review69727 ----------------------------------------------------------- On Jan. 25, 2015, 8:47 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30259/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 8:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1722 > https://issues.apache.org/jira/browse/KAFKA-1722 > > > Repository: kafka > > > Description > ------- > > KAFKA-1722: Add static code coverage capability > > > Diffs > ----- > > build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28 > core/src/main/scala/kafka/utils/ZkUtils.scala > c14bd455b6642f5e6eb254670bef9f57ae41d6cb > > Diff: https://reviews.apache.org/r/30259/diff/ > > > Testing > ------- > > How to run: ./gradlew sonarRunner -PscalaVersion=2.11 > > Note that if you do not have sonarqube running on your system. The > sonarRunner task will fail, but it would have generated coverage reports for > core and clients at core/build/reports/scoverage/ and > clients/build/reports/jacocoHtml respectively. Open index.html in any of > those dirs to see the coverage. > > Once gradle-scoverage starts publishing scoverage report, a single report > generated from sonar will be available. > > > Thanks, > > Ashish Singh > >
